You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by "ajantha-bhat (via GitHub)" <gi...@apache.org> on 2023/03/12 11:48:14 UTC
[GitHub] [iceberg] ajantha-bhat opened a new pull request, #7089: Core: Refactor actions results
ajantha-bhat opened a new pull request, #7089:
URL: https://github.com/apache/iceberg/pull/7089
Each action has a separate boilerplate code with the public constructor. Which is hard to maintain. Also, the addition of new fields requires deprecating older constructors and adding a new one.
Recently two of the PRs (#6801, and #6091) also had to go through new constructors.
This is a follow-up on https://github.com/apache/iceberg/pull/6091#discussion_r1129758863
Note: only spark-3.3 is using the new builders. Other versions are still using the newly deprecated builders.
Will be replaced in a single follow-up PR after the review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] ajantha-bhat commented on pull request #7089: Core: Refactor actions results
Posted by "ajantha-bhat (via GitHub)" <gi...@apache.org>.
ajantha-bhat commented on PR #7089:
URL: https://github.com/apache/iceberg/pull/7089#issuecomment-1465224207
cc: @nastra, @aokolnychyi, @rdblue, @jackye1995
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] nastra commented on a diff in pull request #7089: Core: Refactor actions results
Posted by "nastra (via GitHub)" <gi...@apache.org>.
nastra commented on code in PR #7089:
URL: https://github.com/apache/iceberg/pull/7089#discussion_r1136598369
##########
core/src/main/java/org/apache/iceberg/actions/BaseRewriteDataFilesFileGroupInfo.java:
##########
@@ -21,6 +21,8 @@
import org.apache.iceberg.StructLike;
import org.apache.iceberg.relocated.com.google.common.base.MoreObjects;
+/** @deprecated will be removed in 1.3.0. */
Review Comment:
I think the deprecation message should mention what should be used alternatively. Also the version might need to be updated (depending on when this gets merged)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] ajantha-bhat commented on a diff in pull request #7089: Core: Refactor actions results
Posted by "ajantha-bhat (via GitHub)" <gi...@apache.org>.
ajantha-bhat commented on code in PR #7089:
URL: https://github.com/apache/iceberg/pull/7089#discussion_r1136679364
##########
core/src/main/java/org/apache/iceberg/actions/BaseRewriteDataFilesFileGroupInfo.java:
##########
@@ -21,6 +21,8 @@
import org.apache.iceberg.StructLike;
import org.apache.iceberg.relocated.com.google.common.base.MoreObjects;
+/** @deprecated will be removed in 1.3.0. */
Review Comment:
added the alternative and changed the version to 1.4.0 as 1.2.0 voting is already in progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] ajantha-bhat commented on pull request #7089: Core: Refactor actions results
Posted by "ajantha-bhat (via GitHub)" <gi...@apache.org>.
ajantha-bhat commented on PR #7089:
URL: https://github.com/apache/iceberg/pull/7089#issuecomment-1477211714
Since. 1.2.0 release vote is passed. This can be merged now I guess. Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] jackye1995 commented on pull request #7089: Core: Refactor actions results
Posted by "jackye1995 (via GitHub)" <gi...@apache.org>.
jackye1995 commented on PR #7089:
URL: https://github.com/apache/iceberg/pull/7089#issuecomment-1480319697
Merging, thanks for the change!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
[GitHub] [iceberg] jackye1995 merged pull request #7089: Core: Refactor actions results
Posted by "jackye1995 (via GitHub)" <gi...@apache.org>.
jackye1995 merged PR #7089:
URL: https://github.com/apache/iceberg/pull/7089
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org