You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by AhyoungRyu <gi...@git.apache.org> on 2016/11/15 14:23:37 UTC
[GitHub] zeppelin pull request #1640: Enable to search interpreters only based on the...
GitHub user AhyoungRyu opened a pull request:
https://github.com/apache/zeppelin/pull/1640
Enable to search interpreters only based on the name
### What is this PR for?
Currently when you're trying to search some interpreters, for example "Spark", the page shows both "Livy" and "Spark". It's because Livy contains Spark related properties `livy.spark.driver.cores`, `livy.spark.driver.memory` and etc etc. As a user aspect, I felt a bit uncomfortable with this.
So I added one more condition so that it can search only based on interpreter name.
### What type of PR is it?
Improvement
### What is the Jira issue?
no Jira issue for this
### How should this be tested?
Outline the steps to test the PR here.
### Screenshots (if appropriate)
- Before
- After
### Questions:
* Does the licenses files need update? no
* Is there breaking changes for older versions? no
* Does this needs documentation? no
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/AhyoungRyu/zeppelin search-basedOn-name
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/1640.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1640
----
commit 7564e1c1e680cbcef756228f2c99804b878c6488
Author: AhyoungRyu <fb...@hanmail.net>
Date: 2016-11-15T14:15:42Z
Search interpreter only based on interpreter name
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1640: Enable to search interpreters only based on the name
Posted by AhyoungRyu <gi...@git.apache.org>.
Github user AhyoungRyu commented on the issue:
https://github.com/apache/zeppelin/pull/1640
@1ambda yeah that could be available approach in the future. Thanks for your review!
Then will merge if there are no more discussions.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1640: Enable to search interpreters only based on the name
Posted by AhyoungRyu <gi...@git.apache.org>.
Github user AhyoungRyu commented on the issue:
https://github.com/apache/zeppelin/pull/1640
@1ambda I can address your feedback by changing `filter: {name:searchInterpreter}` to `filter: {interpreterGroup: {name: searchInterpreter}}`. In this case, if we type `pyspark`, then Livy interpreter will show above Spark again. Or if we type `sql`, then many interpreters that have `sql` as interpreterGroup name(e.g. `Bigquery`, `Jdbc`, `Spark`..) will show up. So current status would be enough I guess. What do you think?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1640: Enable to search interpreters only based on the name
Posted by 1ambda <gi...@git.apache.org>.
Github user 1ambda commented on the issue:
https://github.com/apache/zeppelin/pull/1640
I'v just tested. It works like @AhyoungRyu described.
It was annoying before this PR because filter investigated all fields in the interpreter :(
- create 2 JDBC interpreter named `postgres` and `duplicated` that have postgres dep
- insert filter `duplicated`
- check whether the `duplicated` interpreter is only selected
<img width="594" alt="screen shot 2016-11-15 at 11 53 26 pm" src="https://cloud.githubusercontent.com/assets/4968473/20310370/135f5c90-ab8f-11e6-945f-d34f8fee6600.png">
<img width="581" alt="screen shot 2016-11-15 at 11 53 33 pm" src="https://cloud.githubusercontent.com/assets/4968473/20310373/153ac306-ab8f-11e6-932d-a51180d070a0.png">
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1640: Enable to search interpreters only based on the name
Posted by 1ambda <gi...@git.apache.org>.
Github user 1ambda commented on the issue:
https://github.com/apache/zeppelin/pull/1640
@AhyoungRyu
If so, i think this is enough. Maybe we need a category dropbox to specify search area later.
Thanks for really needed improvement :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #1640: Enable to search interpreters only based on the...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/zeppelin/pull/1640
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1640: Enable to search interpreters only based on the name
Posted by 1ambda <gi...@git.apache.org>.
Github user 1ambda commented on the issue:
https://github.com/apache/zeppelin/pull/1640
I think this PR is cool :) @AhyoungRyu One more question,
What do you think if we can filter out interpreters using keywords like `%dep` `%r`?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1640: Enable to search interpreters only based on the name
Posted by AhyoungRyu <gi...@git.apache.org>.
Github user AhyoungRyu commented on the issue:
https://github.com/apache/zeppelin/pull/1640
@1ambda Thanks for your suggestion. That would be better I think. Let me update then :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---