[PATCH] Telnet docs typos

[Chris Todd <ch...@christophertodd.com>]

Hello ant developers-

I noticed what appear to be some typos in the telnet task docs.  I have
never submitted a patch to an open source project before, but I have RTFM in
that regard.  The patch file pasted below was generated with the following
command "diff -u index.html index.html.orig > index.html.patch".  As near as
I can tell, this is the way to do it.  Feel free to flame me if I got it
wrong.  :-)  I didn't attach the patch file because I use Outlook which
sometimes
botches attachments.

Chris Todd
Software Engineer
ctodd@alabanza.com
Alabanza Corporation

index.html.patch:

--- index.html	Wed Nov 29 13:05:18 2000
+++ index.html.orig	Wed Nov 29 13:01:41 2000
@@ -5455,12 +5455,12 @@
   </tr>
   <tr>
      <td>server</td>
-     <td>the address of the remote telnet server.</td>
+     <td>the address of the remote ftp server.</td>
      <td>Yes</td>
   </tr>
   <tr>
      <td>port</td>
-     <td>the port number of the remote telnet server. Defaults to port
21.</td>
+     <td>the port number of the remote ftp server. Defaults to port
21.</td>
      <td>No</td>
   </tr>
   <tr>
@@ -5475,11 +5475,11 @@
   </tr>
 </table>
 <h3>Examples</h3>
-A simple example of connecting to a server and running a command.  This
assumes a prompt of "login:" for the userid, and a prompt of "password:" for
the password.
+A simple example of connecting to a server and running a command.  This
assumes a prompt of "ogin:" for the userid, and a prompt of "ssword:" for
the password.
 <blockquote><pre>
 &lt;telnet userid=&quot;bob&quot; password=&quot;badpass&quot;
server=&quot;localhost&quot;&gt;
    &lt;read&gt;/home/bob&lt;/read&gt;
-   &lt;write&gt;ls&lt;/write&gt;
+   &lt;write&gt;ls&lt;/read&gt;
    &lt;read string=&quot;/home/bob&quot;/&gt;
 &lt;/telnet&gt;
 </pre></blockquote>
@@ -5487,12 +5487,12 @@
 This task can be rewritten as:
 <blockquote><pre>
 &lt;telnet server=&quot;localhost&quot;&gt;
-   &lt;read&gt;login:&lt;/read&gt;
-   &lt;write&gt;bob&lt;/write&gt;
-   &lt;read&gt;password:&lt;/read&gt;
-   &lt;write&gt;badpass&lt;/write&gt;
+   &lt;read&gt;ogin:&lt;/read&gt;
+   &lt;write&gt;bob&lt;/read&gt;
+   &lt;read&gt;ssword:&lt;/read&gt;
+   &lt;write&gt;badpass&lt;/read&gt;
    &lt;read&gt;/home/bob&lt;/read&gt;
-   &lt;write&gt;ls&lt;/write&gt;
+   &lt;write&gt;ls&lt;/read&gt;
    &lt;read&gt;/home/bob&lt;/read&gt;
 &lt;/telnet&gt;
 </pre></blockquote>
@@ -5501,7 +5501,7 @@
 <blockquote><pre>
 &lt;telnet userid=&quot;bob&quot; password=&quot;badpass&quot;
server=&quot;localhost&quot; timeout=&quot;20&quot;&gt;
    &lt;read&gt;/home/bob&lt;/read&gt;
-   &lt;write echo=&quot;false&quot;&gt;sleep 15&lt;/write&gt;
+   &lt;write echo=&quot;false&quot;&gt;sleep 15&lt;/read&gt;
    &lt;read timeout=&quot;10&quot;&gt;/home/bob&lt;/read&gt;
 &lt;/telnet&gt;
 </pre></blockquote>
@@ -5510,7 +5510,7 @@
 <blockquote><pre>
 &lt;telnet userid=&quot;bob&quot; password=&quot;badpass&quot;
server=&quot;localhost&quot; defaultTimeout=&quot;20&quot;&gt;
    &lt;read/&gt;
-   &lt;write&gt;GET / http/0.9&lt;/write&gt;
+   &lt;write&gt;GET / http/0.9&lt;/read&gt;
    &lt;write/&gt;
    &lt;read timeout=&quot;10&quot;&gt;&amp;lt;/HTML&amp;gt;&lt;/read&gt;
 &lt;/telnet&gt;



> -----Original Message-----
> From: bodewig@locus.apache.org [mailto:bodewig@locus.apache.org]
> Sent: Wednesday, November 29, 2000 12:16 PM
> To: jakarta-ant-cvs@apache.org
> Subject: cvs commit: jakarta-ant/docs index.html
>
>
> bodewig     00/11/29 09:15:29
>
>   Modified:    docs     index.html
>   Log:
>   Documentation for the telnet task.
>
>   Submitted by:	Scott Carlson <Sc...@email.com>
>
>   Revision  Changes    Path
>   1.157     +87 -0     jakarta-ant/docs/index.html
>


Sincerest regards,
Chris Todd
Software Engineer
Alabanza Corporation
ctodd@alabanza.com

Re: [PATCH] Telnet docs typos

[Stefan Bodewig <bo...@apache.org>]

Chris Todd <ch...@christophertodd.com> wrote:

> I noticed what appear to be some typos in the telnet task docs.

many thanks.

> I have never submitted a patch to an open source project before, but
> I have RTFM in that regard.  The patch file pasted below was
> generated with the following command "diff -u index.html
> index.html.orig > index.html.patch".  As near as I can tell, this is
> the way to do it.

should have been the other way around (diff -u old new), no need to
fear flames though 8-)

> I didn't attach the patch file because I use Outlook which sometimes
> botches attachments.

On the other hand it seems to reformat the text and will break lines
that used to be single lines (breaking the format of the diff
output). Personally I prefer attachments - even when sent by Outlook.

Stefan