You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by GitBox <gi...@apache.org> on 2021/01/29 05:35:26 UTC
[GitHub] [ozone] sadanand48 opened a new pull request #1851: TestOzoneFileSystem#testTrash failed when enabledFileSystemPaths and …
sadanand48 opened a new pull request #1851:
URL: https://github.com/apache/ozone/pull/1851
…omRatisDisabled
## What changes were proposed in this pull request?
TestOzoneFileSystem testTrash fails while setting `enableFsPaths` to true. This is because of using `DeleteKeyRequest `for delete.
There are 2 operations that happen when a key is moved to Trash 1. rename 2 .delete .
While Renaming a directory key, the renamedKey is stored in KeyTable with "/" (`RenameKeyRequest`) irrespective of whether enableFsPaths value but while deleting a key via `DeleteKeyRequest` the "/" is removed and a lookup is done on KeyTable which results in KEY_NOT_FOUND. Using `DeleteKey**s**` instead of `DeleteKey` will solve this issue as a lookup is not done on the normalised key.
[This PR](https://github.com/apache/ozone/pull/1256) explains why normalisation is not done while rename
## What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-4751
## How was this patch tested?
Existing Test Trash unit test.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] mukul1987 merged pull request #1851: HDDS-4751. TestOzoneFileSystem#testTrash failed when enabledFileSystemPaths and omRatisDisabled
Posted by GitBox <gi...@apache.org>.
mukul1987 merged pull request #1851:
URL: https://github.com/apache/ozone/pull/1851
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org