You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@storm.apache.org by vyan <gi...@git.apache.org> on 2017/06/16 10:24:45 UTC
[GitHub] storm pull request #2163: STORM-2553: Add support for password in JedisClust...
GitHub user vyan opened a pull request:
https://github.com/apache/storm/pull/2163
STORM-2553: Add support for password in JedisCluster
Upgrade Jedis version to 2.9.0, and modify some api for password support in JedisCluster
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/vyan/storm jedis-cluster-dev
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/storm/pull/2163.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2163
----
commit 014ff15153d88f6d7c42d5efc83818b61dda9696
Author: yan guotao <ya...@126.com>
Date: 2017-06-16T10:20:02Z
Add support for password in JedisCluster
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request #2163: STORM-2553: Add support for password in JedisClust...
Posted by HeartSaVioR <gi...@git.apache.org>.
Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/2163#discussion_r123164663
--- Diff: external/storm-redis/src/main/java/org/apache/storm/redis/common/config/JedisClusterConfig.java ---
@@ -45,6 +45,26 @@
* @param nodes list of node information for JedisCluster
* @param timeout socket / connection timeout
* @param maxRedirections limit of redirections - how much we'll follow MOVED or ASK
+ * @throws NullPointerException when you didn't set nodes
+ */
+ public JedisClusterConfig(Set<InetSocketAddress> nodes, int timeout, int maxRedirections) {
+ Preconditions.checkNotNull(nodes, "Node information should be presented");
--- End diff --
Maybe better to call `this(nodes, timeout, maxRedirections, null);` to remove duplicate codes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm issue #2163: STORM-2553: Add support for password in JedisCluster
Posted by HeartSaVioR <gi...@git.apache.org>.
Github user HeartSaVioR commented on the issue:
https://github.com/apache/storm/pull/2163
Looks good overall. Left comment regarding backward compatibility.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm issue #2163: STORM-2553: Add support for password in JedisCluster
Posted by vyan <gi...@git.apache.org>.
Github user vyan commented on the issue:
https://github.com/apache/storm/pull/2163
@HeartSaVioR, thanks for your comments. I have squashed all commits into one now.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm issue #2163: STORM-2553: Add support for password in JedisCluster
Posted by HeartSaVioR <gi...@git.apache.org>.
Github user HeartSaVioR commented on the issue:
https://github.com/apache/storm/pull/2163
@vyan Please squash commits into one after addressing my comment. Thanks in advance.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request #2163: STORM-2553: Add support for password in JedisClust...
Posted by HeartSaVioR <gi...@git.apache.org>.
Github user HeartSaVioR commented on a diff in the pull request:
https://github.com/apache/storm/pull/2163#discussion_r122565809
--- Diff: external/storm-redis/src/main/java/org/apache/storm/redis/common/config/JedisClusterConfig.java ---
@@ -44,14 +45,16 @@
* @param nodes list of node information for JedisCluster
* @param timeout socket / connection timeout
* @param maxRedirections limit of redirections - how much we'll follow MOVED or ASK
+ * @param password password, if any
* @throws NullPointerException when you didn't set nodes
*/
- public JedisClusterConfig(Set<InetSocketAddress> nodes, int timeout, int maxRedirections) {
+ public JedisClusterConfig(Set<InetSocketAddress> nodes, int timeout, int maxRedirections, String password) {
--- End diff --
Though we also have builder class as well, it would be better to have a separate constructor which doesn't have password as parameter, given that it was `public`.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm issue #2163: STORM-2553: Add support for password in JedisCluster
Posted by HeartSaVioR <gi...@git.apache.org>.
Github user HeartSaVioR commented on the issue:
https://github.com/apache/storm/pull/2163
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request #2163: STORM-2553: Add support for password in JedisClust...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/storm/pull/2163
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---