You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2021/05/11 01:17:34 UTC
[GitHub] [kafka] vichu opened a new pull request #10664: KAFKA-12749: Changelog topic config on suppressed KTable lost
vichu opened a new pull request #10664:
URL: https://github.com/apache/kafka/pull/10664
Refactored `logConfig` to be passed appropriately when using `shutDownWhenFull` or `emitEarlyWhenFull`. Removed the constructor that doesn't accept a `logConfig` parameter so you're forced to specify it explicitly, whether it's empty/unspecified or not.
Ticket: https://issues.apache.org/jira/browse/KAFKA-12749
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upgrade notes)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] cadonna commented on a change in pull request #10664: KAFKA-12749: Changelog topic config on suppressed KTable lost
Posted by GitBox <gi...@apache.org>.
cadonna commented on a change in pull request #10664:
URL: https://github.com/apache/kafka/pull/10664#discussion_r644644247
##########
File path: streams/src/main/java/org/apache/kafka/streams/kstream/internals/suppress/EagerBufferConfigImpl.java
##########
@@ -28,13 +28,7 @@
private final long maxBytes;
private final Map<String, String> logConfig;
- public EagerBufferConfigImpl(final long maxRecords, final long maxBytes) {
- this.maxRecords = maxRecords;
- this.maxBytes = maxBytes;
- this.logConfig = Collections.emptyMap();
- }
-
- private EagerBufferConfigImpl(final long maxRecords,
+ public EagerBufferConfigImpl(final long maxRecords,
final long maxBytes,
final Map<String, String> logConfig) {
Review comment:
nit
```suggestion
public EagerBufferConfigImpl(final long maxRecords,
final long maxBytes,
final Map<String, String> logConfig) {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] cadonna commented on pull request #10664: KAFKA-12749: Changelog topic config on suppressed KTable lost
Posted by GitBox <gi...@apache.org>.
cadonna commented on pull request #10664:
URL: https://github.com/apache/kafka/pull/10664#issuecomment-853748677
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] cadonna merged pull request #10664: KAFKA-12749: Changelog topic config on suppressed KTable lost
Posted by GitBox <gi...@apache.org>.
cadonna merged pull request #10664:
URL: https://github.com/apache/kafka/pull/10664
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] cadonna commented on a change in pull request #10664: KAFKA-12749: Changelog topic config on suppressed KTable lost
Posted by GitBox <gi...@apache.org>.
cadonna commented on a change in pull request #10664:
URL: https://github.com/apache/kafka/pull/10664#discussion_r644644247
##########
File path: streams/src/main/java/org/apache/kafka/streams/kstream/internals/suppress/EagerBufferConfigImpl.java
##########
@@ -28,13 +28,7 @@
private final long maxBytes;
private final Map<String, String> logConfig;
- public EagerBufferConfigImpl(final long maxRecords, final long maxBytes) {
- this.maxRecords = maxRecords;
- this.maxBytes = maxBytes;
- this.logConfig = Collections.emptyMap();
- }
-
- private EagerBufferConfigImpl(final long maxRecords,
+ public EagerBufferConfigImpl(final long maxRecords,
final long maxBytes,
final Map<String, String> logConfig) {
Review comment:
nit
```suggestion
public EagerBufferConfigImpl(final long maxRecords,
final long maxBytes,
final Map<String, String> logConfig) {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] wcarlson5 commented on a change in pull request #10664: KAFKA-12749: Changelog topic config on suppressed KTable lost
Posted by GitBox <gi...@apache.org>.
wcarlson5 commented on a change in pull request #10664:
URL: https://github.com/apache/kafka/pull/10664#discussion_r632673138
##########
File path: streams/src/test/java/org/apache/kafka/streams/kstream/SuppressedTest.java
##########
@@ -46,13 +48,13 @@ public void bufferBuilderShouldBeConsistent() {
assertThat(
"keys alone should be set",
maxRecords(2L),
- is(new EagerBufferConfigImpl(2L, MAX_VALUE))
+ is(new EagerBufferConfigImpl(2L, MAX_VALUE, Collections.emptyMap()))
Review comment:
@vichu Can you add some tests that don't just use an empty map?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] cadonna commented on pull request #10664: KAFKA-12749: Changelog topic config on suppressed KTable lost
Posted by GitBox <gi...@apache.org>.
cadonna commented on pull request #10664:
URL: https://github.com/apache/kafka/pull/10664#issuecomment-854068049
The 7th build was green on the same commit. I do not know why a 8th build was started.
https://ci-builds.apache.org/blue/organizations/jenkins/Kafka%2Fkafka-pr/detail/PR-10664/7/pipeline/15
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] vichu commented on a change in pull request #10664: KAFKA-12749: Changelog topic config on suppressed KTable lost
Posted by GitBox <gi...@apache.org>.
vichu commented on a change in pull request #10664:
URL: https://github.com/apache/kafka/pull/10664#discussion_r633000249
##########
File path: streams/src/test/java/org/apache/kafka/streams/kstream/SuppressedTest.java
##########
@@ -46,13 +48,13 @@ public void bufferBuilderShouldBeConsistent() {
assertThat(
"keys alone should be set",
maxRecords(2L),
- is(new EagerBufferConfigImpl(2L, MAX_VALUE))
+ is(new EagerBufferConfigImpl(2L, MAX_VALUE, Collections.emptyMap()))
Review comment:
Sure.
Added a few tests to verify the `logConfig` map as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] ableegoldman commented on pull request #10664: KAFKA-12749: Changelog topic config on suppressed KTable lost
Posted by GitBox <gi...@apache.org>.
ableegoldman commented on pull request #10664:
URL: https://github.com/apache/kafka/pull/10664#issuecomment-837607688
cc any of @cadonna @vvcephei @lct45 @wcarlson5 @mjsax @guozhangwang to review this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] vichu commented on pull request #10664: KAFKA-12749: Changelog topic config on suppressed KTable lost
Posted by GitBox <gi...@apache.org>.
vichu commented on pull request #10664:
URL: https://github.com/apache/kafka/pull/10664#issuecomment-837597679
@ableegoldman Would appreciate it if you can take a look at this PR when you get a chance.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] cadonna commented on pull request #10664: KAFKA-12749: Changelog topic config on suppressed KTable lost
Posted by GitBox <gi...@apache.org>.
cadonna commented on pull request #10664:
URL: https://github.com/apache/kafka/pull/10664#issuecomment-853748677
@vichu I took the liberty to commit the fix to the nit directly. I hope that is fine with you.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] vichu commented on a change in pull request #10664: KAFKA-12749: Changelog topic config on suppressed KTable lost
Posted by GitBox <gi...@apache.org>.
vichu commented on a change in pull request #10664:
URL: https://github.com/apache/kafka/pull/10664#discussion_r633000249
##########
File path: streams/src/test/java/org/apache/kafka/streams/kstream/SuppressedTest.java
##########
@@ -46,13 +48,13 @@ public void bufferBuilderShouldBeConsistent() {
assertThat(
"keys alone should be set",
maxRecords(2L),
- is(new EagerBufferConfigImpl(2L, MAX_VALUE))
+ is(new EagerBufferConfigImpl(2L, MAX_VALUE, Collections.emptyMap()))
Review comment:
Sure.
Added a few tests to verify the `logConfig` map as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] wcarlson5 commented on pull request #10664: KAFKA-12749: Changelog topic config on suppressed KTable lost
Posted by GitBox <gi...@apache.org>.
wcarlson5 commented on pull request #10664:
URL: https://github.com/apache/kafka/pull/10664#issuecomment-852546841
Sorry, this got lost in my inbox. @vichu if you can rebase I think its good to go. do you agree @ableegoldman ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] cadonna commented on pull request #10664: KAFKA-12749: Changelog topic config on suppressed KTable lost
Posted by GitBox <gi...@apache.org>.
cadonna commented on pull request #10664:
URL: https://github.com/apache/kafka/pull/10664#issuecomment-853748989
I will merge as soon as the checks are done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] cadonna merged pull request #10664: KAFKA-12749: Changelog topic config on suppressed KTable lost
Posted by GitBox <gi...@apache.org>.
cadonna merged pull request #10664:
URL: https://github.com/apache/kafka/pull/10664
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org