You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@manifoldcf.apache.org by "Karl Wright (Created) (JIRA)" <ji...@apache.org> on 2011/12/13 15:01:31 UTC

[jira] [Created] (CONNECTORS-314) Combined MySQL and i18n/Japanese contribution

Combined MySQL and i18n/Japanese contribution
---------------------------------------------

                 Key: CONNECTORS-314
                 URL: https://issues.apache.org/jira/browse/CONNECTORS-314
             Project: ManifoldCF
          Issue Type: Improvement
          Components: Framework agents process, Framework core, Framework crawler agent
    Affects Versions: ManifoldCF next
            Reporter: Karl Wright
            Assignee: Karl Wright
             Fix For: ManifoldCF next


Hitoshi Ozawa wishes to contribute i18n support, a Japanese localization, and MySQL database support, all in one patch.


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Re: [jira] [Commented] (CONNECTORS-314) Combined MySQL and i18n/Japanese contribution

Posted by Hitoshi Ozawa <ht...@gmail.com>.
Hi again,

I want to get it to a situation where I can introduce this to Japanese
users quickly as possible. I think most are going to use just Solr,
AD, File, DB, and Web with MySQL.
I'm working on Japanese documentation because that's important too.
There's some hardcoded messages such as "AM" and "PM" to signify time,
but I don't think that it too important yet at this stage.

There's also some issues that I've been notified - mainly concerning
performance when there are over 1 million files to crawl. I'll create
issues concerning these after finishing
up the above topics.

Regards,
H.Ozawa

2011/12/27 Karl Wright (Commented) (JIRA) <ji...@apache.org>:
>
>    [ https://issues.apache.org/jira/browse/CONNECTORS-314?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13176030#comment-13176030 ]
>
> Karl Wright commented on CONNECTORS-314:
> ----------------------------------------
>
> Hi Hitoshi,
>
> I apologize - I was away for the last couple of days, and could not respond immediately to your questions.
>
> I'd like to work with you to finish the i18n and Japanese l10n work as soon as possible.  The outstanding issues, as far as I see it, are the following:
>
> - The i18n work is not complete for all connectors.  This, I think, can be addressed over time; there's no need for it to be all complete right way.  But we should definitely work to complete it.  I think the best approach would be to first commit the infrastructure changes (as contained in branches/CONNECTORS-335), and then work on individual tickets for completion of individual connectors and authorities.
> - There's some question in my mind as to whether it is best to just use language or use the full locale for localization.  For example, "ja_JP" and "en_US" vs. "ja" and "en".  It would be good to hear your opinion as to which would be the most appropriate for ManifoldCF.  Right now I'm using the full locale, but we should switch over to just language if you think that that is appropriate.
>
> Comments?
>
>
>> Combined MySQL and i18n/Japanese contribution
>> ---------------------------------------------
>>
>>                 Key: CONNECTORS-314
>>                 URL: https://issues.apache.org/jira/browse/CONNECTORS-314
>>             Project: ManifoldCF
>>          Issue Type: Improvement
>>          Components: Framework agents process, Framework core, Framework crawler agent
>>    Affects Versions: ManifoldCF 0.5
>>            Reporter: Karl Wright
>>            Assignee: Karl Wright
>>              Labels: I18N, mysql
>>             Fix For: ManifoldCF 0.5
>>
>>         Attachments: CONNECTORS-314-20111225.patch, CONNECTORS-314-doc20111220.patch, CONNECTORS-314.patch, CONNECTORS-314.patch, connectors.patch, framework.patch
>>
>>
>> Hitoshi Ozawa wishes to contribute i18n support, a Japanese localization, and MySQL database support, all in one patch.
>
> --
> This message is automatically generated by JIRA.
> If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
> For more information on JIRA, see: http://www.atlassian.com/software/jira
>
>

Re: [jira] [Commented] (CONNECTORS-314) Combined MySQL and i18n/Japanese contribution

Posted by Hitoshi Ozawa <ht...@gmail.com>.
We can switch the properties file name to full language_country. I
should have standardized it instead of using just language for some
and full for others.

H.Ozawa

2011/12/27 Karl Wright (Commented) (JIRA) <ji...@apache.org>:
>
>    [ https://issues.apache.org/jira/browse/CONNECTORS-314?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13176030#comment-13176030 ]
>
> Karl Wright commented on CONNECTORS-314:
> ----------------------------------------
>
> Hi Hitoshi,
>
> I apologize - I was away for the last couple of days, and could not respond immediately to your questions.
>
> I'd like to work with you to finish the i18n and Japanese l10n work as soon as possible.  The outstanding issues, as far as I see it, are the following:
>
> - The i18n work is not complete for all connectors.  This, I think, can be addressed over time; there's no need for it to be all complete right way.  But we should definitely work to complete it.  I think the best approach would be to first commit the infrastructure changes (as contained in branches/CONNECTORS-335), and then work on individual tickets for completion of individual connectors and authorities.
> - There's some question in my mind as to whether it is best to just use language or use the full locale for localization.  For example, "ja_JP" and "en_US" vs. "ja" and "en".  It would be good to hear your opinion as to which would be the most appropriate for ManifoldCF.  Right now I'm using the full locale, but we should switch over to just language if you think that that is appropriate.
>
> Comments?
>
>
>> Combined MySQL and i18n/Japanese contribution
>> ---------------------------------------------
>>
>>                 Key: CONNECTORS-314
>>                 URL: https://issues.apache.org/jira/browse/CONNECTORS-314
>>             Project: ManifoldCF
>>          Issue Type: Improvement
>>          Components: Framework agents process, Framework core, Framework crawler agent
>>    Affects Versions: ManifoldCF 0.5
>>            Reporter: Karl Wright
>>            Assignee: Karl Wright
>>              Labels: I18N, mysql
>>             Fix For: ManifoldCF 0.5
>>
>>         Attachments: CONNECTORS-314-20111225.patch, CONNECTORS-314-doc20111220.patch, CONNECTORS-314.patch, CONNECTORS-314.patch, connectors.patch, framework.patch
>>
>>
>> Hitoshi Ozawa wishes to contribute i18n support, a Japanese localization, and MySQL database support, all in one patch.
>
> --
> This message is automatically generated by JIRA.
> If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
> For more information on JIRA, see: http://www.atlassian.com/software/jira
>
>

[jira] [Commented] (CONNECTORS-314) Combined MySQL and i18n/Japanese contribution

Posted by "Hitoshi Ozawa (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CONNECTORS-314?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13172789#comment-13172789 ] 

Hitoshi Ozawa commented on CONNECTORS-314:
------------------------------------------

>>I've also changed the default properties.xml to use mysql.
>> Needs mysql user and password to run properly.

>I'm afraid I'm going to need to revert this change, since it basically means you have >to have MySQL running in order to use ManifoldCF under Maven. Hope that's okay with >you.

No problem here. I just changed it for demo purpose because I've also changed some sql's directly so that the currrent patch won't correctly work with non-mysql database. Would have to work on it before integrating into the svn trunk.

Nevertheless, I thought having sample properties files for each database would help users. I've created properties.xml.derby and properties.xml.mysql.I think I forgot to include properties.xml.postgresql.

I've used the following jars:
mysql-connector-java-5.1.18-bin.jar
http://dev.mysql.com/downloads/connector/j/

I've deleted jstl.jar and standards.jar under crawler-ui directory and replaced it with jstl-api-1.2.jar and jstl-impl-1.2.jar from the page below:
http://jstl.java.net/download.html
                
> Combined MySQL and i18n/Japanese contribution
> ---------------------------------------------
>
>                 Key: CONNECTORS-314
>                 URL: https://issues.apache.org/jira/browse/CONNECTORS-314
>             Project: ManifoldCF
>          Issue Type: Improvement
>          Components: Framework agents process, Framework core, Framework crawler agent
>    Affects Versions: ManifoldCF 0.5
>            Reporter: Karl Wright
>            Assignee: Karl Wright
>              Labels: I18N, mysql
>             Fix For: ManifoldCF 0.5
>
>         Attachments: CONNECTORS-314-doc20111220.patch, CONNECTORS-314.patch, CONNECTORS-314.patch, connectors.patch, framework.patch
>
>
> Hitoshi Ozawa wishes to contribute i18n support, a Japanese localization, and MySQL database support, all in one patch.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (CONNECTORS-314) Combined MySQL and i18n/Japanese contribution

Posted by "Hitoshi Ozawa (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CONNECTORS-314?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Hitoshi Ozawa updated CONNECTORS-314:
-------------------------------------

    Attachment: CONNECTORS-314-doc20111220.patch

As for the forrest documentation structure, how about the creating a Japanese tab and just creating a japanese subdirectory under xdocs? I've attached a tabs.xml and site.xml patch.
                
> Combined MySQL and i18n/Japanese contribution
> ---------------------------------------------
>
>                 Key: CONNECTORS-314
>                 URL: https://issues.apache.org/jira/browse/CONNECTORS-314
>             Project: ManifoldCF
>          Issue Type: Improvement
>          Components: Framework agents process, Framework core, Framework crawler agent
>    Affects Versions: ManifoldCF 0.5
>            Reporter: Karl Wright
>            Assignee: Karl Wright
>              Labels: I18N, mysql
>             Fix For: ManifoldCF 0.5
>
>         Attachments: CONNECTORS-314-doc20111220.patch, CONNECTORS-314.patch, CONNECTORS-314.patch, connectors.patch, framework.patch
>
>
> Hitoshi Ozawa wishes to contribute i18n support, a Japanese localization, and MySQL database support, all in one patch.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Issue Comment Edited] (CONNECTORS-314) Combined MySQL and i18n/Japanese contribution

Posted by "Karl Wright (Issue Comment Edited) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CONNECTORS-314?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13175232#comment-13175232 ] 

Karl Wright edited comment on CONNECTORS-314 at 12/23/11 2:13 AM:
------------------------------------------------------------------

Hi Koji - I was wondering if maybe the .utf8 files are in fact the source files for the _ja.properties files, in which case we should probably keep the .utf8 files and generate the properties files dynamically.

In fact I have confirmed that's how it works... so now I'm going to make appropriate rearrangements in the CONNECTORS-335 branch.

                
      was (Author: kwright@metacarta.com):
    Hi Koji - the only thing I'm wondering is if maybe the .utf8 files are in fact the source files for the _ja.properties files, in which case we should probably keep the .utf8 files and generate the properties files dynamically.  It's hard for me to tell what the intent was here.
                  
> Combined MySQL and i18n/Japanese contribution
> ---------------------------------------------
>
>                 Key: CONNECTORS-314
>                 URL: https://issues.apache.org/jira/browse/CONNECTORS-314
>             Project: ManifoldCF
>          Issue Type: Improvement
>          Components: Framework agents process, Framework core, Framework crawler agent
>    Affects Versions: ManifoldCF 0.5
>            Reporter: Karl Wright
>            Assignee: Karl Wright
>              Labels: I18N, mysql
>             Fix For: ManifoldCF 0.5
>
>         Attachments: CONNECTORS-314-doc20111220.patch, CONNECTORS-314.patch, CONNECTORS-314.patch, connectors.patch, framework.patch
>
>
> Hitoshi Ozawa wishes to contribute i18n support, a Japanese localization, and MySQL database support, all in one patch.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (CONNECTORS-314) Combined MySQL and i18n/Japanese contribution

Posted by "Karl Wright (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CONNECTORS-314?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13171984#comment-13171984 ] 

Karl Wright commented on CONNECTORS-314:
----------------------------------------

bq. Where can I obtain the xml file? I'm still at early stage and it won't be too much of a problem.

Obtain it like this:

svn co https://svn.apache.org/repos/asf/incubator/lcf/CONNECTORS-314
cd CONNECTORS-314\site\src\documentation\content\xdocs

In this directory you will see many .xml files.  They should give you an idea about how the site is rendered.

                
> Combined MySQL and i18n/Japanese contribution
> ---------------------------------------------
>
>                 Key: CONNECTORS-314
>                 URL: https://issues.apache.org/jira/browse/CONNECTORS-314
>             Project: ManifoldCF
>          Issue Type: Improvement
>          Components: Framework agents process, Framework core, Framework crawler agent
>    Affects Versions: ManifoldCF 0.5
>            Reporter: Karl Wright
>            Assignee: Karl Wright
>              Labels: I18N, mysql
>             Fix For: ManifoldCF 0.5
>
>         Attachments: connectors.patch, framework.patch
>
>
> Hitoshi Ozawa wishes to contribute i18n support, a Japanese localization, and MySQL database support, all in one patch.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (CONNECTORS-314) Combined MySQL and i18n/Japanese contribution

Posted by "Karl Wright (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CONNECTORS-314?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Karl Wright updated CONNECTORS-314:
-----------------------------------

    Affects Version/s:     (was: ManifoldCF next)
                       ManifoldCF 0.5
        Fix Version/s:     (was: ManifoldCF next)
                       ManifoldCF 0.5
    
> Combined MySQL and i18n/Japanese contribution
> ---------------------------------------------
>
>                 Key: CONNECTORS-314
>                 URL: https://issues.apache.org/jira/browse/CONNECTORS-314
>             Project: ManifoldCF
>          Issue Type: Improvement
>          Components: Framework agents process, Framework core, Framework crawler agent
>    Affects Versions: ManifoldCF 0.5
>            Reporter: Karl Wright
>            Assignee: Karl Wright
>             Fix For: ManifoldCF 0.5
>
>
> Hitoshi Ozawa wishes to contribute i18n support, a Japanese localization, and MySQL database support, all in one patch.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Issue Comment Edited] (CONNECTORS-314) Combined MySQL and i18n/Japanese contribution

Posted by "Karl Wright (Issue Comment Edited) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CONNECTORS-314?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13176161#comment-13176161 ] 

Karl Wright edited comment on CONNECTORS-314 at 12/27/11 1:07 PM:
------------------------------------------------------------------

bq. We can switch the properties file name to full language_country. I should have standardized it instead of using just language for some and full for others.

What I'm going to try is to convert to <%=Message.getString()%> instead of <fmt... /> for the JSP pages.  This will allow everything to be consistent and run out of the same localization files.  In addition, it should be possible to create localization escalation paths - e.g. if "ja_JP" is not there we look for "ja" and then "en_US" and then "en".  That would minimize the maintenance task going forward.

                
      was (Author: kwright@metacarta.com):
    bq. We can switch the properties file name to full language_country. I
should have standardized it instead of using just language for some
and full for others.

What I'm going to try is to convert to <%=Message.getString()%> instead of <fmt... /> for the JSP pages.  This will allow everything to be consistent and run out of the same localization files.  In addition, it should be possible to create localization escalation paths - e.g. if "ja_JP" is not there we look for "ja" and then "en_US" and then "en".  That would minimize the maintenance task going forward.

                  
> Combined MySQL and i18n/Japanese contribution
> ---------------------------------------------
>
>                 Key: CONNECTORS-314
>                 URL: https://issues.apache.org/jira/browse/CONNECTORS-314
>             Project: ManifoldCF
>          Issue Type: Improvement
>          Components: Framework agents process, Framework core, Framework crawler agent
>    Affects Versions: ManifoldCF 0.5
>            Reporter: Karl Wright
>            Assignee: Karl Wright
>              Labels: I18N, mysql
>             Fix For: ManifoldCF 0.5
>
>         Attachments: CONNECTORS-314-20111225.patch, CONNECTORS-314-doc20111220.patch, CONNECTORS-314.patch, CONNECTORS-314.patch, connectors.patch, framework.patch
>
>
> Hitoshi Ozawa wishes to contribute i18n support, a Japanese localization, and MySQL database support, all in one patch.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (CONNECTORS-314) Combined MySQL and i18n/Japanese contribution

Posted by "Karl Wright (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CONNECTORS-314?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13176021#comment-13176021 ] 

Karl Wright commented on CONNECTORS-314:
----------------------------------------

The MySQL work was already committed directly to trunk.  The i18n work is in branches/CONNECTORS-335 and is ready to commit except for one problem: it breaks the Maven build.  So as soon as that is fixed the commit will happen.  branches/CONNECTORS-336 contains the documentation changes which will also be committed to trunk when that is ready, which I presume will take a while.

Hope this helps!

                
> Combined MySQL and i18n/Japanese contribution
> ---------------------------------------------
>
>                 Key: CONNECTORS-314
>                 URL: https://issues.apache.org/jira/browse/CONNECTORS-314
>             Project: ManifoldCF
>          Issue Type: Improvement
>          Components: Framework agents process, Framework core, Framework crawler agent
>    Affects Versions: ManifoldCF 0.5
>            Reporter: Karl Wright
>            Assignee: Karl Wright
>              Labels: I18N, mysql
>             Fix For: ManifoldCF 0.5
>
>         Attachments: CONNECTORS-314-20111225.patch, CONNECTORS-314-doc20111220.patch, CONNECTORS-314.patch, CONNECTORS-314.patch, connectors.patch, framework.patch
>
>
> Hitoshi Ozawa wishes to contribute i18n support, a Japanese localization, and MySQL database support, all in one patch.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (CONNECTORS-314) Combined MySQL and i18n/Japanese contribution

Posted by "Karl Wright (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CONNECTORS-314?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13171993#comment-13171993 ] 

Karl Wright commented on CONNECTORS-314:
----------------------------------------

bq. Please upgrade the svn. Sorry for the trouble.

Done.  branches/CONNECTORS-314 is now what trunk looked like at the end of the day on 11/29/2011.  Please let me know if you find any problems.

                
> Combined MySQL and i18n/Japanese contribution
> ---------------------------------------------
>
>                 Key: CONNECTORS-314
>                 URL: https://issues.apache.org/jira/browse/CONNECTORS-314
>             Project: ManifoldCF
>          Issue Type: Improvement
>          Components: Framework agents process, Framework core, Framework crawler agent
>    Affects Versions: ManifoldCF 0.5
>            Reporter: Karl Wright
>            Assignee: Karl Wright
>              Labels: I18N, mysql
>             Fix For: ManifoldCF 0.5
>
>         Attachments: connectors.patch, framework.patch
>
>
> Hitoshi Ozawa wishes to contribute i18n support, a Japanese localization, and MySQL database support, all in one patch.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (CONNECTORS-314) Combined MySQL and i18n/Japanese contribution

Posted by "Karl Wright (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CONNECTORS-314?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13172809#comment-13172809 ] 

Karl Wright commented on CONNECTORS-314:
----------------------------------------

I got the database driver working, in the single-process example.  I had to clean up quite a bit of stuff having to do with database naming etc.  To use:

ant build-dev
cd dist\example
[edit properties.xml to replace the database class as follows:
  <property name="org.apache.manifoldcf.databaseimplementationclass" value="org.apache.manifoldcf.core.database.DBInterfaceMySQL"/>
  <property name="org.apache.manifoldcf.dbsuperusername" value="root"/>
  <property name="org.apache.manifoldcf.dbsuperuserpassword" value="mysql"/>
... or whatever the superuser password is on your mysql installation]
<java> -jar start.jar

... and everything pretty much works, except for the reports.



                
> Combined MySQL and i18n/Japanese contribution
> ---------------------------------------------
>
>                 Key: CONNECTORS-314
>                 URL: https://issues.apache.org/jira/browse/CONNECTORS-314
>             Project: ManifoldCF
>          Issue Type: Improvement
>          Components: Framework agents process, Framework core, Framework crawler agent
>    Affects Versions: ManifoldCF 0.5
>            Reporter: Karl Wright
>            Assignee: Karl Wright
>              Labels: I18N, mysql
>             Fix For: ManifoldCF 0.5
>
>         Attachments: CONNECTORS-314-doc20111220.patch, CONNECTORS-314.patch, CONNECTORS-314.patch, connectors.patch, framework.patch
>
>
> Hitoshi Ozawa wishes to contribute i18n support, a Japanese localization, and MySQL database support, all in one patch.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (CONNECTORS-314) Combined MySQL and i18n/Japanese contribution

Posted by "Karl Wright (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CONNECTORS-314?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13172812#comment-13172812 ] 

Karl Wright commented on CONNECTORS-314:
----------------------------------------

bq. I've deleted jstl.jar and standards.jar under crawler-ui directory and replaced it with jstl-api-1.2.jar and jstl-impl-1.2.jar from the page below: http://jstl.java.net/download.html

Ok, this has been checked in.

Also, you can automatically download a mysql driver by doing this BEFORE your first ant build-dev:

ant download-dependencies



                
> Combined MySQL and i18n/Japanese contribution
> ---------------------------------------------
>
>                 Key: CONNECTORS-314
>                 URL: https://issues.apache.org/jira/browse/CONNECTORS-314
>             Project: ManifoldCF
>          Issue Type: Improvement
>          Components: Framework agents process, Framework core, Framework crawler agent
>    Affects Versions: ManifoldCF 0.5
>            Reporter: Karl Wright
>            Assignee: Karl Wright
>              Labels: I18N, mysql
>             Fix For: ManifoldCF 0.5
>
>         Attachments: CONNECTORS-314-doc20111220.patch, CONNECTORS-314.patch, CONNECTORS-314.patch, connectors.patch, framework.patch
>
>
> Hitoshi Ozawa wishes to contribute i18n support, a Japanese localization, and MySQL database support, all in one patch.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (CONNECTORS-314) Combined MySQL and i18n/Japanese contribution

Posted by "Karl Wright (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CONNECTORS-314?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13176398#comment-13176398 ] 

Karl Wright commented on CONNECTORS-314:
----------------------------------------

bq. BTW, I'm thinking of finishing all of I18N/L10N by March for the 0.5 release. 

That's great news!
I just committed CONNECTORS-335 to trunk.  Going forward, let's create a ticket for each separate patch/batch of changes.  Now that the infrastructure is in place it should be straightforward to commit each such change directly to trunk as they arise.

For example, if you decide to work on the Documentum connector, open a ticket "Finish internationalization/localization work for Documentum", and attach a patch accordingly.

Thanks!
Karl

                
> Combined MySQL and i18n/Japanese contribution
> ---------------------------------------------
>
>                 Key: CONNECTORS-314
>                 URL: https://issues.apache.org/jira/browse/CONNECTORS-314
>             Project: ManifoldCF
>          Issue Type: Improvement
>          Components: Framework agents process, Framework core, Framework crawler agent
>    Affects Versions: ManifoldCF 0.5
>            Reporter: Karl Wright
>            Assignee: Karl Wright
>              Labels: I18N, mysql
>             Fix For: ManifoldCF 0.5
>
>         Attachments: CONNECTORS-314-20111225.patch, CONNECTORS-314-doc20111220.patch, CONNECTORS-314.patch, CONNECTORS-314.patch, connectors.patch, framework.patch
>
>
> Hitoshi Ozawa wishes to contribute i18n support, a Japanese localization, and MySQL database support, all in one patch.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (CONNECTORS-314) Combined MySQL and i18n/Japanese contribution

Posted by "Hitoshi Ozawa (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CONNECTORS-314?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13176973#comment-13176973 ] 

Hitoshi Ozawa commented on CONNECTORS-314:
------------------------------------------

bq. I just committed CONNECTORS-335 to trunk.

Just want to make sure again. Should I be getting the source code from the trunk now?
Where are fixes for the CONNECTORS-338 and CONNECTORS-340 being committed?
                
> Combined MySQL and i18n/Japanese contribution
> ---------------------------------------------
>
>                 Key: CONNECTORS-314
>                 URL: https://issues.apache.org/jira/browse/CONNECTORS-314
>             Project: ManifoldCF
>          Issue Type: Improvement
>          Components: Framework agents process, Framework core, Framework crawler agent
>    Affects Versions: ManifoldCF 0.5
>            Reporter: Karl Wright
>            Assignee: Karl Wright
>              Labels: I18N, mysql
>             Fix For: ManifoldCF 0.5
>
>         Attachments: CONNECTORS-314-20111225.patch, CONNECTORS-314-doc20111220.patch, CONNECTORS-314.patch, CONNECTORS-314.patch, connectors.patch, framework.patch
>
>
> Hitoshi Ozawa wishes to contribute i18n support, a Japanese localization, and MySQL database support, all in one patch.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (CONNECTORS-314) Combined MySQL and i18n/Japanese contribution

Posted by "Karl Wright (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CONNECTORS-314?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13175347#comment-13175347 ] 

Karl Wright commented on CONNECTORS-314:
----------------------------------------

bq. I've not looked into build.xml, but if .properties.utf8 is source file of .properties (and I expect so), .properties files shouldn't be registered in svn.

Koji - that is what I concluded.  I've corrected the problem in branches/CONNECTORS-335.
                
> Combined MySQL and i18n/Japanese contribution
> ---------------------------------------------
>
>                 Key: CONNECTORS-314
>                 URL: https://issues.apache.org/jira/browse/CONNECTORS-314
>             Project: ManifoldCF
>          Issue Type: Improvement
>          Components: Framework agents process, Framework core, Framework crawler agent
>    Affects Versions: ManifoldCF 0.5
>            Reporter: Karl Wright
>            Assignee: Karl Wright
>              Labels: I18N, mysql
>             Fix For: ManifoldCF 0.5
>
>         Attachments: CONNECTORS-314-doc20111220.patch, CONNECTORS-314.patch, CONNECTORS-314.patch, connectors.patch, framework.patch
>
>
> Hitoshi Ozawa wishes to contribute i18n support, a Japanese localization, and MySQL database support, all in one patch.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (CONNECTORS-314) Combined MySQL and i18n/Japanese contribution

Posted by "Hitoshi Ozawa (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CONNECTORS-314?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Hitoshi Ozawa updated CONNECTORS-314:
-------------------------------------

    Attachment: connectors.patch
                framework.patch

I've used the 2011/11/29 svn but created a patch with the apache-manifoldcf-0.3-incubating

I've also modified SQL statements to work with mysql overwriting the postgresql sql statements. Would need to move these to each database's classes. This is just an initial modification and probably would require changes to tune for performance.

Cheers,
                
> Combined MySQL and i18n/Japanese contribution
> ---------------------------------------------
>
>                 Key: CONNECTORS-314
>                 URL: https://issues.apache.org/jira/browse/CONNECTORS-314
>             Project: ManifoldCF
>          Issue Type: Improvement
>          Components: Framework agents process, Framework core, Framework crawler agent
>    Affects Versions: ManifoldCF 0.5
>            Reporter: Karl Wright
>            Assignee: Karl Wright
>              Labels: I18N, mysql
>             Fix For: ManifoldCF 0.5
>
>         Attachments: connectors.patch, framework.patch
>
>
> Hitoshi Ozawa wishes to contribute i18n support, a Japanese localization, and MySQL database support, all in one patch.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (CONNECTORS-314) Combined MySQL and i18n/Japanese contribution

Posted by "Karl Wright (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CONNECTORS-314?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13172837#comment-13172837 ] 

Karl Wright commented on CONNECTORS-314:
----------------------------------------

Nevermind, it was just a stupid error on my part.

Committed your changes: r1221068.

                
> Combined MySQL and i18n/Japanese contribution
> ---------------------------------------------
>
>                 Key: CONNECTORS-314
>                 URL: https://issues.apache.org/jira/browse/CONNECTORS-314
>             Project: ManifoldCF
>          Issue Type: Improvement
>          Components: Framework agents process, Framework core, Framework crawler agent
>    Affects Versions: ManifoldCF 0.5
>            Reporter: Karl Wright
>            Assignee: Karl Wright
>              Labels: I18N, mysql
>             Fix For: ManifoldCF 0.5
>
>         Attachments: CONNECTORS-314-doc20111220.patch, CONNECTORS-314.patch, CONNECTORS-314.patch, connectors.patch, framework.patch
>
>
> Hitoshi Ozawa wishes to contribute i18n support, a Japanese localization, and MySQL database support, all in one patch.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (CONNECTORS-314) Combined MySQL and i18n/Japanese contribution

Posted by "Karl Wright (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CONNECTORS-314?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13172840#comment-13172840 ] 

Karl Wright commented on CONNECTORS-314:
----------------------------------------

I think the next code stage will be to move the localization property data to its correct places.  Is this something you want to do, or should I try and tackle it?

                
> Combined MySQL and i18n/Japanese contribution
> ---------------------------------------------
>
>                 Key: CONNECTORS-314
>                 URL: https://issues.apache.org/jira/browse/CONNECTORS-314
>             Project: ManifoldCF
>          Issue Type: Improvement
>          Components: Framework agents process, Framework core, Framework crawler agent
>    Affects Versions: ManifoldCF 0.5
>            Reporter: Karl Wright
>            Assignee: Karl Wright
>              Labels: I18N, mysql
>             Fix For: ManifoldCF 0.5
>
>         Attachments: CONNECTORS-314-doc20111220.patch, CONNECTORS-314.patch, CONNECTORS-314.patch, connectors.patch, framework.patch
>
>
> Hitoshi Ozawa wishes to contribute i18n support, a Japanese localization, and MySQL database support, all in one patch.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (CONNECTORS-314) Combined MySQL and i18n/Japanese contribution

Posted by "Karl Wright (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CONNECTORS-314?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13172213#comment-13172213 ] 

Karl Wright commented on CONNECTORS-314:
----------------------------------------

I just committed code that queries the information schema for the missing MySQL methods, and also makes "ant download-dependencies" bring in the mysql jdbc driver.  Can you try this in your location?  I have not yet removed the checks that disable the index query.

                
> Combined MySQL and i18n/Japanese contribution
> ---------------------------------------------
>
>                 Key: CONNECTORS-314
>                 URL: https://issues.apache.org/jira/browse/CONNECTORS-314
>             Project: ManifoldCF
>          Issue Type: Improvement
>          Components: Framework agents process, Framework core, Framework crawler agent
>    Affects Versions: ManifoldCF 0.5
>            Reporter: Karl Wright
>            Assignee: Karl Wright
>              Labels: I18N, mysql
>             Fix For: ManifoldCF 0.5
>
>         Attachments: CONNECTORS-314.patch, CONNECTORS-314.patch, connectors.patch, framework.patch
>
>
> Hitoshi Ozawa wishes to contribute i18n support, a Japanese localization, and MySQL database support, all in one patch.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (CONNECTORS-314) Combined MySQL and i18n/Japanese contribution

Posted by "Karl Wright (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CONNECTORS-314?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13171983#comment-13171983 ] 

Karl Wright commented on CONNECTORS-314:
----------------------------------------

Hmm, it also looks like many of your changes are basically changes that are already in trunk code.  Would you rather I rebuild the CONNECTORS-314 branch to be based on trunk as of the date 2011/11/29?  I believe that should be straightforward to do, if that helps.

                
> Combined MySQL and i18n/Japanese contribution
> ---------------------------------------------
>
>                 Key: CONNECTORS-314
>                 URL: https://issues.apache.org/jira/browse/CONNECTORS-314
>             Project: ManifoldCF
>          Issue Type: Improvement
>          Components: Framework agents process, Framework core, Framework crawler agent
>    Affects Versions: ManifoldCF 0.5
>            Reporter: Karl Wright
>            Assignee: Karl Wright
>              Labels: I18N, mysql
>             Fix For: ManifoldCF 0.5
>
>         Attachments: connectors.patch, framework.patch
>
>
> Hitoshi Ozawa wishes to contribute i18n support, a Japanese localization, and MySQL database support, all in one patch.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (CONNECTORS-314) Combined MySQL and i18n/Japanese contribution

Posted by "Hitoshi Ozawa (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CONNECTORS-314?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Hitoshi Ozawa updated CONNECTORS-314:
-------------------------------------

    Labels: I18N mysql  (was: )
    Status: Patch Available  (was: Open)

Submitted bundle contains MySQL Connector which is GPL so please take it out when merging with trunk.

I18N and Japanese L10N of most message but not all.

Took out 1 history report because complex sql statement was not supported by mysql. Need to break down the sql statement.
                
> Combined MySQL and i18n/Japanese contribution
> ---------------------------------------------
>
>                 Key: CONNECTORS-314
>                 URL: https://issues.apache.org/jira/browse/CONNECTORS-314
>             Project: ManifoldCF
>          Issue Type: Improvement
>          Components: Framework agents process, Framework core, Framework crawler agent
>    Affects Versions: ManifoldCF 0.5
>            Reporter: Karl Wright
>            Assignee: Karl Wright
>              Labels: mysql, I18N
>             Fix For: ManifoldCF 0.5
>
>
> Hitoshi Ozawa wishes to contribute i18n support, a Japanese localization, and MySQL database support, all in one patch.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Issue Comment Edited] (CONNECTORS-314) Combined MySQL and i18n/Japanese contribution

Posted by "Karl Wright (Issue Comment Edited) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CONNECTORS-314?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13177047#comment-13177047 ] 

Karl Wright edited comment on CONNECTORS-314 at 12/29/11 7:57 AM:
------------------------------------------------------------------

bq. Just want to make sure again. Should I be getting the source code from the trunk now?  Where are fixes for the CONNECTORS-338 and CONNECTORS-340 being committed?

All fixes have now been committed to trunk EXCEPT for the Japanese documentation, which is still going into branches/CONNECTORS-336.  So yes, get your source code from trunk now.

I do not anticipate that I will do further internationalization or localization-related changes unless I run into obvious problems when testing.  So you are free to take your time and work on i18n and l10n changes without fear that I will change something out from underneath you.  (I'm working on automated tests for the UI.  Currently I'm testing just en_US, but I hope to add a set of ja_JP tests as well.  As I go I am running into and fixing various minor UI bugs, but I should not be changing any infrastructure or organization as a result of these fixes.  That ticket is CONNECTORS-339, which is still open.)

                
      was (Author: kwright@metacarta.com):
    bq. Just want to make sure again. Should I be getting the source code from the trunk now?  Where are fixes for the CONNECTORS-338 and CONNECTORS-340 being committed?

All fixes have now been committed to trunk EXCEPT for the Japanese documentation, which is still going into branches/CONNECTORS-336.

I'm also working on automated tests for the UI.  Currently I'm testing just en_US, but I hope to add a set of ja_JP tests as well.  As I go I am running into and fixing various minor UI bugs.  That ticket is CONNECTORS-339, which is still open.

                  
> Combined MySQL and i18n/Japanese contribution
> ---------------------------------------------
>
>                 Key: CONNECTORS-314
>                 URL: https://issues.apache.org/jira/browse/CONNECTORS-314
>             Project: ManifoldCF
>          Issue Type: Improvement
>          Components: Framework agents process, Framework core, Framework crawler agent
>    Affects Versions: ManifoldCF 0.5
>            Reporter: Karl Wright
>            Assignee: Karl Wright
>              Labels: I18N, mysql
>             Fix For: ManifoldCF 0.5
>
>         Attachments: CONNECTORS-314-20111225.patch, CONNECTORS-314-doc20111220.patch, CONNECTORS-314.patch, CONNECTORS-314.patch, connectors.patch, framework.patch
>
>
> Hitoshi Ozawa wishes to contribute i18n support, a Japanese localization, and MySQL database support, all in one patch.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (CONNECTORS-314) Combined MySQL and i18n/Japanese contribution

Posted by "Karl Wright (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CONNECTORS-314?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13172072#comment-13172072 ] 

Karl Wright commented on CONNECTORS-314:
----------------------------------------

One thing I noticed immediately is that you did not implement getTableIndexes for the MySQL driver, and effectively disabled all calls to this method.  This functionality is critical because it allows us to perform seamless upgrades to indexes between ManifoldCF versions.  There's a SQL standard now called the "information schema" which may help in this regard; I don't know if MySQL implements it, but it's worth a look.  The HSQLDB driver makes use of it if you want to poke around and see what MySQL supports.

                
> Combined MySQL and i18n/Japanese contribution
> ---------------------------------------------
>
>                 Key: CONNECTORS-314
>                 URL: https://issues.apache.org/jira/browse/CONNECTORS-314
>             Project: ManifoldCF
>          Issue Type: Improvement
>          Components: Framework agents process, Framework core, Framework crawler agent
>    Affects Versions: ManifoldCF 0.5
>            Reporter: Karl Wright
>            Assignee: Karl Wright
>              Labels: I18N, mysql
>             Fix For: ManifoldCF 0.5
>
>         Attachments: CONNECTORS-314.patch, CONNECTORS-314.patch, connectors.patch, framework.patch
>
>
> Hitoshi Ozawa wishes to contribute i18n support, a Japanese localization, and MySQL database support, all in one patch.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (CONNECTORS-314) Combined MySQL and i18n/Japanese contribution

Posted by "Karl Wright (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CONNECTORS-314?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13172070#comment-13172070 ] 

Karl Wright commented on CONNECTORS-314:
----------------------------------------

I committed your patch to the branch (r1220632).  You might want to check it out in a new workarea to be sure we have everything now.  Also, if there are mysql JDBC jars required, can you provide a URL for them, so I am sure to make sure I get the right ones?

Once I'm sure everything is checked in appropriately, I'll spend some time looking at it and figuring out how to integrate your changes into trunk in a way that keeps support for all other databases intact.  That may take a little while, but luckily I can work on this a bit over the upcoming holidays.

Thanks again!
                
> Combined MySQL and i18n/Japanese contribution
> ---------------------------------------------
>
>                 Key: CONNECTORS-314
>                 URL: https://issues.apache.org/jira/browse/CONNECTORS-314
>             Project: ManifoldCF
>          Issue Type: Improvement
>          Components: Framework agents process, Framework core, Framework crawler agent
>    Affects Versions: ManifoldCF 0.5
>            Reporter: Karl Wright
>            Assignee: Karl Wright
>              Labels: I18N, mysql
>             Fix For: ManifoldCF 0.5
>
>         Attachments: CONNECTORS-314.patch, CONNECTORS-314.patch, connectors.patch, framework.patch
>
>
> Hitoshi Ozawa wishes to contribute i18n support, a Japanese localization, and MySQL database support, all in one patch.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (CONNECTORS-314) Combined MySQL and i18n/Japanese contribution

Posted by "Hitoshi Ozawa (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CONNECTORS-314?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13171974#comment-13171974 ] 

Hitoshi Ozawa commented on CONNECTORS-314:
------------------------------------------

I'm writing up a Japanese documents. Is it possible to upload it the project documentation section or should I just upload it to some site and just ask you to list the translation url?
                
> Combined MySQL and i18n/Japanese contribution
> ---------------------------------------------
>
>                 Key: CONNECTORS-314
>                 URL: https://issues.apache.org/jira/browse/CONNECTORS-314
>             Project: ManifoldCF
>          Issue Type: Improvement
>          Components: Framework agents process, Framework core, Framework crawler agent
>    Affects Versions: ManifoldCF 0.5
>            Reporter: Karl Wright
>            Assignee: Karl Wright
>              Labels: I18N, mysql
>             Fix For: ManifoldCF 0.5
>
>         Attachments: connectors.patch, framework.patch
>
>
> Hitoshi Ozawa wishes to contribute i18n support, a Japanese localization, and MySQL database support, all in one patch.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (CONNECTORS-314) Combined MySQL and i18n/Japanese contribution

Posted by "Koji Sekiguchi (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CONNECTORS-314?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13175156#comment-13175156 ] 

Koji Sekiguchi commented on CONNECTORS-314:
-------------------------------------------

Right. I thought that, too. They should be removed in svn.
                
> Combined MySQL and i18n/Japanese contribution
> ---------------------------------------------
>
>                 Key: CONNECTORS-314
>                 URL: https://issues.apache.org/jira/browse/CONNECTORS-314
>             Project: ManifoldCF
>          Issue Type: Improvement
>          Components: Framework agents process, Framework core, Framework crawler agent
>    Affects Versions: ManifoldCF 0.5
>            Reporter: Karl Wright
>            Assignee: Karl Wright
>              Labels: I18N, mysql
>             Fix For: ManifoldCF 0.5
>
>         Attachments: CONNECTORS-314-doc20111220.patch, CONNECTORS-314.patch, CONNECTORS-314.patch, connectors.patch, framework.patch
>
>
> Hitoshi Ozawa wishes to contribute i18n support, a Japanese localization, and MySQL database support, all in one patch.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (CONNECTORS-314) Combined MySQL and i18n/Japanese contribution

Posted by "Hitoshi Ozawa (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CONNECTORS-314?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13175830#comment-13175830 ] 

Hitoshi Ozawa commented on CONNECTORS-314:
------------------------------------------

Seems like you've already broken the properties messages in the properties file to each connectors. Please ignore my last patch. :-)
                
> Combined MySQL and i18n/Japanese contribution
> ---------------------------------------------
>
>                 Key: CONNECTORS-314
>                 URL: https://issues.apache.org/jira/browse/CONNECTORS-314
>             Project: ManifoldCF
>          Issue Type: Improvement
>          Components: Framework agents process, Framework core, Framework crawler agent
>    Affects Versions: ManifoldCF 0.5
>            Reporter: Karl Wright
>            Assignee: Karl Wright
>              Labels: I18N, mysql
>             Fix For: ManifoldCF 0.5
>
>         Attachments: CONNECTORS-314-20111225.patch, CONNECTORS-314-doc20111220.patch, CONNECTORS-314.patch, CONNECTORS-314.patch, connectors.patch, framework.patch
>
>
> Hitoshi Ozawa wishes to contribute i18n support, a Japanese localization, and MySQL database support, all in one patch.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (CONNECTORS-314) Combined MySQL and i18n/Japanese contribution

Posted by "Hitoshi Ozawa (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CONNECTORS-314?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13171982#comment-13171982 ] 

Hitoshi Ozawa commented on CONNECTORS-314:
------------------------------------------

Will do the svn tonight because I only have Windows here. (sigh)
                
> Combined MySQL and i18n/Japanese contribution
> ---------------------------------------------
>
>                 Key: CONNECTORS-314
>                 URL: https://issues.apache.org/jira/browse/CONNECTORS-314
>             Project: ManifoldCF
>          Issue Type: Improvement
>          Components: Framework agents process, Framework core, Framework crawler agent
>    Affects Versions: ManifoldCF 0.5
>            Reporter: Karl Wright
>            Assignee: Karl Wright
>              Labels: I18N, mysql
>             Fix For: ManifoldCF 0.5
>
>         Attachments: connectors.patch, framework.patch
>
>
> Hitoshi Ozawa wishes to contribute i18n support, a Japanese localization, and MySQL database support, all in one patch.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (CONNECTORS-314) Combined MySQL and i18n/Japanese contribution

Posted by "Karl Wright (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CONNECTORS-314?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13172080#comment-13172080 ] 

Karl Wright commented on CONNECTORS-314:
----------------------------------------

Another quick comment:
The i18n work looks fine except for one problem, which we'll need to solve somehow.  That problem is that each individual connector is essentially compiled and delivered completely separately, and must therefore carry its own i18n and localization with it.  I'll therefore be trying to come up with a way of generalizing your contribution so that this separation can be readily done.  Any ideas you might have are very welcome.

                
> Combined MySQL and i18n/Japanese contribution
> ---------------------------------------------
>
>                 Key: CONNECTORS-314
>                 URL: https://issues.apache.org/jira/browse/CONNECTORS-314
>             Project: ManifoldCF
>          Issue Type: Improvement
>          Components: Framework agents process, Framework core, Framework crawler agent
>    Affects Versions: ManifoldCF 0.5
>            Reporter: Karl Wright
>            Assignee: Karl Wright
>              Labels: I18N, mysql
>             Fix For: ManifoldCF 0.5
>
>         Attachments: CONNECTORS-314.patch, CONNECTORS-314.patch, connectors.patch, framework.patch
>
>
> Hitoshi Ozawa wishes to contribute i18n support, a Japanese localization, and MySQL database support, all in one patch.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (CONNECTORS-314) Combined MySQL and i18n/Japanese contribution

Posted by "Karl Wright (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CONNECTORS-314?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13172193#comment-13172193 ] 

Karl Wright commented on CONNECTORS-314:
----------------------------------------

bq. Is it necessary to include Message.java in each connector or is it possible to just leave it as a common utility class?

A common utility class is fine.  I'd move it to org.apache.manifoldcf.uicore.i18n though, I think, in the project framework/uicore.

bq. There's "information schema" in MySQL. Just didn't have time this time to use it because it'll require more work. I wanted to show that it was possible to use MySQL with ManifoldCF and do the revisions afterwards. Somebody else may want to pitch in now since it's clear that it possible.

As long as that is the case, I can lift the code from the hsqldb driver for the missing DBInterfaceMySQL methods.  I will do that and check everything in when I've also coded the conditional download of the mysql driver in the build process.

                
> Combined MySQL and i18n/Japanese contribution
> ---------------------------------------------
>
>                 Key: CONNECTORS-314
>                 URL: https://issues.apache.org/jira/browse/CONNECTORS-314
>             Project: ManifoldCF
>          Issue Type: Improvement
>          Components: Framework agents process, Framework core, Framework crawler agent
>    Affects Versions: ManifoldCF 0.5
>            Reporter: Karl Wright
>            Assignee: Karl Wright
>              Labels: I18N, mysql
>             Fix For: ManifoldCF 0.5
>
>         Attachments: CONNECTORS-314.patch, CONNECTORS-314.patch, connectors.patch, framework.patch
>
>
> Hitoshi Ozawa wishes to contribute i18n support, a Japanese localization, and MySQL database support, all in one patch.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (CONNECTORS-314) Combined MySQL and i18n/Japanese contribution

Posted by "Karl Wright (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CONNECTORS-314?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13175074#comment-13175074 ] 

Karl Wright commented on CONNECTORS-314:
----------------------------------------

In the CONNECTORS-335 branch, I added local Messages.java classes to each connector, with local default bundles and using the local classloader (because otherwise the proper resource association might not happen).  The local Messages.java classes extend the main Messages.java class in the core package.

                
> Combined MySQL and i18n/Japanese contribution
> ---------------------------------------------
>
>                 Key: CONNECTORS-314
>                 URL: https://issues.apache.org/jira/browse/CONNECTORS-314
>             Project: ManifoldCF
>          Issue Type: Improvement
>          Components: Framework agents process, Framework core, Framework crawler agent
>    Affects Versions: ManifoldCF 0.5
>            Reporter: Karl Wright
>            Assignee: Karl Wright
>              Labels: I18N, mysql
>             Fix For: ManifoldCF 0.5
>
>         Attachments: CONNECTORS-314-doc20111220.patch, CONNECTORS-314.patch, CONNECTORS-314.patch, connectors.patch, framework.patch
>
>
> Hitoshi Ozawa wishes to contribute i18n support, a Japanese localization, and MySQL database support, all in one patch.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Issue Comment Edited] (CONNECTORS-314) Combined MySQL and i18n/Japanese contribution

Posted by "Karl Wright (Issue Comment Edited) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CONNECTORS-314?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13177047#comment-13177047 ] 

Karl Wright edited comment on CONNECTORS-314 at 12/29/11 7:50 AM:
------------------------------------------------------------------

bq. Just want to make sure again. Should I be getting the source code from the trunk now?  Where are fixes for the CONNECTORS-338 and CONNECTORS-340 being committed?

All fixes have now been committed to trunk EXCEPT for the Japanese documentation, which is still going into branches/CONNECTORS-336.

I'm also working on automated tests for the UI.  Currently I'm testing just en_US, but I hope to add a set of ja_JP tests as well.  As I go I am running into and fixing various minor UI bugs.  That ticket is CONNECTORS-339, which is still open.

                
      was (Author: kwright@metacarta.com):
    bq. Just want to make sure again. Should I be getting the source code from the trunk now?  Where are fixes for the CONNECTORS-338 and CONNECTORS-340 being committed?

All fixes have now been committed to trunk EXCEPT for the Japanese documentation, which is still going into branches/CONNECTORS-336.


                  
> Combined MySQL and i18n/Japanese contribution
> ---------------------------------------------
>
>                 Key: CONNECTORS-314
>                 URL: https://issues.apache.org/jira/browse/CONNECTORS-314
>             Project: ManifoldCF
>          Issue Type: Improvement
>          Components: Framework agents process, Framework core, Framework crawler agent
>    Affects Versions: ManifoldCF 0.5
>            Reporter: Karl Wright
>            Assignee: Karl Wright
>              Labels: I18N, mysql
>             Fix For: ManifoldCF 0.5
>
>         Attachments: CONNECTORS-314-20111225.patch, CONNECTORS-314-doc20111220.patch, CONNECTORS-314.patch, CONNECTORS-314.patch, connectors.patch, framework.patch
>
>
> Hitoshi Ozawa wishes to contribute i18n support, a Japanese localization, and MySQL database support, all in one patch.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (CONNECTORS-314) Combined MySQL and i18n/Japanese contribution

Posted by "Karl Wright (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CONNECTORS-314?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13173627#comment-13173627 ] 

Karl Wright commented on CONNECTORS-314:
----------------------------------------

bq. Either way is fine, but if there are going to be other translations, it'll be easier to maintain it in a subdirectory so that a new language will just be a subdirectory addition.

It looks like the subdirectory approach works just fine with this version of forrest, so please just do what you think is right.

                
> Combined MySQL and i18n/Japanese contribution
> ---------------------------------------------
>
>                 Key: CONNECTORS-314
>                 URL: https://issues.apache.org/jira/browse/CONNECTORS-314
>             Project: ManifoldCF
>          Issue Type: Improvement
>          Components: Framework agents process, Framework core, Framework crawler agent
>    Affects Versions: ManifoldCF 0.5
>            Reporter: Karl Wright
>            Assignee: Karl Wright
>              Labels: I18N, mysql
>             Fix For: ManifoldCF 0.5
>
>         Attachments: CONNECTORS-314-doc20111220.patch, CONNECTORS-314.patch, CONNECTORS-314.patch, connectors.patch, framework.patch
>
>
> Hitoshi Ozawa wishes to contribute i18n support, a Japanese localization, and MySQL database support, all in one patch.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (CONNECTORS-314) Combined MySQL and i18n/Japanese contribution

Posted by "Hitoshi Ozawa (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CONNECTORS-314?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13176363#comment-13176363 ] 

Hitoshi Ozawa commented on CONNECTORS-314:
------------------------------------------

bq. What I'm going to try is to convert to <%=Message.getString()%> instead of <fmt... /> for the JSP pages. This will allow everything to be consistent and run out of the same localization files. In addition, it should be possible to create localization escalation paths - e.g. if "ja_JP" is not there we look for "ja" and then "en_US" and then "en". That would minimize the maintenance task going forward.

That will be great!

bq. The MySQL implementation currently is functional, but has not been assessed or tuned for this kind of performance. 

I have a user who may be interested. It's much easier to test when there's an actual case.
                
> Combined MySQL and i18n/Japanese contribution
> ---------------------------------------------
>
>                 Key: CONNECTORS-314
>                 URL: https://issues.apache.org/jira/browse/CONNECTORS-314
>             Project: ManifoldCF
>          Issue Type: Improvement
>          Components: Framework agents process, Framework core, Framework crawler agent
>    Affects Versions: ManifoldCF 0.5
>            Reporter: Karl Wright
>            Assignee: Karl Wright
>              Labels: I18N, mysql
>             Fix For: ManifoldCF 0.5
>
>         Attachments: CONNECTORS-314-20111225.patch, CONNECTORS-314-doc20111220.patch, CONNECTORS-314.patch, CONNECTORS-314.patch, connectors.patch, framework.patch
>
>
> Hitoshi Ozawa wishes to contribute i18n support, a Japanese localization, and MySQL database support, all in one patch.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Issue Comment Edited] (CONNECTORS-314) Combined MySQL and i18n/Japanese contribution

Posted by "Hitoshi Ozawa (Issue Comment Edited) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CONNECTORS-314?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13172016#comment-13172016 ] 

Hitoshi Ozawa edited comment on CONNECTORS-314 at 12/19/11 3:39 AM:
--------------------------------------------------------------------

SQL statements in JobManager.java was modified to run only for MySQL.

I've also changed the default properties.xml to use mysql. Needs mysql user and password to run properly.
                
      was (Author: hozawa):
    SQL statements in JobManager.java was modified to run only for MySQL.

                  
> Combined MySQL and i18n/Japanese contribution
> ---------------------------------------------
>
>                 Key: CONNECTORS-314
>                 URL: https://issues.apache.org/jira/browse/CONNECTORS-314
>             Project: ManifoldCF
>          Issue Type: Improvement
>          Components: Framework agents process, Framework core, Framework crawler agent
>    Affects Versions: ManifoldCF 0.5
>            Reporter: Karl Wright
>            Assignee: Karl Wright
>              Labels: I18N, mysql
>             Fix For: ManifoldCF 0.5
>
>         Attachments: CONNECTORS-314.patch, connectors.patch, framework.patch
>
>
> Hitoshi Ozawa wishes to contribute i18n support, a Japanese localization, and MySQL database support, all in one patch.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (CONNECTORS-314) Combined MySQL and i18n/Japanese contribution

Posted by "Karl Wright (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CONNECTORS-314?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13176030#comment-13176030 ] 

Karl Wright commented on CONNECTORS-314:
----------------------------------------

Hi Hitoshi,

I apologize - I was away for the last couple of days, and could not respond immediately to your questions.

I'd like to work with you to finish the i18n and Japanese l10n work as soon as possible.  The outstanding issues, as far as I see it, are the following:

- The i18n work is not complete for all connectors.  This, I think, can be addressed over time; there's no need for it to be all complete right way.  But we should definitely work to complete it.  I think the best approach would be to first commit the infrastructure changes (as contained in branches/CONNECTORS-335), and then work on individual tickets for completion of individual connectors and authorities.
- There's some question in my mind as to whether it is best to just use language or use the full locale for localization.  For example, "ja_JP" and "en_US" vs. "ja" and "en".  It would be good to hear your opinion as to which would be the most appropriate for ManifoldCF.  Right now I'm using the full locale, but we should switch over to just language if you think that that is appropriate.

Comments?

                
> Combined MySQL and i18n/Japanese contribution
> ---------------------------------------------
>
>                 Key: CONNECTORS-314
>                 URL: https://issues.apache.org/jira/browse/CONNECTORS-314
>             Project: ManifoldCF
>          Issue Type: Improvement
>          Components: Framework agents process, Framework core, Framework crawler agent
>    Affects Versions: ManifoldCF 0.5
>            Reporter: Karl Wright
>            Assignee: Karl Wright
>              Labels: I18N, mysql
>             Fix For: ManifoldCF 0.5
>
>         Attachments: CONNECTORS-314-20111225.patch, CONNECTORS-314-doc20111220.patch, CONNECTORS-314.patch, CONNECTORS-314.patch, connectors.patch, framework.patch
>
>
> Hitoshi Ozawa wishes to contribute i18n support, a Japanese localization, and MySQL database support, all in one patch.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (CONNECTORS-314) Combined MySQL and i18n/Japanese contribution

Posted by "Hitoshi Ozawa (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CONNECTORS-314?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Hitoshi Ozawa updated CONNECTORS-314:
-------------------------------------

    Attachment: CONNECTORS-314.patch

forgot svn add in the previous patch. Sorry.
                
> Combined MySQL and i18n/Japanese contribution
> ---------------------------------------------
>
>                 Key: CONNECTORS-314
>                 URL: https://issues.apache.org/jira/browse/CONNECTORS-314
>             Project: ManifoldCF
>          Issue Type: Improvement
>          Components: Framework agents process, Framework core, Framework crawler agent
>    Affects Versions: ManifoldCF 0.5
>            Reporter: Karl Wright
>            Assignee: Karl Wright
>              Labels: I18N, mysql
>             Fix For: ManifoldCF 0.5
>
>         Attachments: CONNECTORS-314.patch, CONNECTORS-314.patch, connectors.patch, framework.patch
>
>
> Hitoshi Ozawa wishes to contribute i18n support, a Japanese localization, and MySQL database support, all in one patch.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (CONNECTORS-314) Combined MySQL and i18n/Japanese contribution

Posted by "Karl Wright (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CONNECTORS-314?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13174933#comment-13174933 ] 

Karl Wright commented on CONNECTORS-314:
----------------------------------------

I created a CONNECTORS-335 branch for this purpose, and pulled up all the internationalization/localization-related changes.  (I'll create yet another branch and ticket for Japanese documentation).

Hitoshi - for now, if you want to submit internationalization/localization patches against branches/CONNECTORS-314, I should be able to apply them in branches/CONNECTORS-335 as well.  But the next time you are in a position to "start fresh", I suggest checking out CONNECTORS-335 and working directly against it.

                
> Combined MySQL and i18n/Japanese contribution
> ---------------------------------------------
>
>                 Key: CONNECTORS-314
>                 URL: https://issues.apache.org/jira/browse/CONNECTORS-314
>             Project: ManifoldCF
>          Issue Type: Improvement
>          Components: Framework agents process, Framework core, Framework crawler agent
>    Affects Versions: ManifoldCF 0.5
>            Reporter: Karl Wright
>            Assignee: Karl Wright
>              Labels: I18N, mysql
>             Fix For: ManifoldCF 0.5
>
>         Attachments: CONNECTORS-314-doc20111220.patch, CONNECTORS-314.patch, CONNECTORS-314.patch, connectors.patch, framework.patch
>
>
> Hitoshi Ozawa wishes to contribute i18n support, a Japanese localization, and MySQL database support, all in one patch.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (CONNECTORS-314) Combined MySQL and i18n/Japanese contribution

Posted by "Koji Sekiguchi (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CONNECTORS-314?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13175293#comment-13175293 ] 

Koji Sekiguchi commented on CONNECTORS-314:
-------------------------------------------

I've not looked into build.xml, but if .properties.utf8 is source file of .properties (and I expect so), .properties files shouldn't be registered in svn.
                
> Combined MySQL and i18n/Japanese contribution
> ---------------------------------------------
>
>                 Key: CONNECTORS-314
>                 URL: https://issues.apache.org/jira/browse/CONNECTORS-314
>             Project: ManifoldCF
>          Issue Type: Improvement
>          Components: Framework agents process, Framework core, Framework crawler agent
>    Affects Versions: ManifoldCF 0.5
>            Reporter: Karl Wright
>            Assignee: Karl Wright
>              Labels: I18N, mysql
>             Fix For: ManifoldCF 0.5
>
>         Attachments: CONNECTORS-314-doc20111220.patch, CONNECTORS-314.patch, CONNECTORS-314.patch, connectors.patch, framework.patch
>
>
> Hitoshi Ozawa wishes to contribute i18n support, a Japanese localization, and MySQL database support, all in one patch.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (CONNECTORS-314) Combined MySQL and i18n/Japanese contribution

Posted by "Karl Wright (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CONNECTORS-314?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13172121#comment-13172121 ] 

Karl Wright commented on CONNECTORS-314:
----------------------------------------

It looks like the following link describes what I need to know for the fmt:message tag, in order to customize the fmt:message tag for different sections of the code:

http://codesnippets.joyent.com/posts/show/1151

I'm therefore going to want to add a <fmt:setBundle basename="class.path.to.your.resources.bundle"/> tag to the UI common header, rather than have the bundle be set as a context-param in the webapp.

                
> Combined MySQL and i18n/Japanese contribution
> ---------------------------------------------
>
>                 Key: CONNECTORS-314
>                 URL: https://issues.apache.org/jira/browse/CONNECTORS-314
>             Project: ManifoldCF
>          Issue Type: Improvement
>          Components: Framework agents process, Framework core, Framework crawler agent
>    Affects Versions: ManifoldCF 0.5
>            Reporter: Karl Wright
>            Assignee: Karl Wright
>              Labels: I18N, mysql
>             Fix For: ManifoldCF 0.5
>
>         Attachments: CONNECTORS-314.patch, CONNECTORS-314.patch, connectors.patch, framework.patch
>
>
> Hitoshi Ozawa wishes to contribute i18n support, a Japanese localization, and MySQL database support, all in one patch.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (CONNECTORS-314) Combined MySQL and i18n/Japanese contribution

Posted by "Karl Wright (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CONNECTORS-314?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13172271#comment-13172271 ] 

Karl Wright commented on CONNECTORS-314:
----------------------------------------

Committed what I think are most of the missing methods from the DBInterfaceMySQL class, and restored index inspection in all the places it happens.  I haven't tried it (mostly because I don't have a readily available MySQL instance), but either you can try it or you can wait for me to install MySQL somewhere.  Also:

bq. I've also changed the default properties.xml to use mysql. Needs mysql user and password to run properly.

I'm afraid I'm going to need to revert this change, since it basically means you have to have MySQL running in order to use ManifoldCF under Maven.  Hope that's okay with you.

                
> Combined MySQL and i18n/Japanese contribution
> ---------------------------------------------
>
>                 Key: CONNECTORS-314
>                 URL: https://issues.apache.org/jira/browse/CONNECTORS-314
>             Project: ManifoldCF
>          Issue Type: Improvement
>          Components: Framework agents process, Framework core, Framework crawler agent
>    Affects Versions: ManifoldCF 0.5
>            Reporter: Karl Wright
>            Assignee: Karl Wright
>              Labels: I18N, mysql
>             Fix For: ManifoldCF 0.5
>
>         Attachments: CONNECTORS-314.patch, CONNECTORS-314.patch, connectors.patch, framework.patch
>
>
> Hitoshi Ozawa wishes to contribute i18n support, a Japanese localization, and MySQL database support, all in one patch.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (CONNECTORS-314) Combined MySQL and i18n/Japanese contribution

Posted by "Hitoshi Ozawa (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CONNECTORS-314?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13176373#comment-13176373 ] 

Hitoshi Ozawa commented on CONNECTORS-314:
------------------------------------------

BTW, I'm thinking of finishing all of I18N/L10N by March for the 0.5 release. :-) 
                
> Combined MySQL and i18n/Japanese contribution
> ---------------------------------------------
>
>                 Key: CONNECTORS-314
>                 URL: https://issues.apache.org/jira/browse/CONNECTORS-314
>             Project: ManifoldCF
>          Issue Type: Improvement
>          Components: Framework agents process, Framework core, Framework crawler agent
>    Affects Versions: ManifoldCF 0.5
>            Reporter: Karl Wright
>            Assignee: Karl Wright
>              Labels: I18N, mysql
>             Fix For: ManifoldCF 0.5
>
>         Attachments: CONNECTORS-314-20111225.patch, CONNECTORS-314-doc20111220.patch, CONNECTORS-314.patch, CONNECTORS-314.patch, connectors.patch, framework.patch
>
>
> Hitoshi Ozawa wishes to contribute i18n support, a Japanese localization, and MySQL database support, all in one patch.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (CONNECTORS-314) Combined MySQL and i18n/Japanese contribution

Posted by "Karl Wright (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CONNECTORS-314?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13177047#comment-13177047 ] 

Karl Wright commented on CONNECTORS-314:
----------------------------------------

bq. Just want to make sure again. Should I be getting the source code from the trunk now?  Where are fixes for the CONNECTORS-338 and CONNECTORS-340 being committed?

All fixes have now been committed to trunk EXCEPT for the Japanese documentation, which is still going into branches/CONNECTORS-336.


                
> Combined MySQL and i18n/Japanese contribution
> ---------------------------------------------
>
>                 Key: CONNECTORS-314
>                 URL: https://issues.apache.org/jira/browse/CONNECTORS-314
>             Project: ManifoldCF
>          Issue Type: Improvement
>          Components: Framework agents process, Framework core, Framework crawler agent
>    Affects Versions: ManifoldCF 0.5
>            Reporter: Karl Wright
>            Assignee: Karl Wright
>              Labels: I18N, mysql
>             Fix For: ManifoldCF 0.5
>
>         Attachments: CONNECTORS-314-20111225.patch, CONNECTORS-314-doc20111220.patch, CONNECTORS-314.patch, CONNECTORS-314.patch, connectors.patch, framework.patch
>
>
> Hitoshi Ozawa wishes to contribute i18n support, a Japanese localization, and MySQL database support, all in one patch.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (CONNECTORS-314) Combined MySQL and i18n/Japanese contribution

Posted by "Hitoshi Ozawa (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CONNECTORS-314?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13175865#comment-13175865 ] 

Hitoshi Ozawa commented on CONNECTORS-314:
------------------------------------------

The branches that are going to be merged into the trunk is now 334, 335, and 336?
                
> Combined MySQL and i18n/Japanese contribution
> ---------------------------------------------
>
>                 Key: CONNECTORS-314
>                 URL: https://issues.apache.org/jira/browse/CONNECTORS-314
>             Project: ManifoldCF
>          Issue Type: Improvement
>          Components: Framework agents process, Framework core, Framework crawler agent
>    Affects Versions: ManifoldCF 0.5
>            Reporter: Karl Wright
>            Assignee: Karl Wright
>              Labels: I18N, mysql
>             Fix For: ManifoldCF 0.5
>
>         Attachments: CONNECTORS-314-20111225.patch, CONNECTORS-314-doc20111220.patch, CONNECTORS-314.patch, CONNECTORS-314.patch, connectors.patch, framework.patch
>
>
> Hitoshi Ozawa wishes to contribute i18n support, a Japanese localization, and MySQL database support, all in one patch.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (CONNECTORS-314) Combined MySQL and i18n/Japanese contribution

Posted by "Karl Wright (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CONNECTORS-314?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13172834#comment-13172834 ] 

Karl Wright commented on CONNECTORS-314:
----------------------------------------

Actually, forrest seemed to pick up the subdirectory just fine.  What it didn't pick up though was the new tab. I'll have to try and figure out why not.

                
> Combined MySQL and i18n/Japanese contribution
> ---------------------------------------------
>
>                 Key: CONNECTORS-314
>                 URL: https://issues.apache.org/jira/browse/CONNECTORS-314
>             Project: ManifoldCF
>          Issue Type: Improvement
>          Components: Framework agents process, Framework core, Framework crawler agent
>    Affects Versions: ManifoldCF 0.5
>            Reporter: Karl Wright
>            Assignee: Karl Wright
>              Labels: I18N, mysql
>             Fix For: ManifoldCF 0.5
>
>         Attachments: CONNECTORS-314-doc20111220.patch, CONNECTORS-314.patch, CONNECTORS-314.patch, connectors.patch, framework.patch
>
>
> Hitoshi Ozawa wishes to contribute i18n support, a Japanese localization, and MySQL database support, all in one patch.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Issue Comment Edited] (CONNECTORS-314) Combined MySQL and i18n/Japanese contribution

Posted by "Hitoshi Ozawa (Issue Comment Edited) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CONNECTORS-314?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13171982#comment-13171982 ] 

Hitoshi Ozawa edited comment on CONNECTORS-314 at 12/19/11 12:56 AM:
---------------------------------------------------------------------

Will do the svn tonight because I only have Windows here. (sigh)

Used GnuWin32 diff command
diff -rupN original modified > original.patch
                
      was (Author: hozawa):
    Will do the svn tonight because I only have Windows here. (sigh)
                  
> Combined MySQL and i18n/Japanese contribution
> ---------------------------------------------
>
>                 Key: CONNECTORS-314
>                 URL: https://issues.apache.org/jira/browse/CONNECTORS-314
>             Project: ManifoldCF
>          Issue Type: Improvement
>          Components: Framework agents process, Framework core, Framework crawler agent
>    Affects Versions: ManifoldCF 0.5
>            Reporter: Karl Wright
>            Assignee: Karl Wright
>              Labels: I18N, mysql
>             Fix For: ManifoldCF 0.5
>
>         Attachments: connectors.patch, framework.patch
>
>
> Hitoshi Ozawa wishes to contribute i18n support, a Japanese localization, and MySQL database support, all in one patch.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (CONNECTORS-314) Combined MySQL and i18n/Japanese contribution

Posted by "Karl Wright (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CONNECTORS-314?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13176161#comment-13176161 ] 

Karl Wright commented on CONNECTORS-314:
----------------------------------------

bq. We can switch the properties file name to full language_country. I
should have standardized it instead of using just language for some
and full for others.

What I'm going to try is to convert to <%=Message.getString()%> instead of <fmt... /> for the JSP pages.  This will allow everything to be consistent and run out of the same localization files.  In addition, it should be possible to create localization escalation paths - e.g. if "ja_JP" is not there we look for "ja" and then "en_US" and then "en".  That would minimize the maintenance task going forward.

                
> Combined MySQL and i18n/Japanese contribution
> ---------------------------------------------
>
>                 Key: CONNECTORS-314
>                 URL: https://issues.apache.org/jira/browse/CONNECTORS-314
>             Project: ManifoldCF
>          Issue Type: Improvement
>          Components: Framework agents process, Framework core, Framework crawler agent
>    Affects Versions: ManifoldCF 0.5
>            Reporter: Karl Wright
>            Assignee: Karl Wright
>              Labels: I18N, mysql
>             Fix For: ManifoldCF 0.5
>
>         Attachments: CONNECTORS-314-20111225.patch, CONNECTORS-314-doc20111220.patch, CONNECTORS-314.patch, CONNECTORS-314.patch, connectors.patch, framework.patch
>
>
> Hitoshi Ozawa wishes to contribute i18n support, a Japanese localization, and MySQL database support, all in one patch.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (CONNECTORS-314) Combined MySQL and i18n/Japanese contribution

Posted by "Karl Wright (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CONNECTORS-314?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13172831#comment-13172831 ] 

Karl Wright commented on CONNECTORS-314:
----------------------------------------

bq. As for the forrest documentation structure, how about the creating a Japanese tab and just creating a japanese subdirectory under xdocs? I've attached a tabs.xml and site.xml patch.

I'll commit the patch shortly.  If you can get forrest to work with a subdirectory, great - in general, though, we've found it better to keep all the xml files in one directory.  So that's what I'd recommend, and just give their names all an _ja suffix or something.

                
> Combined MySQL and i18n/Japanese contribution
> ---------------------------------------------
>
>                 Key: CONNECTORS-314
>                 URL: https://issues.apache.org/jira/browse/CONNECTORS-314
>             Project: ManifoldCF
>          Issue Type: Improvement
>          Components: Framework agents process, Framework core, Framework crawler agent
>    Affects Versions: ManifoldCF 0.5
>            Reporter: Karl Wright
>            Assignee: Karl Wright
>              Labels: I18N, mysql
>             Fix For: ManifoldCF 0.5
>
>         Attachments: CONNECTORS-314-doc20111220.patch, CONNECTORS-314.patch, CONNECTORS-314.patch, connectors.patch, framework.patch
>
>
> Hitoshi Ozawa wishes to contribute i18n support, a Japanese localization, and MySQL database support, all in one patch.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (CONNECTORS-314) Combined MySQL and i18n/Japanese contribution

Posted by "Hitoshi Ozawa (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CONNECTORS-314?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Hitoshi Ozawa updated CONNECTORS-314:
-------------------------------------

    Attachment: CONNECTORS-314-20111225.patch

Moved en and ja language properties files to each connector.
                
> Combined MySQL and i18n/Japanese contribution
> ---------------------------------------------
>
>                 Key: CONNECTORS-314
>                 URL: https://issues.apache.org/jira/browse/CONNECTORS-314
>             Project: ManifoldCF
>          Issue Type: Improvement
>          Components: Framework agents process, Framework core, Framework crawler agent
>    Affects Versions: ManifoldCF 0.5
>            Reporter: Karl Wright
>            Assignee: Karl Wright
>              Labels: I18N, mysql
>             Fix For: ManifoldCF 0.5
>
>         Attachments: CONNECTORS-314-20111225.patch, CONNECTORS-314-doc20111220.patch, CONNECTORS-314.patch, CONNECTORS-314.patch, connectors.patch, framework.patch
>
>
> Hitoshi Ozawa wishes to contribute i18n support, a Japanese localization, and MySQL database support, all in one patch.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Issue Comment Edited] (CONNECTORS-314) Combined MySQL and i18n/Japanese contribution

Posted by "Karl Wright (Issue Comment Edited) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CONNECTORS-314?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13172193#comment-13172193 ] 

Karl Wright edited comment on CONNECTORS-314 at 12/19/11 11:14 AM:
-------------------------------------------------------------------

bq. Is it necessary to include Message.java in each connector or is it possible to just leave it as a common utility class?

A common utility class is fine.

bq. There's "information schema" in MySQL. Just didn't have time this time to use it because it'll require more work. I wanted to show that it was possible to use MySQL with ManifoldCF and do the revisions afterwards. Somebody else may want to pitch in now since it's clear that it possible.

As long as that is the case, I can lift the code from the hsqldb driver for the missing DBInterfaceMySQL methods.  I will do that and check everything in when I've also coded the conditional download of the mysql driver in the build process.

                
      was (Author: kwright@metacarta.com):
    bq. Is it necessary to include Message.java in each connector or is it possible to just leave it as a common utility class?

A common utility class is fine.  I'd move it to org.apache.manifoldcf.uicore.i18n though, I think, in the project framework/uicore.

bq. There's "information schema" in MySQL. Just didn't have time this time to use it because it'll require more work. I wanted to show that it was possible to use MySQL with ManifoldCF and do the revisions afterwards. Somebody else may want to pitch in now since it's clear that it possible.

As long as that is the case, I can lift the code from the hsqldb driver for the missing DBInterfaceMySQL methods.  I will do that and check everything in when I've also coded the conditional download of the mysql driver in the build process.

                  
> Combined MySQL and i18n/Japanese contribution
> ---------------------------------------------
>
>                 Key: CONNECTORS-314
>                 URL: https://issues.apache.org/jira/browse/CONNECTORS-314
>             Project: ManifoldCF
>          Issue Type: Improvement
>          Components: Framework agents process, Framework core, Framework crawler agent
>    Affects Versions: ManifoldCF 0.5
>            Reporter: Karl Wright
>            Assignee: Karl Wright
>              Labels: I18N, mysql
>             Fix For: ManifoldCF 0.5
>
>         Attachments: CONNECTORS-314.patch, CONNECTORS-314.patch, connectors.patch, framework.patch
>
>
> Hitoshi Ozawa wishes to contribute i18n support, a Japanese localization, and MySQL database support, all in one patch.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (CONNECTORS-314) Combined MySQL and i18n/Japanese contribution

Posted by "Karl Wright (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CONNECTORS-314?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13176208#comment-13176208 ] 

Karl Wright commented on CONNECTORS-314:
----------------------------------------

bq. I want to get it to a situation where I can introduce this to Japanese users quickly as possible. I think most are going to use just Solr, AD, File, DB, and Web with MySQL.

That's fine, although MySQL is not yet been "certified" to scale with ManifoldCF, unlike PostgreSQL.

bq. There's also some issues that I've been notified - mainly concerning performance when there are over 1 million files to crawl. I'll createissues concerning these after finishing up the above topics.

This is exactly what I mean.  Any fully-supported database implementation must be capable of performing certain queries reliably and quickly.  The MySQL implementation currently is functional, but has not been assessed or tuned for this kind of performance.  Typically this requires quite a lot of time - the HSQLDB implementation just achieved this goal despite being available for most of the last year.  It may even not be possible to achieve.  The HSQLDB implementation required HSQLDB improvements to make it possible.  Hopefully that will not be needed for MySQL but there are no guarantees.  But we won't even know that until much more time has been invested.

                
> Combined MySQL and i18n/Japanese contribution
> ---------------------------------------------
>
>                 Key: CONNECTORS-314
>                 URL: https://issues.apache.org/jira/browse/CONNECTORS-314
>             Project: ManifoldCF
>          Issue Type: Improvement
>          Components: Framework agents process, Framework core, Framework crawler agent
>    Affects Versions: ManifoldCF 0.5
>            Reporter: Karl Wright
>            Assignee: Karl Wright
>              Labels: I18N, mysql
>             Fix For: ManifoldCF 0.5
>
>         Attachments: CONNECTORS-314-20111225.patch, CONNECTORS-314-doc20111220.patch, CONNECTORS-314.patch, CONNECTORS-314.patch, connectors.patch, framework.patch
>
>
> Hitoshi Ozawa wishes to contribute i18n support, a Japanese localization, and MySQL database support, all in one patch.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (CONNECTORS-314) Combined MySQL and i18n/Japanese contribution

Posted by "Hitoshi Ozawa (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CONNECTORS-314?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13171981#comment-13171981 ] 

Hitoshi Ozawa commented on CONNECTORS-314:
------------------------------------------

I was just writing in html based on the html document available at the project site.
Where can I obtain the xml file? I'm still at early stage and it won't be too much of a problem.
I'm going to use the Japanese screenshots and modify the codes a little bit again during the process because some pages didn't look too pretty with Japanese messages.
                
> Combined MySQL and i18n/Japanese contribution
> ---------------------------------------------
>
>                 Key: CONNECTORS-314
>                 URL: https://issues.apache.org/jira/browse/CONNECTORS-314
>             Project: ManifoldCF
>          Issue Type: Improvement
>          Components: Framework agents process, Framework core, Framework crawler agent
>    Affects Versions: ManifoldCF 0.5
>            Reporter: Karl Wright
>            Assignee: Karl Wright
>              Labels: I18N, mysql
>             Fix For: ManifoldCF 0.5
>
>         Attachments: connectors.patch, framework.patch
>
>
> Hitoshi Ozawa wishes to contribute i18n support, a Japanese localization, and MySQL database support, all in one patch.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (CONNECTORS-314) Combined MySQL and i18n/Japanese contribution

Posted by "Karl Wright (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CONNECTORS-314?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13175232#comment-13175232 ] 

Karl Wright commented on CONNECTORS-314:
----------------------------------------

Hi Koji - the only thing I'm wondering is if maybe the .utf8 files are in fact the source files for the _ja.properties files, in which case we should probably keep the .utf8 files and generate the properties files dynamically.  It's hard for me to tell what the intent was here.
                
> Combined MySQL and i18n/Japanese contribution
> ---------------------------------------------
>
>                 Key: CONNECTORS-314
>                 URL: https://issues.apache.org/jira/browse/CONNECTORS-314
>             Project: ManifoldCF
>          Issue Type: Improvement
>          Components: Framework agents process, Framework core, Framework crawler agent
>    Affects Versions: ManifoldCF 0.5
>            Reporter: Karl Wright
>            Assignee: Karl Wright
>              Labels: I18N, mysql
>             Fix For: ManifoldCF 0.5
>
>         Attachments: CONNECTORS-314-doc20111220.patch, CONNECTORS-314.patch, CONNECTORS-314.patch, connectors.patch, framework.patch
>
>
> Hitoshi Ozawa wishes to contribute i18n support, a Japanese localization, and MySQL database support, all in one patch.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (CONNECTORS-314) Combined MySQL and i18n/Japanese contribution

Posted by "Karl Wright (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CONNECTORS-314?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13171985#comment-13171985 ] 

Karl Wright commented on CONNECTORS-314:
----------------------------------------

bq. Will do the svn tonight because I only have Windows here. (sigh)

There is a Windows svn client; that's what I use a lot of the time too.  You can download from here: http://www.sliksvn.com/en/download

                
> Combined MySQL and i18n/Japanese contribution
> ---------------------------------------------
>
>                 Key: CONNECTORS-314
>                 URL: https://issues.apache.org/jira/browse/CONNECTORS-314
>             Project: ManifoldCF
>          Issue Type: Improvement
>          Components: Framework agents process, Framework core, Framework crawler agent
>    Affects Versions: ManifoldCF 0.5
>            Reporter: Karl Wright
>            Assignee: Karl Wright
>              Labels: I18N, mysql
>             Fix For: ManifoldCF 0.5
>
>         Attachments: connectors.patch, framework.patch
>
>
> Hitoshi Ozawa wishes to contribute i18n support, a Japanese localization, and MySQL database support, all in one patch.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (CONNECTORS-314) Combined MySQL and i18n/Japanese contribution

Posted by "Hitoshi Ozawa (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CONNECTORS-314?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13171988#comment-13171988 ] 

Hitoshi Ozawa commented on CONNECTORS-314:
------------------------------------------

Please upgrade the svn. Sorry for the trouble.

Will look into it tonight. Can't use svn here.
                
> Combined MySQL and i18n/Japanese contribution
> ---------------------------------------------
>
>                 Key: CONNECTORS-314
>                 URL: https://issues.apache.org/jira/browse/CONNECTORS-314
>             Project: ManifoldCF
>          Issue Type: Improvement
>          Components: Framework agents process, Framework core, Framework crawler agent
>    Affects Versions: ManifoldCF 0.5
>            Reporter: Karl Wright
>            Assignee: Karl Wright
>              Labels: I18N, mysql
>             Fix For: ManifoldCF 0.5
>
>         Attachments: connectors.patch, framework.patch
>
>
> Hitoshi Ozawa wishes to contribute i18n support, a Japanese localization, and MySQL database support, all in one patch.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (CONNECTORS-314) Combined MySQL and i18n/Japanese contribution

Posted by "Karl Wright (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CONNECTORS-314?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Karl Wright updated CONNECTORS-314:
-----------------------------------

    Resolution: Fixed
        Status: Resolved  (was: Patch Available)

The work in this ticket has been completely replaced by tickets CONNECTORS-334, CONNECTORS-335, and CONNECTORS-336.

                
> Combined MySQL and i18n/Japanese contribution
> ---------------------------------------------
>
>                 Key: CONNECTORS-314
>                 URL: https://issues.apache.org/jira/browse/CONNECTORS-314
>             Project: ManifoldCF
>          Issue Type: Improvement
>          Components: Framework agents process, Framework core, Framework crawler agent
>    Affects Versions: ManifoldCF 0.5
>            Reporter: Karl Wright
>            Assignee: Karl Wright
>              Labels: I18N, mysql
>             Fix For: ManifoldCF 0.5
>
>         Attachments: CONNECTORS-314-20111225.patch, CONNECTORS-314-doc20111220.patch, CONNECTORS-314.patch, CONNECTORS-314.patch, connectors.patch, framework.patch
>
>
> Hitoshi Ozawa wishes to contribute i18n support, a Japanese localization, and MySQL database support, all in one patch.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (CONNECTORS-314) Combined MySQL and i18n/Japanese contribution

Posted by "Hitoshi Ozawa (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CONNECTORS-314?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13175829#comment-13175829 ] 

Hitoshi Ozawa commented on CONNECTORS-314:
------------------------------------------

Seems you've been working on Messages.java. Please ignore the Messages.java in each connector in the patch I've just submitted and just keep the en.properties
and ja.properties.utf8.
The utf8 properties are source to the native2ascii. I've modified build.xml in each connector to do the conversion and to copy the properties files.
As you've found out, please remove the ja.properties file if unnecessary.
                
> Combined MySQL and i18n/Japanese contribution
> ---------------------------------------------
>
>                 Key: CONNECTORS-314
>                 URL: https://issues.apache.org/jira/browse/CONNECTORS-314
>             Project: ManifoldCF
>          Issue Type: Improvement
>          Components: Framework agents process, Framework core, Framework crawler agent
>    Affects Versions: ManifoldCF 0.5
>            Reporter: Karl Wright
>            Assignee: Karl Wright
>              Labels: I18N, mysql
>             Fix For: ManifoldCF 0.5
>
>         Attachments: CONNECTORS-314-20111225.patch, CONNECTORS-314-doc20111220.patch, CONNECTORS-314.patch, CONNECTORS-314.patch, connectors.patch, framework.patch
>
>
> Hitoshi Ozawa wishes to contribute i18n support, a Japanese localization, and MySQL database support, all in one patch.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (CONNECTORS-314) Combined MySQL and i18n/Japanese contribution

Posted by "Karl Wright (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CONNECTORS-314?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13172342#comment-13172342 ] 

Karl Wright commented on CONNECTORS-314:
----------------------------------------

Added abstraction for the COUNT() construct, so that all the tests now pass in the CONNECTORS-314 branch.

                
> Combined MySQL and i18n/Japanese contribution
> ---------------------------------------------
>
>                 Key: CONNECTORS-314
>                 URL: https://issues.apache.org/jira/browse/CONNECTORS-314
>             Project: ManifoldCF
>          Issue Type: Improvement
>          Components: Framework agents process, Framework core, Framework crawler agent
>    Affects Versions: ManifoldCF 0.5
>            Reporter: Karl Wright
>            Assignee: Karl Wright
>              Labels: I18N, mysql
>             Fix For: ManifoldCF 0.5
>
>         Attachments: CONNECTORS-314.patch, CONNECTORS-314.patch, connectors.patch, framework.patch
>
>
> Hitoshi Ozawa wishes to contribute i18n support, a Japanese localization, and MySQL database support, all in one patch.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (CONNECTORS-314) Combined MySQL and i18n/Japanese contribution

Posted by "Karl Wright (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CONNECTORS-314?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13174843#comment-13174843 ] 

Karl Wright commented on CONNECTORS-314:
----------------------------------------

I've pulled up the database changes, and completed them, as covered in ticket CONNECTORS-334.  We should therefore NOT attempt to merge anything other i18n changes from the branches/CONNECTORS-314 branch.

In order to make the final merge tolerable, I'm considering transferring all of the current i18n changes to a new branch based on trunk.  It will be much easier in the end to merge if this is taken care of now.

                
> Combined MySQL and i18n/Japanese contribution
> ---------------------------------------------
>
>                 Key: CONNECTORS-314
>                 URL: https://issues.apache.org/jira/browse/CONNECTORS-314
>             Project: ManifoldCF
>          Issue Type: Improvement
>          Components: Framework agents process, Framework core, Framework crawler agent
>    Affects Versions: ManifoldCF 0.5
>            Reporter: Karl Wright
>            Assignee: Karl Wright
>              Labels: I18N, mysql
>             Fix For: ManifoldCF 0.5
>
>         Attachments: CONNECTORS-314-doc20111220.patch, CONNECTORS-314.patch, CONNECTORS-314.patch, connectors.patch, framework.patch
>
>
> Hitoshi Ozawa wishes to contribute i18n support, a Japanese localization, and MySQL database support, all in one patch.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (CONNECTORS-314) Combined MySQL and i18n/Japanese contribution

Posted by "Karl Wright (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CONNECTORS-314?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13171990#comment-13171990 ] 

Karl Wright commented on CONNECTORS-314:
----------------------------------------

bq. Used GnuWin32 diff command
bq. diff -rupN original modified > original.patch

In general, when working with svn, it is better to have a single patch file produced with a single svn diff command, against a working directory that contains a checked-out version of the tree (from an appropriate branch or time), plus your changes.  svn diff annotates the diff with revision numbers which makes it possible to apply the patch in a sensible way.  So the usual procedure is:

- check out the project
- modify the checked out code through whatever means
- do a "svn diff >XXX.patch" command to capture the changes

Bear in mind that for added files you will need to do "svn add <filename>" in order for "svn diff" to pick it up later.  But other than that it's a very straightforward process.

Hope this helps.

                
> Combined MySQL and i18n/Japanese contribution
> ---------------------------------------------
>
>                 Key: CONNECTORS-314
>                 URL: https://issues.apache.org/jira/browse/CONNECTORS-314
>             Project: ManifoldCF
>          Issue Type: Improvement
>          Components: Framework agents process, Framework core, Framework crawler agent
>    Affects Versions: ManifoldCF 0.5
>            Reporter: Karl Wright
>            Assignee: Karl Wright
>              Labels: I18N, mysql
>             Fix For: ManifoldCF 0.5
>
>         Attachments: connectors.patch, framework.patch
>
>
> Hitoshi Ozawa wishes to contribute i18n support, a Japanese localization, and MySQL database support, all in one patch.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (CONNECTORS-314) Combined MySQL and i18n/Japanese contribution

Posted by "Karl Wright (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CONNECTORS-314?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13174937#comment-13174937 ] 

Karl Wright commented on CONNECTORS-314:
----------------------------------------

I created a branches/CONNECTORS-336 branch for working on the documentation, and pulled the documentation-related changes into it.


                
> Combined MySQL and i18n/Japanese contribution
> ---------------------------------------------
>
>                 Key: CONNECTORS-314
>                 URL: https://issues.apache.org/jira/browse/CONNECTORS-314
>             Project: ManifoldCF
>          Issue Type: Improvement
>          Components: Framework agents process, Framework core, Framework crawler agent
>    Affects Versions: ManifoldCF 0.5
>            Reporter: Karl Wright
>            Assignee: Karl Wright
>              Labels: I18N, mysql
>             Fix For: ManifoldCF 0.5
>
>         Attachments: CONNECTORS-314-doc20111220.patch, CONNECTORS-314.patch, CONNECTORS-314.patch, connectors.patch, framework.patch
>
>
> Hitoshi Ozawa wishes to contribute i18n support, a Japanese localization, and MySQL database support, all in one patch.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (CONNECTORS-314) Combined MySQL and i18n/Japanese contribution

Posted by "Hitoshi Ozawa (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CONNECTORS-314?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Hitoshi Ozawa updated CONNECTORS-314:
-------------------------------------

    Attachment: CONNECTORS-314.patch

SQL statements in JobManager.java was modified to run only for MySQL.

                
> Combined MySQL and i18n/Japanese contribution
> ---------------------------------------------
>
>                 Key: CONNECTORS-314
>                 URL: https://issues.apache.org/jira/browse/CONNECTORS-314
>             Project: ManifoldCF
>          Issue Type: Improvement
>          Components: Framework agents process, Framework core, Framework crawler agent
>    Affects Versions: ManifoldCF 0.5
>            Reporter: Karl Wright
>            Assignee: Karl Wright
>              Labels: I18N, mysql
>             Fix For: ManifoldCF 0.5
>
>         Attachments: CONNECTORS-314.patch, connectors.patch, framework.patch
>
>
> Hitoshi Ozawa wishes to contribute i18n support, a Japanese localization, and MySQL database support, all in one patch.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (CONNECTORS-314) Combined MySQL and i18n/Japanese contribution

Posted by "Hitoshi Ozawa (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CONNECTORS-314?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13172158#comment-13172158 ] 

Hitoshi Ozawa commented on CONNECTORS-314:
------------------------------------------

Separating properties file for each connector won't be too difficult. The Java properties files Message.java takes properties file name as a argument. Is it necessary to include Message.java in each connector or is it possible to just leave it as a common utility class? The fmt can be done as you've suggested.

I found another problem, the original Japanese patch files (*.utf) aren't coming out right with the right encoding with the svn command. I'll work on that.

There's "information schema" in MySQL. Just didn't have time this time to use it because it'll require more work. I wanted to show that it was possible to use MySQL with ManifoldCF and do the revisions afterwards. Somebody else may want to pitch in now since it's clear that it possible.

                
> Combined MySQL and i18n/Japanese contribution
> ---------------------------------------------
>
>                 Key: CONNECTORS-314
>                 URL: https://issues.apache.org/jira/browse/CONNECTORS-314
>             Project: ManifoldCF
>          Issue Type: Improvement
>          Components: Framework agents process, Framework core, Framework crawler agent
>    Affects Versions: ManifoldCF 0.5
>            Reporter: Karl Wright
>            Assignee: Karl Wright
>              Labels: I18N, mysql
>             Fix For: ManifoldCF 0.5
>
>         Attachments: CONNECTORS-314.patch, CONNECTORS-314.patch, connectors.patch, framework.patch
>
>
> Hitoshi Ozawa wishes to contribute i18n support, a Japanese localization, and MySQL database support, all in one patch.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (CONNECTORS-314) Combined MySQL and i18n/Japanese contribution

Posted by "Karl Wright (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CONNECTORS-314?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13175148#comment-13175148 ] 

Karl Wright commented on CONNECTORS-314:
----------------------------------------

Question for Hitoshi: What are the .utf8 files for?  The framework build.xml seems to process them right in place (which is, by the way, a bad idea because the source gets overwritten by the output).  But then the output seems to be unused in any case?  Can you explain how this works?

                
> Combined MySQL and i18n/Japanese contribution
> ---------------------------------------------
>
>                 Key: CONNECTORS-314
>                 URL: https://issues.apache.org/jira/browse/CONNECTORS-314
>             Project: ManifoldCF
>          Issue Type: Improvement
>          Components: Framework agents process, Framework core, Framework crawler agent
>    Affects Versions: ManifoldCF 0.5
>            Reporter: Karl Wright
>            Assignee: Karl Wright
>              Labels: I18N, mysql
>             Fix For: ManifoldCF 0.5
>
>         Attachments: CONNECTORS-314-doc20111220.patch, CONNECTORS-314.patch, CONNECTORS-314.patch, connectors.patch, framework.patch
>
>
> Hitoshi Ozawa wishes to contribute i18n support, a Japanese localization, and MySQL database support, all in one patch.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (CONNECTORS-314) Combined MySQL and i18n/Japanese contribution

Posted by "Karl Wright (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CONNECTORS-314?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13171980#comment-13171980 ] 

Karl Wright commented on CONNECTORS-314:
----------------------------------------

I've looked at the patches and tried to apply them, but they are not easily applied even against the manifoldcf-0.3-incubating release.  It looks like they are all made with diff rather than svn diff, and then stuck together.  Could you therefore do the following:

(1) svn co https://svn.apache.org/repos/asf/incubator/lcf/branches/CONNECTORS-314
(2) Apply your patches in the way you intended
(3) From the CONNECTORS-314 directory, do: svn diff >CONNECTORS-314.patch
(4) Attach CONNECTORS-314.patch to this ticket

I created branches/CONNECTORS-314 based on the manifoldcf-0.3-incubating release, so if what you said before is correct it should look very familiar to you.  Once that is done I will commit your patch to the CONNECTORS-314 branch and we can iterate as needed based on that.

Thanks!

                
> Combined MySQL and i18n/Japanese contribution
> ---------------------------------------------
>
>                 Key: CONNECTORS-314
>                 URL: https://issues.apache.org/jira/browse/CONNECTORS-314
>             Project: ManifoldCF
>          Issue Type: Improvement
>          Components: Framework agents process, Framework core, Framework crawler agent
>    Affects Versions: ManifoldCF 0.5
>            Reporter: Karl Wright
>            Assignee: Karl Wright
>              Labels: I18N, mysql
>             Fix For: ManifoldCF 0.5
>
>         Attachments: connectors.patch, framework.patch
>
>
> Hitoshi Ozawa wishes to contribute i18n support, a Japanese localization, and MySQL database support, all in one patch.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (CONNECTORS-314) Combined MySQL and i18n/Japanese contribution

Posted by "Hitoshi Ozawa (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CONNECTORS-314?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13172878#comment-13172878 ] 

Hitoshi Ozawa commented on CONNECTORS-314:
------------------------------------------

I want to merge the java and jsp properties files into one and take out the duplicates during the process.

>I'll commit the patch shortly. If you can get forrest to work with a subdirectory,
>great - in general, though, we've found it better to keep all the xml files in one
>directory. So that's what I'd recommend, and just give their names all an _ja suffix or something.

Either way is fine, but if there are going to be other translations, it'll be easier to maintain it in a subdirectory so that a new language will just be a subdirectory addition. I, also, may add some additional pages to set ManifoldCF for a Japanese environment if any additional steps are required. I'll add the the "_ja" suffix to the files just in case we decide to move the files up later.
                
> Combined MySQL and i18n/Japanese contribution
> ---------------------------------------------
>
>                 Key: CONNECTORS-314
>                 URL: https://issues.apache.org/jira/browse/CONNECTORS-314
>             Project: ManifoldCF
>          Issue Type: Improvement
>          Components: Framework agents process, Framework core, Framework crawler agent
>    Affects Versions: ManifoldCF 0.5
>            Reporter: Karl Wright
>            Assignee: Karl Wright
>              Labels: I18N, mysql
>             Fix For: ManifoldCF 0.5
>
>         Attachments: CONNECTORS-314-doc20111220.patch, CONNECTORS-314.patch, CONNECTORS-314.patch, connectors.patch, framework.patch
>
>
> Hitoshi Ozawa wishes to contribute i18n support, a Japanese localization, and MySQL database support, all in one patch.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (CONNECTORS-314) Combined MySQL and i18n/Japanese contribution

Posted by "Karl Wright (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CONNECTORS-314?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13171975#comment-13171975 ] 

Karl Wright commented on CONNECTORS-314:
----------------------------------------

How is the documentation structured?  Our site uses forrest, which translates xml documents to PDFs and HTML.  You can see the sources under the directory site/src/documentation/content/xdocs.  For Japanese documentation, I would imagine a parallel set of documents, e.g. "how-to-build-and-deploy-jp.xml".  How did you structure it?

                
> Combined MySQL and i18n/Japanese contribution
> ---------------------------------------------
>
>                 Key: CONNECTORS-314
>                 URL: https://issues.apache.org/jira/browse/CONNECTORS-314
>             Project: ManifoldCF
>          Issue Type: Improvement
>          Components: Framework agents process, Framework core, Framework crawler agent
>    Affects Versions: ManifoldCF 0.5
>            Reporter: Karl Wright
>            Assignee: Karl Wright
>              Labels: I18N, mysql
>             Fix For: ManifoldCF 0.5
>
>         Attachments: connectors.patch, framework.patch
>
>
> Hitoshi Ozawa wishes to contribute i18n support, a Japanese localization, and MySQL database support, all in one patch.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira