[GitHub] [pulsar] HQebupt commented on a diff in pull request #17872: [fix][broker] ClassCastException when specify flow_or_qps_equally_div…

[GitBox <gi...@apache.org>]

HQebupt commented on code in PR #17872:
URL: https://github.com/apache/pulsar/pull/17872#discussion_r982467524


##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/namespace/NamespaceService.java:
##########
@@ -832,8 +833,7 @@ void splitAndOwnBundleOnceAndRetry(NamespaceBundle bundle,
                                        NamespaceBundleSplitAlgorithm splitAlgorithm,
                                        List<Long> boundaries) {
         BundleSplitOption bundleSplitOption;
-        if (config.getDefaultNamespaceBundleSplitAlgorithm()
-                  .equals(NamespaceBundleSplitAlgorithm.FLOW_OR_QPS_EQUALLY_DIVIDE)) {
+        if (splitAlgorithm instanceof FlowOrQpsEquallyDivideBundleSplitAlgorithm) {

Review Comment:
   Good catch. Left a minor suggestion. Please add a test to avoid regression.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org