[GitHub] kristw commented on issue #5737: Add modules to sandbox.js

[GitBox <gi...@apache.org>]

kristw commented on issue #5737: Add modules to sandbox.js
URL: https://github.com/apache/incubator-superset/pull/5737#issuecomment-416625752
 
 
   What would be example of how user use `d3-color` in the sandbox? I am not sure we want to expose too many libraries in the sandbox. One thing to consider is it also adds a constraint for us when upgrading or switching library because there is no easy way to check if this will break these js code in sandbox. For example, now the codebase is stuck with `underscore` 1.8.x, although I would prefer to switch to `lodash`

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org