[GitHub] [spark] cloud-fan commented on a diff in pull request #41035: [SPARK-43357][SQL] Filter date type quote date

["cloud-fan (via GitHub)" <gi...@apache.org>]

cloud-fan commented on code in PR #41035:
URL: https://github.com/apache/spark/pull/41035#discussion_r1188380959


##########
sql/hive/src/test/scala/org/apache/spark/sql/hive/client/FiltersSuite.scala:
##########
@@ -66,17 +66,17 @@ class FiltersSuite extends SparkFunSuite with PlanTest {
 
   filterTest("date filter",
     (a("datecol", DateType) === Literal(Date.valueOf("2019-01-01"))) :: Nil,
-    "datecol = 2019-01-01")

Review Comment:
   I'm surprised hive supports this SQL syntax... `datecol = 2019-01-01`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org