You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2021/10/08 12:45:51 UTC
[GitHub] [flink] akalash opened a new pull request #17437: [FLINK-24467][streaming] Announce the min and max buffer size despite last diff less than threshold
akalash opened a new pull request #17437:
URL: https://github.com/apache/flink/pull/17437
<!--
*Thank you very much for contributing to Apache Flink - we are happy that you want to help us improve Flink. To help the community review your contribution in the best possible way, please go through the checklist below, which will get the contribution into a shape in which it can be best reviewed.*
*Please understand that we do not do this to make contributions to Flink a hassle. In order to uphold a high standard of quality for code contributions, while at the same time managing a large number of contributions, we need contributors to prepare the contributions well, and give reviewers enough contextual information for the review. Please also understand that contributions that do not follow this guide will take longer to review and thus typically be picked up with lower priority by the community.*
## Contribution Checklist
- Make sure that the pull request corresponds to a [JIRA issue](https://issues.apache.org/jira/projects/FLINK/issues). Exceptions are made for typos in JavaDoc or documentation files, which need no JIRA issue.
- Name the pull request in the form "[FLINK-XXXX] [component] Title of the pull request", where *FLINK-XXXX* should be replaced by the actual issue number. Skip *component* if you are unsure about which is the best component.
Typo fixes that have no associated JIRA issue should be named following this pattern: `[hotfix] [docs] Fix typo in event time introduction` or `[hotfix] [javadocs] Expand JavaDoc for PuncuatedWatermarkGenerator`.
- Fill out the template below to describe the changes contributed by the pull request. That will give reviewers the context they need to do the review.
- Make sure that the change passes the automated tests, i.e., `mvn clean verify` passes. You can set up Azure Pipelines CI to do that following [this guide](https://cwiki.apache.org/confluence/display/FLINK/Azure+Pipelines#AzurePipelines-Tutorial:SettingupAzurePipelinesforaforkoftheFlinkrepository).
- Each pull request should address only one issue, not mix up code from multiple issues.
- Each commit in the pull request has a meaningful commit message (including the JIRA id)
- Once all items of the checklist are addressed, remove the above text and this checklist, leaving only the filled out template below.
**(The sections below can be removed for hotfixes of typos)**
-->
## What is the purpose of the change
*This PR fixes the situation when the newly calculated buffer size is equal to min or max possible size and it isn't announced because the diff with the previous value is less than a threshold value.*
## Brief change log
- *Changed the condition for the announcement of the newly calculated buffer size.*
## Verifying this change
This change added tests and can be verified as follows:
- *Added new tests into BufferDebloaterTest*
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (yes / **no**)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes / **no**)
- The serializers: (yes / **no** / don't know)
- The runtime per-record code paths (performance sensitive): (yes / **no** / don't know)
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (yes / **no** / don't know)
- The S3 file system connector: (yes / **no** / don't know)
## Documentation
- Does this pull request introduce a new feature? (yes / **no**)
- If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #17437: [FLINK-24467][streaming] Announce the min and max buffer size despite last diff less than threshold
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #17437:
URL: https://github.com/apache/flink/pull/17437#issuecomment-938641904
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "fbfc14527fed6e285c2d65460cc317b10e5e2e94",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "fbfc14527fed6e285c2d65460cc317b10e5e2e94",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* fbfc14527fed6e285c2d65460cc317b10e5e2e94 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17437: [FLINK-24467][streaming] Announce the min and max buffer size despite last diff less than threshold
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17437:
URL: https://github.com/apache/flink/pull/17437#issuecomment-938641904
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "fbfc14527fed6e285c2d65460cc317b10e5e2e94",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24858",
"triggerID" : "fbfc14527fed6e285c2d65460cc317b10e5e2e94",
"triggerType" : "PUSH"
}, {
"hash" : "99519029ca897f2c0e6cc40e5e8b3ff1557c1cc4",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24962",
"triggerID" : "99519029ca897f2c0e6cc40e5e8b3ff1557c1cc4",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* fbfc14527fed6e285c2d65460cc317b10e5e2e94 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24858)
* 99519029ca897f2c0e6cc40e5e8b3ff1557c1cc4 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24962)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17437: [FLINK-24467][streaming] Announce the min and max buffer size despite last diff less than threshold
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17437:
URL: https://github.com/apache/flink/pull/17437#issuecomment-938641904
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "fbfc14527fed6e285c2d65460cc317b10e5e2e94",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24858",
"triggerID" : "fbfc14527fed6e285c2d65460cc317b10e5e2e94",
"triggerType" : "PUSH"
}, {
"hash" : "99519029ca897f2c0e6cc40e5e8b3ff1557c1cc4",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24962",
"triggerID" : "99519029ca897f2c0e6cc40e5e8b3ff1557c1cc4",
"triggerType" : "PUSH"
}, {
"hash" : "144e98c5abef798d7542de0002e1f4630ca3ab8f",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24978",
"triggerID" : "144e98c5abef798d7542de0002e1f4630ca3ab8f",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 144e98c5abef798d7542de0002e1f4630ca3ab8f Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24978)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17437: [FLINK-24467][streaming] Announce the min and max buffer size despite last diff less than threshold
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17437:
URL: https://github.com/apache/flink/pull/17437#issuecomment-938641904
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "fbfc14527fed6e285c2d65460cc317b10e5e2e94",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24858",
"triggerID" : "fbfc14527fed6e285c2d65460cc317b10e5e2e94",
"triggerType" : "PUSH"
}, {
"hash" : "99519029ca897f2c0e6cc40e5e8b3ff1557c1cc4",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "99519029ca897f2c0e6cc40e5e8b3ff1557c1cc4",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* fbfc14527fed6e285c2d65460cc317b10e5e2e94 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24858)
* 99519029ca897f2c0e6cc40e5e8b3ff1557c1cc4 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] dawidwys closed pull request #17437: [FLINK-24467][streaming] Announce the min and max buffer size despite last diff less than threshold
Posted by GitBox <gi...@apache.org>.
dawidwys closed pull request #17437:
URL: https://github.com/apache/flink/pull/17437
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17437: [FLINK-24467][streaming] Announce the min and max buffer size despite last diff less than threshold
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17437:
URL: https://github.com/apache/flink/pull/17437#issuecomment-938641904
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "fbfc14527fed6e285c2d65460cc317b10e5e2e94",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24858",
"triggerID" : "fbfc14527fed6e285c2d65460cc317b10e5e2e94",
"triggerType" : "PUSH"
}, {
"hash" : "99519029ca897f2c0e6cc40e5e8b3ff1557c1cc4",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24962",
"triggerID" : "99519029ca897f2c0e6cc40e5e8b3ff1557c1cc4",
"triggerType" : "PUSH"
}, {
"hash" : "144e98c5abef798d7542de0002e1f4630ca3ab8f",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24978",
"triggerID" : "144e98c5abef798d7542de0002e1f4630ca3ab8f",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 99519029ca897f2c0e6cc40e5e8b3ff1557c1cc4 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24962)
* 144e98c5abef798d7542de0002e1f4630ca3ab8f Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24978)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #17437: [FLINK-24467][streaming] Announce the min and max buffer size despite last diff less than threshold
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #17437:
URL: https://github.com/apache/flink/pull/17437#issuecomment-938616378
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit fbfc14527fed6e285c2d65460cc317b10e5e2e94 (Fri Oct 08 12:48:56 UTC 2021)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17437: [FLINK-24467][streaming] Announce the min and max buffer size despite last diff less than threshold
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17437:
URL: https://github.com/apache/flink/pull/17437#issuecomment-938641904
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "fbfc14527fed6e285c2d65460cc317b10e5e2e94",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24858",
"triggerID" : "fbfc14527fed6e285c2d65460cc317b10e5e2e94",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* fbfc14527fed6e285c2d65460cc317b10e5e2e94 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24858)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17437: [FLINK-24467][streaming] Announce the min and max buffer size despite last diff less than threshold
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17437:
URL: https://github.com/apache/flink/pull/17437#issuecomment-938641904
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "fbfc14527fed6e285c2d65460cc317b10e5e2e94",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24858",
"triggerID" : "fbfc14527fed6e285c2d65460cc317b10e5e2e94",
"triggerType" : "PUSH"
}, {
"hash" : "99519029ca897f2c0e6cc40e5e8b3ff1557c1cc4",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24962",
"triggerID" : "99519029ca897f2c0e6cc40e5e8b3ff1557c1cc4",
"triggerType" : "PUSH"
}, {
"hash" : "144e98c5abef798d7542de0002e1f4630ca3ab8f",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "144e98c5abef798d7542de0002e1f4630ca3ab8f",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 99519029ca897f2c0e6cc40e5e8b3ff1557c1cc4 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24962)
* 144e98c5abef798d7542de0002e1f4630ca3ab8f UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17437: [FLINK-24467][streaming] Announce the min and max buffer size despite last diff less than threshold
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17437:
URL: https://github.com/apache/flink/pull/17437#issuecomment-938641904
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "fbfc14527fed6e285c2d65460cc317b10e5e2e94",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24858",
"triggerID" : "fbfc14527fed6e285c2d65460cc317b10e5e2e94",
"triggerType" : "PUSH"
}, {
"hash" : "99519029ca897f2c0e6cc40e5e8b3ff1557c1cc4",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24962",
"triggerID" : "99519029ca897f2c0e6cc40e5e8b3ff1557c1cc4",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 99519029ca897f2c0e6cc40e5e8b3ff1557c1cc4 Azure: [FAILURE](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24962)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] dawidwys commented on a change in pull request #17437: [FLINK-24467][streaming] Announce the min and max buffer size despite last diff less than threshold
Posted by GitBox <gi...@apache.org>.
dawidwys commented on a change in pull request #17437:
URL: https://github.com/apache/flink/pull/17437#discussion_r725959369
##########
File path: flink-streaming-java/src/test/java/org/apache/flink/streaming/runtime/tasks/bufferdebloat/BufferDebloaterTest.java
##########
@@ -105,14 +107,50 @@ public void testNegativeConsumptionTime() {
testBufferSizeCalculation(3, asList(3, 5, 8), 3333, 50, 1100, -1, 248);
}
- private void testBufferSizeCalculation(
+ @Test
+ public void testAnnouncedMaxBufferSizeEvenDespiteLastDiffLessThanThreshold() {
+ // Calculate the buffer size a little lower than the max buffer size.
+ BufferDebloater bufferDebloater =
+ testBufferSizeCalculation(1, singletonList(1), 500, 50, 1100, 1000, 500);
Review comment:
nit: it's rather hard to understand what the numbers mean. Would be nice to have some kind of an asserter/builder pattern here IMO:
```
testBufferDebloat()
.withGates(1)
.withNumberOfBuffersInUse(1, ...)
.withThroughput(...)
.withBufferSize(min, max)
.expectBufferSize(500);
```
##########
File path: flink-streaming-java/src/test/java/org/apache/flink/streaming/runtime/tasks/bufferdebloat/BufferDebloaterTest.java
##########
@@ -105,14 +107,50 @@ public void testNegativeConsumptionTime() {
testBufferSizeCalculation(3, asList(3, 5, 8), 3333, 50, 1100, -1, 248);
}
- private void testBufferSizeCalculation(
+ @Test
+ public void testAnnouncedMaxBufferSizeEvenDespiteLastDiffLessThanThreshold() {
Review comment:
```suggestion
public void testAnnouncedMaxBufferSizeDespiteLastDiffLessThanThreshold() {
```
##########
File path: flink-streaming-java/src/test/java/org/apache/flink/streaming/runtime/tasks/bufferdebloat/BufferDebloaterTest.java
##########
@@ -105,14 +107,50 @@ public void testNegativeConsumptionTime() {
testBufferSizeCalculation(3, asList(3, 5, 8), 3333, 50, 1100, -1, 248);
}
- private void testBufferSizeCalculation(
+ @Test
+ public void testAnnouncedMaxBufferSizeEvenDespiteLastDiffLessThanThreshold() {
+ // Calculate the buffer size a little lower than the max buffer size.
+ BufferDebloater bufferDebloater =
+ testBufferSizeCalculation(1, singletonList(1), 500, 50, 1100, 1000, 500);
+ bufferDebloater.recalculateBufferSize(1000);
+ assertThat(bufferDebloater.getLastBufferSize(), is(1000));
+
+ // Recalculate the buffer size to max value.
+ bufferDebloater.recalculateBufferSize(2000);
+
+ // The max value should be announced despite it differ from the previous one by less than
+ // threshold value.
+ assertThat(bufferDebloater.getLastBufferSize(), is(1100));
+
+ // Make sure that there is no repeated announcement of max buffer size.
+ bufferDebloater.recalculateBufferSize(2000);
+ }
+
+ @Test
+ public void testAnnouncedMinBufferSizeEvenDespiteLastDiffLessThanThreshold() {
+ // Calculate the buffer size a little greater than the min buffer size.
+ BufferDebloater bufferDebloater =
+ testBufferSizeCalculation(1, singletonList(1), 60, 50, 1100, 1000, 60);
Review comment:
What is the initial buffer size? Can we make it prominent in the test similarly as in the max buffer size case.
##########
File path: flink-streaming-java/src/test/java/org/apache/flink/streaming/runtime/tasks/bufferdebloat/BufferDebloaterTest.java
##########
@@ -105,14 +107,50 @@ public void testNegativeConsumptionTime() {
testBufferSizeCalculation(3, asList(3, 5, 8), 3333, 50, 1100, -1, 248);
}
- private void testBufferSizeCalculation(
+ @Test
+ public void testAnnouncedMaxBufferSizeEvenDespiteLastDiffLessThanThreshold() {
+ // Calculate the buffer size a little lower than the max buffer size.
+ BufferDebloater bufferDebloater =
+ testBufferSizeCalculation(1, singletonList(1), 500, 50, 1100, 1000, 500);
+ bufferDebloater.recalculateBufferSize(1000);
+ assertThat(bufferDebloater.getLastBufferSize(), is(1000));
+
+ // Recalculate the buffer size to max value.
+ bufferDebloater.recalculateBufferSize(2000);
+
+ // The max value should be announced despite it differ from the previous one by less than
+ // threshold value.
+ assertThat(bufferDebloater.getLastBufferSize(), is(1100));
+
+ // Make sure that there is no repeated announcement of max buffer size.
+ bufferDebloater.recalculateBufferSize(2000);
+ }
+
+ @Test
+ public void testAnnouncedMinBufferSizeEvenDespiteLastDiffLessThanThreshold() {
Review comment:
```suggestion
public void testAnnouncedMinBufferSizeDespiteLastDiffLessThanThreshold() {
```
##########
File path: flink-streaming-java/src/test/java/org/apache/flink/streaming/runtime/tasks/bufferdebloat/BufferDebloaterTest.java
##########
@@ -105,14 +107,50 @@ public void testNegativeConsumptionTime() {
testBufferSizeCalculation(3, asList(3, 5, 8), 3333, 50, 1100, -1, 248);
}
- private void testBufferSizeCalculation(
+ @Test
+ public void testAnnouncedMaxBufferSizeEvenDespiteLastDiffLessThanThreshold() {
+ // Calculate the buffer size a little lower than the max buffer size.
+ BufferDebloater bufferDebloater =
+ testBufferSizeCalculation(1, singletonList(1), 500, 50, 1100, 1000, 500);
Review comment:
I don't mind if we don't do it in this PR. I put it here more for the future.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] akalash commented on a change in pull request #17437: [FLINK-24467][streaming] Announce the min and max buffer size despite last diff less than threshold
Posted by GitBox <gi...@apache.org>.
akalash commented on a change in pull request #17437:
URL: https://github.com/apache/flink/pull/17437#discussion_r726336587
##########
File path: flink-streaming-java/src/test/java/org/apache/flink/streaming/runtime/tasks/bufferdebloat/BufferDebloaterTest.java
##########
@@ -105,14 +107,50 @@ public void testNegativeConsumptionTime() {
testBufferSizeCalculation(3, asList(3, 5, 8), 3333, 50, 1100, -1, 248);
}
- private void testBufferSizeCalculation(
+ @Test
+ public void testAnnouncedMaxBufferSizeEvenDespiteLastDiffLessThanThreshold() {
+ // Calculate the buffer size a little lower than the max buffer size.
+ BufferDebloater bufferDebloater =
+ testBufferSizeCalculation(1, singletonList(1), 500, 50, 1100, 1000, 500);
+ bufferDebloater.recalculateBufferSize(1000);
+ assertThat(bufferDebloater.getLastBufferSize(), is(1000));
+
+ // Recalculate the buffer size to max value.
+ bufferDebloater.recalculateBufferSize(2000);
+
+ // The max value should be announced despite it differ from the previous one by less than
+ // threshold value.
+ assertThat(bufferDebloater.getLastBufferSize(), is(1100));
+
+ // Make sure that there is no repeated announcement of max buffer size.
+ bufferDebloater.recalculateBufferSize(2000);
+ }
+
+ @Test
+ public void testAnnouncedMinBufferSizeEvenDespiteLastDiffLessThanThreshold() {
+ // Calculate the buffer size a little greater than the min buffer size.
+ BufferDebloater bufferDebloater =
+ testBufferSizeCalculation(1, singletonList(1), 60, 50, 1100, 1000, 60);
Review comment:
The initial value is always max value but after this method, it will be 60(because throughput is 60). But you are right and I will add this information explicitly
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17437: [FLINK-24467][streaming] Announce the min and max buffer size despite last diff less than threshold
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17437:
URL: https://github.com/apache/flink/pull/17437#issuecomment-938641904
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "fbfc14527fed6e285c2d65460cc317b10e5e2e94",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24858",
"triggerID" : "fbfc14527fed6e285c2d65460cc317b10e5e2e94",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* fbfc14527fed6e285c2d65460cc317b10e5e2e94 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=24858)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org