[jira] [Commented] (CASSANDRA-16575) "compression" configuration in unit tests is incorrect

["Jacek Lewandowski (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CASSANDRA-16575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17317947#comment-17317947 ] 

Jacek Lewandowski commented on CASSANDRA-16575:
-----------------------------------------------

This is my proposal: https://github.com/apache/cassandra/pull/957


> "compression" configuration in unit tests is incorrect
> ------------------------------------------------------
>
>                 Key: CASSANDRA-16575
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-16575
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Test/unit
>            Reporter: Jacek Lewandowski
>            Priority: Normal
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> When running unit tests with "compression" configuration, we use non-default Snappy compressor.
> There is a misleading fragment of {{build.xml}}:
> {code}
>       <property name="compressed_yaml" value="${build.test.dir}/cassandra.compressed.yaml"/>
>       <concat destfile="${compressed_yaml}">
>           <fileset file="${test.conf}/cassandra.yaml"/>
>           <fileset file="${test.conf}/commitlog_compression.yaml"/>
>       </concat>
> {code}
> {{cassandra.compressed.yaml}} has been replaced in CASSANDRA-14482 by two files {{commitlog_compression_LZ4.yaml}} and {{commitlog_compression_Zstd.yaml}} without changing build configuration.
> All in all we could fix that but I doubt it makes any sense since {{cdc}} configuration already uses compressed commit log anyway so it feels redundant to test compression alone for each CI run. 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For additional commands, e-mail: commits-help@cassandra.apache.org