You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/03/12 20:00:24 UTC
[GitHub] [superset] codecov[bot] edited a comment on pull request #13603: fix: default when adding tab_state.hide_left_bar
codecov[bot] edited a comment on pull request #13603:
URL: https://github.com/apache/superset/pull/13603#issuecomment-797721181
# [Codecov](https://codecov.io/gh/apache/superset/pull/13603?src=pr&el=h1) Report
> Merging [#13603](https://codecov.io/gh/apache/superset/pull/13603?src=pr&el=desc) (182ff8d) into [master](https://codecov.io/gh/apache/superset/commit/de0c6c9c56636d48b199af78b50ea91cb43b8f9f?el=desc) (de0c6c9) will **decrease** coverage by `9.98%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/superset/pull/13603?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13603 +/- ##
==========================================
- Coverage 80.93% 70.94% -9.99%
==========================================
Files 304 828 +524
Lines 24807 41443 +16636
Branches 0 4300 +4300
==========================================
+ Hits 20077 29401 +9324
- Misses 4730 12042 +7312
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `56.73% <100.00%> (?)` | |
| hive | `?` | |
| mysql | `?` | |
| postgres | `80.42% <ø> (ø)` | |
| presto | `?` | |
| python | `80.46% <ø> (-0.47%)` | :arrow_down: |
| sqlite | `80.03% <ø> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13603?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...end/src/views/CRUD/data/database/DatabaseModal.tsx](https://codecov.io/gh/apache/superset/pull/13603/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGF0YS9kYXRhYmFzZS9EYXRhYmFzZU1vZGFsLnRzeA==) | `69.59% <100.00%> (ø)` | |
| [...set-frontend/src/views/CRUD/data/database/state.ts](https://codecov.io/gh/apache/superset/pull/13603/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGF0YS9kYXRhYmFzZS9zdGF0ZS50cw==) | `100.00% <100.00%> (ø)` | |
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/superset/pull/13603/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/superset/pull/13603/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `74.23% <0.00%> (-16.54%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/superset/pull/13603/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `81.79% <0.00%> (-6.91%)` | :arrow_down: |
| [superset/views/database/mixins.py](https://codecov.io/gh/apache/superset/pull/13603/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `81.03% <0.00%> (-1.73%)` | :arrow_down: |
| [superset/db\_engine\_specs/mysql.py](https://codecov.io/gh/apache/superset/pull/13603/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL215c3FsLnB5) | `91.66% <0.00%> (-1.67%)` | :arrow_down: |
| [superset/models/core.py](https://codecov.io/gh/apache/superset/pull/13603/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `87.73% <0.00%> (-1.09%)` | :arrow_down: |
| [superset/db\_engine\_specs/base.py](https://codecov.io/gh/apache/superset/pull/13603/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2Jhc2UucHk=) | `85.67% <0.00%> (-0.49%)` | :arrow_down: |
| [superset/views/core.py](https://codecov.io/gh/apache/superset/pull/13603/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `75.11% <0.00%> (-0.45%)` | :arrow_down: |
| ... and [525 more](https://codecov.io/gh/apache/superset/pull/13603/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13603?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13603?src=pr&el=footer). Last update [de0c6c9...8ec1f3c](https://codecov.io/gh/apache/superset/pull/13603?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org