You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@geode.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2017/08/12 22:14:00 UTC
[jira] [Commented] (GEODE-3436) GFSH commands tests are failing
after committing refactorings of command classes
[ https://issues.apache.org/jira/browse/GEODE-3436?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16124728#comment-16124728 ]
ASF GitHub Bot commented on GEODE-3436:
---------------------------------------
GitHub user kirklund opened a pull request:
https://github.com/apache/geode/pull/711
GEODE-3436: revert all commands refactorings
Revert these commits to return precheckin to GREEN:
commit d27f8b956de7d9c5d95ebdc68dfc67ee8b2d7b51
Author: YehEmily <em...@gmail.com>
Date: Mon Aug 7 13:09:42 2017 -0700
GEODE-3264: Refactoring MemberCommands
This closes #692
commit 440c87f81fab96f9ce38a2d53ded75e5fe8390d7
Author: YehEmily <em...@gmail.com>
Date: Mon Aug 7 11:52:14 2017 -0700
GEODE-3259: Refactoring DurableClientCommands
This closes #689
commit 97c4e9a59f17c7bc914e39dd048b0a4cd96293c4
Author: YehEmily <em...@gmail.com>
Date: Wed Jul 26 11:07:09 2017 -0700
GEODE-3254: Refactoring ConfigCommands
This closes #665
commit ed293e817e547fb5ecd399bf4ba10d694af51e0a
Author: YehEmily <em...@gmail.com>
Date: Mon Aug 7 12:35:14 2017 -0700
GEODE-3262: Refactoring IndexCommands
This closes #690
commit 90f5440de8ec747f301a309a0a34101e8defcd29
Author: YehEmily <em...@gmail.com>
Date: Mon Aug 7 12:56:17 2017 -0700
GEODE-3260: Refactoring FunctionCommands
This closes #691
commit 5d6cad7755ec3c4fe931e3d0f8e89fb181038543
Author: YehEmily <em...@gmail.com>
Date: Thu Aug 3 09:00:08 2017 -0700
GEODE-3258: Refactoring DiskStoreCommands
This closes #687
commit 210ff9f15460c993f2bf7fd682d50ee65462cd23
Author: YehEmily <em...@gmail.com>
Date: Fri Aug 11 10:22:33 2017 -0700
GEODE-3337: Refactoring LauncherLifecycleCommandsDUnitTest
This closes #701
commit 63169699e933f6e0fdd90b95ed039e4e3c92c32c
Author: YehEmily <em...@gmail.com>
Date: Mon Aug 7 15:37:23 2017 -0700
GEODE-3265: Refactoring MiscellaneousCommands
This closes #696
commit cf91426692349d0c81ce77394935576d9cc336e8
Author: YehEmily <em...@gmail.com>
Date: Fri Aug 4 11:12:50 2017 -0700
GEODE-3261: Refactoring GfshHelpCommands
This closes #685
commit fd47ed660168864a6f81b2a4cd7dbceebc99a282
Author: YehEmily <em...@gmail.com>
Date: Mon Aug 7 14:47:15 2017 -0700
GEODE-3267: Refactoring QueueCommands
This closes #695
commit 359e3fff6482ecfb375939d387f4dad3a636246b
Author: YehEmily <em...@gmail.com>
Date: Mon Aug 7 14:32:43 2017 -0700
GEODE-3270: Refactoring (renaming) StatusCommands
This closes #694
commit 957d583e54dc34c029885f32a54f0b25a3ac1094
Author: YehEmily <em...@gmail.com>
Date: Mon Aug 7 15:25:24 2017 -0700
GEODE-3267: Refactoring QueueCommands - updated based on feedback
commit 64de3b69c2aecb4930bcfd0a1161569b1d5fda89
Author: YehEmily <em...@gmail.com>
Date: Mon Aug 7 13:58:08 2017 -0700
GEODE-3268: Refactoring RegionCommands
This closes #693
commit 67185abcdd68b908dea6888cb94286b8aa9ea49f
Author: YehEmily <em...@gmail.com>
Date: Fri Aug 4 10:47:48 2017 -0700
GEODE-3266: Refactoring PDXCommands
This closes #684
commit 9d967446a44a78b612f605b6a8f8eedcfc625b3a
Author: YehEmily <em...@gmail.com>
Date: Wed Aug 2 17:28:10 2017 -0700
GEODE-3257: Refactoring DeployCommands
This closes #680
commit 756efe77c86bb03ac9984655e7bd040659e85890
Author: YehEmily <em...@gmail.com>
Date: Fri Jul 28 14:23:25 2017 -0700
GEODE-3255: Refactor CreateAlterDestroyRegionCommands and tests
This closes #671
commit a7f29525df2981c1c99abac96ea83cb965295970
Author: YehEmily <em...@gmail.com>
Date: Fri Jul 21 14:29:55 2017 -0700
GEODE-3230: Cleaning up unused (Cli)Strings
This closes #651
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/kirklund/geode revert-all
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/geode/pull/711.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #711
----
commit 47377c8086e57a88a87244ed77cad48e43495dd5
Author: Kirk Lund <kl...@apache.org>
Date: 2017-08-12T16:38:20Z
Revert "GEODE-3264: Refactoring MemberCommands"
This reverts commit d27f8b956de7d9c5d95ebdc68dfc67ee8b2d7b51.
commit fd6fcc7dd65b83c030d6f7bb754ed921a9ab8829
Author: Kirk Lund <kl...@apache.org>
Date: 2017-08-12T16:38:28Z
Revert "GEODE-3259: Refactoring DurableClientCommands"
This reverts commit 440c87f81fab96f9ce38a2d53ded75e5fe8390d7.
commit 969d71b60fa3d8ff8b91a21d8c4df4a830cfec30
Author: Kirk Lund <kl...@apache.org>
Date: 2017-08-12T16:38:29Z
Revert "GEODE-3254: Refactoring ConfigCommands"
This reverts commit 97c4e9a59f17c7bc914e39dd048b0a4cd96293c4.
commit d0e0e63a4842bf17af808b1c5dc8d5e04dcb0cac
Author: Kirk Lund <kl...@apache.org>
Date: 2017-08-12T16:38:30Z
Revert "GEODE-3262: Refactoring IndexCommands"
This reverts commit ed293e817e547fb5ecd399bf4ba10d694af51e0a.
commit da89564fe55dc9909c917cb458059cca25fdbcfc
Author: Kirk Lund <kl...@apache.org>
Date: 2017-08-12T16:38:32Z
Revert "GEODE-3260: Refactoring FunctionCommands"
This reverts commit 90f5440de8ec747f301a309a0a34101e8defcd29.
commit 4c8579306ab35a55e6a548dace079b3574509c85
Author: Kirk Lund <kl...@apache.org>
Date: 2017-08-12T16:38:33Z
Revert "GEODE-3258: Refactoring DiskStoreCommands"
This reverts commit 5d6cad7755ec3c4fe931e3d0f8e89fb181038543.
commit 151d189fee41c03dbd84d2ad0922063b27db1191
Author: Kirk Lund <kl...@apache.org>
Date: 2017-08-12T16:38:34Z
Revert "GEODE-3337: Refactoring LauncherLifecycleCommandsDUnitTest"
This reverts commit 210ff9f15460c993f2bf7fd682d50ee65462cd23.
commit b8f413762f32654fb213238e39386556189b5848
Author: Kirk Lund <kl...@apache.org>
Date: 2017-08-12T16:38:35Z
Revert "GEODE-3265: Refactoring MiscellaneousCommands"
This reverts commit 63169699e933f6e0fdd90b95ed039e4e3c92c32c.
commit 8e3c02c54f156920d708b73f2f91f6e61a08fb93
Author: Kirk Lund <kl...@apache.org>
Date: 2017-08-12T16:38:36Z
Revert "GEODE-3261: Refactoring GfshHelpCommands"
This reverts commit cf91426692349d0c81ce77394935576d9cc336e8.
commit 5e432461a551ab9384c57a45140531d27b9916aa
Author: Kirk Lund <kl...@apache.org>
Date: 2017-08-12T16:38:37Z
Revert "GEODE-3267: Refactoring QueueCommands"
This reverts commit fd47ed660168864a6f81b2a4cd7dbceebc99a282.
commit e6806b41b61c30cae41f282f63142452cc444cf0
Author: Kirk Lund <kl...@apache.org>
Date: 2017-08-12T16:38:39Z
Revert "GEODE-3270: Refactoring (renaming) StatusCommands"
This reverts commit 359e3fff6482ecfb375939d387f4dad3a636246b.
commit 3ce73706bbfd3dcd9d4f42f3a164d02001a073c1
Author: Kirk Lund <kl...@apache.org>
Date: 2017-08-12T16:38:40Z
Revert "GEODE-3267: Refactoring QueueCommands - updated based on feedback"
This reverts commit 957d583e54dc34c029885f32a54f0b25a3ac1094.
commit 0ace5b0462d52e3df21205df3e19391ccb682eeb
Author: Kirk Lund <kl...@apache.org>
Date: 2017-08-12T16:38:41Z
Revert "GEODE-3268: Refactoring RegionCommands"
This reverts commit 64de3b69c2aecb4930bcfd0a1161569b1d5fda89.
commit 9ab6de31f392ccac4621005407734dc0f3333031
Author: Kirk Lund <kl...@apache.org>
Date: 2017-08-12T16:38:42Z
Revert "GEODE-3266: Refactoring PDXCommands"
This reverts commit 67185abcdd68b908dea6888cb94286b8aa9ea49f.
commit bf7f265032f7be7b9d6b42794e60712751d18b2b
Author: Kirk Lund <kl...@apache.org>
Date: 2017-08-12T16:38:43Z
Revert "GEODE-3257: Refactoring DeployCommands"
This reverts commit 9d967446a44a78b612f605b6a8f8eedcfc625b3a.
commit a564dcb0a065eca2c645a35c25e856ac6b31e773
Author: Kirk Lund <kl...@apache.org>
Date: 2017-08-12T16:38:44Z
Revert "GEODE-3255: Refactor CreateAlterDestroyRegionCommands and tests"
This reverts commit 756efe77c86bb03ac9984655e7bd040659e85890.
commit ada7c25ba07f72735efae1115849b43ef89cc116
Author: Kirk Lund <kl...@apache.org>
Date: 2017-08-12T16:38:45Z
Revert "GEODE-3230: Cleaning up unused (Cli)Strings"
This reverts commit a7f29525df2981c1c99abac96ea83cb965295970.
----
> GFSH commands tests are failing after committing refactorings of command classes
> --------------------------------------------------------------------------------
>
> Key: GEODE-3436
> URL: https://issues.apache.org/jira/browse/GEODE-3436
> Project: Geode
> Issue Type: Bug
> Components: gfsh, tests
> Reporter: Kirk Lund
>
> {noformat}
> :geode-core:integrationTest
> org.apache.geode.management.internal.cli.help.HelperIntegrationTest > testHelpWithNoInput FAILED
> java.lang.AssertionError:
> Expected size:<2> but was:<4> in:
> <["help (Available)",
> "Display syntax and usage information for all commands or list all available commands if <command> isn't specified.",
> "hint (Available)",
> "Provide hints for a topic or list all available topics if "topic" isn't specified."]>
> at org.apache.geode.management.internal.cli.help.HelperIntegrationTest.testHelpWithNoInput(HelperIntegrationTest.java:69)
> org.apache.geode.management.internal.cli.help.HelperIntegrationTest > testHintWithNoInput FAILED
> java.lang.AssertionError:
> Expected size:<21> but was:<22> in:
> <["Hints are available for the following topics. Use "hint <topic-name>" for a specific hint.",
> "",
> "Client",
> "Cluster Configuration",
> "Configuration",
> "Data",
> "Debug-Utility",
> "Disk Store",
> "Function Execution",
> "GFSH",
> "Geode",
> "Help",
> "JMX",
> "Lifecycle",
> "Locator",
> "Logs",
> "Management-Monitoring",
> "Manager",
> "Region",
> "Server",
> "Statistics",
> "WAN"]>
> at org.apache.geode.management.internal.cli.help.HelperIntegrationTest.testHintWithNoInput(HelperIntegrationTest.java:96)
> org.apache.geode.management.internal.cli.GfshParserConverterTest > testHintConverter FAILED
> java.lang.StringIndexOutOfBoundsException: String index out of range: -1
> at java.lang.String.substring(String.java:1931)
> at org.apache.geode.management.internal.cli.GfshParser.lambda$completeAdvanced$0(GfshParser.java:265)
> at java.util.ArrayList.replaceAll(ArrayList.java:1442)
> at org.apache.geode.management.internal.cli.GfshParser.completeAdvanced(GfshParser.java:264)
> at org.apache.geode.test.dunit.rules.GfshParserRule.complete(GfshParserRule.java:58)
> at org.apache.geode.management.internal.cli.GfshParserConverterTest.testHintConverter(GfshParserConverterTest.java:126)
> org.apache.geode.management.internal.security.CliCommandsSecurityTest > testNoAccess FAILED
> org.assertj.core.api.SoftAssertionError:
> The following assertion failed:
> 1) [destroy function --id=InterestCalculations]
> Expecting:
> <"stranger not authorized for CLUSTER:MANAGE:JAR">
> to contain:
> <"DATA:MANAGE">
> at CliCommandsSecurityTest.testNoAccess(CliCommandsSecurityTest.java:74)
> at org.assertj.core.api.SoftAssertions.assertAll(SoftAssertions.java:134)
> at org.apache.geode.management.internal.security.CliCommandsSecurityTest.testNoAccess(CliCommandsSecurityTest.java:78)
> org.apache.geode.management.internal.security.GfshCommandsSecurityTest > testRegionAReader FAILED
> org.junit.ComparisonFailure: [destroy function --id=InterestCalculations] expected:<[110]> but was:<[415]>
> at sun.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method)
> at sun.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:62)
> at sun.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45)
> at org.apache.geode.management.internal.security.GfshCommandsSecurityTest.runCommandsPermittedAndForbiddenBy(GfshCommandsSecurityTest.java:164)
> at org.apache.geode.management.internal.security.GfshCommandsSecurityTest.testRegionAReader(GfshCommandsSecurityTest.java:108)
> org.apache.geode.management.internal.security.GfshCommandsSecurityTest > testRegionAWriter FAILED
> org.junit.ComparisonFailure: [destroy function --id=InterestCalculations] expected:<[110]> but was:<[415]>
> at sun.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method)
> at sun.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:62)
> at sun.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45)
> at org.apache.geode.management.internal.security.GfshCommandsSecurityTest.runCommandsPermittedAndForbiddenBy(GfshCommandsSecurityTest.java:164)
> at org.apache.geode.management.internal.security.GfshCommandsSecurityTest.testRegionAWriter(GfshCommandsSecurityTest.java:114)
> org.apache.geode.management.internal.security.GfshCommandsSecurityTest > testClusterReader FAILED
> org.junit.ComparisonFailure: [destroy function --id=InterestCalculations] expected:<[110]> but was:<[415]>
> at sun.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method)
> at sun.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:62)
> at sun.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45)
> at org.apache.geode.management.internal.security.GfshCommandsSecurityTest.runCommandsPermittedAndForbiddenBy(GfshCommandsSecurityTest.java:164)
> at org.apache.geode.management.internal.security.GfshCommandsSecurityTest.testClusterReader(GfshCommandsSecurityTest.java:72)
> org.apache.geode.management.internal.security.GfshCommandsSecurityTest > testClusterWriter FAILED
> org.junit.ComparisonFailure: [destroy function --id=InterestCalculations] expected:<[110]> but was:<[415]>
> at sun.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method)
> at sun.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:62)
> at sun.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45)
> at org.apache.geode.management.internal.security.GfshCommandsSecurityTest.runCommandsPermittedAndForbiddenBy(GfshCommandsSecurityTest.java:164)
> at org.apache.geode.management.internal.security.GfshCommandsSecurityTest.testClusterWriter(GfshCommandsSecurityTest.java:78)
> org.apache.geode.management.internal.security.GfshCommandsSecurityTest > testClusterManager FAILED
> org.junit.ComparisonFailure: [destroy function --id=InterestCalculations] expected:<[110]> but was:<[415]>
> at sun.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method)
> at sun.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:62)
> at sun.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45)
> at org.apache.geode.management.internal.security.GfshCommandsSecurityTest.runCommandsPermittedAndForbiddenBy(GfshCommandsSecurityTest.java:164)
> at org.apache.geode.management.internal.security.GfshCommandsSecurityTest.testClusterManager(GfshCommandsSecurityTest.java:84)
> org.apache.geode.management.internal.security.GfshCommandsSecurityTest > testDataReader FAILED
> org.junit.ComparisonFailure: [destroy function --id=InterestCalculations] expected:<[110]> but was:<[415]>
> at sun.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method)
> at sun.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:62)
> at sun.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45)
> at org.apache.geode.management.internal.security.GfshCommandsSecurityTest.runCommandsPermittedAndForbiddenBy(GfshCommandsSecurityTest.java:164)
> at org.apache.geode.management.internal.security.GfshCommandsSecurityTest.testDataReader(GfshCommandsSecurityTest.java:90)
> org.apache.geode.management.internal.security.GfshCommandsSecurityTest > testRegionAManager FAILED
> org.junit.ComparisonFailure: [destroy function --id=InterestCalculations] expected:<[110]> but was:<[415]>
> at sun.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method)
> at sun.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:62)
> at sun.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45)
> at org.apache.geode.management.internal.security.GfshCommandsSecurityTest.runCommandsPermittedAndForbiddenBy(GfshCommandsSecurityTest.java:164)
> at org.apache.geode.management.internal.security.GfshCommandsSecurityTest.testRegionAManager(GfshCommandsSecurityTest.java:120)
> org.apache.geode.management.internal.security.GfshCommandsSecurityTest > testDataWriter FAILED
> org.junit.ComparisonFailure: [destroy function --id=InterestCalculations] expected:<[110]> but was:<[415]>
> at sun.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method)
> at sun.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:62)
> at sun.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45)
> at org.apache.geode.management.internal.security.GfshCommandsSecurityTest.runCommandsPermittedAndForbiddenBy(GfshCommandsSecurityTest.java:164)
> at org.apache.geode.management.internal.security.GfshCommandsSecurityTest.testDataWriter(GfshCommandsSecurityTest.java:96)
> org.apache.geode.codeAnalysis.AnalyzeSerializablesJUnitTest > testSerializables FAILED
> java.lang.AssertionError: New or moved classes----------------------------------------
> org/apache/geode/internal/cache/snapshot/ParallelSnapshotFileMapper,true,1
> If the class is not persisted or sent over the wire add it to the file
> /tmp/build/ae3c03f4/gemfire/open/geode-core/src/test/resources/org/apache/geode/codeAnalysis/excludedClasses.txt
> Otherwise if this doesn't break backward compatibility, copy the file
> /tmp/build/ae3c03f4/geode/geode-core/build/integrationTest/actualSerializables.dat to
> /tmp/build/ae3c03f4/gemfire/open/geode-core/src/test/resources/org/apache/geode/codeAnalysis/sanctionedSerializables.txt.
> at org.apache.geode.codeAnalysis.AnalyzeSerializablesJUnitTest.testSerializables(AnalyzeSerializablesJUnitTest.java:150)
> 3715 tests completed, 13 failed, 140 skipped
> :geode-core:integrationTest FAILED
> {noformat}
> {noformat}
> :geode-web:integrationTest
> org.apache.geode.management.internal.security.GfshCommandsOverHttpSecurityTest > testRegionAReader FAILED
> org.junit.ComparisonFailure: [destroy function --id=InterestCalculations] expected:<[110]> but was:<[415]>
> org.apache.geode.management.internal.security.GfshCommandsOverHttpSecurityTest > testRegionAWriter FAILED
> org.junit.ComparisonFailure: [destroy function --id=InterestCalculations] expected:<[110]> but was:<[415]>
> org.apache.geode.management.internal.security.GfshCommandsOverHttpSecurityTest > testClusterReader FAILED
> org.junit.ComparisonFailure: [destroy function --id=InterestCalculations] expected:<[110]> but was:<[415]>
> org.apache.geode.management.internal.security.GfshCommandsOverHttpSecurityTest > testClusterWriter FAILED
> org.junit.ComparisonFailure: [destroy function --id=InterestCalculations] expected:<[110]> but was:<[415]>
> org.apache.geode.management.internal.security.GfshCommandsOverHttpSecurityTest > testClusterManager FAILED
> org.junit.ComparisonFailure: [destroy function --id=InterestCalculations] expected:<[110]> but was:<[415]>
> org.apache.geode.management.internal.security.GfshCommandsOverHttpSecurityTest > testDataReader FAILED
> org.junit.ComparisonFailure: [destroy function --id=InterestCalculations] expected:<[110]> but was:<[415]>
> org.apache.geode.management.internal.security.GfshCommandsOverHttpSecurityTest > testRegionAManager FAILED
> org.junit.ComparisonFailure: [destroy function --id=InterestCalculations] expected:<[110]> but was:<[415]>
> org.apache.geode.management.internal.security.GfshCommandsOverHttpSecurityTest > testDataWriter FAILED
> org.junit.ComparisonFailure: [destroy function --id=InterestCalculations] expected:<[110]> but was:<[415]>
> 30 tests completed, 8 failed
> :geode-web:integrationTest FAILED
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)