You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2022/09/26 10:59:35 UTC

[GitHub] [beam] bullet03 opened a new pull request, #23369: [Website] fix navbar footer overlap

bullet03 opened a new pull request, #23369:
URL: https://github.com/apache/beam/pull/23369

   Resolves #22698
   - add div to create space between footer and body
   ------------------------
   before:
   ![before_navbar](https://user-images.githubusercontent.com/61748758/192259393-a5740eb5-91d8-4234-a70d-f6139fd5dcfd.JPG)
   after:
   ![after_navbar](https://user-images.githubusercontent.com/61748758/192259415-1f849da7-52cf-4721-bc32-10d663d3030d.JPG)
   ------------------------
   
   Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
   
    - [ ] [**Choose reviewer(s)**](https://beam.apache.org/contribute/#make-your-change) and mention them in a comment (`R: @username`).
    - [ ] Mention the appropriate issue in your description (for example: `addresses #123`), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment `fixes #<ISSUE NUMBER>` instead.
    - [ ] Update `CHANGES.md` with noteworthy changes.
    - [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
   
   See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://beam.apache.org/contribute/get-started-contributing/#make-the-reviewers-job-easier).
   
   To check the build health, please visit [https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md)
   
   GitHub Actions Tests Status (on master branch)
   ------------------------------------------------------------------------------------------------
   [![Build python source distribution and wheels](https://github.com/apache/beam/workflows/Build%20python%20source%20distribution%20and%20wheels/badge.svg?branch=master&event=schedule)](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
   [![Python tests](https://github.com/apache/beam/workflows/Python%20tests/badge.svg?branch=master&event=schedule)](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
   [![Java tests](https://github.com/apache/beam/workflows/Java%20Tests/badge.svg?branch=master&event=schedule)](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
   [![Go tests](https://github.com/apache/beam/workflows/Go%20tests/badge.svg?branch=master&event=schedule)](https://github.com/apache/beam/actions?query=workflow%3A%22Go+tests%22+branch%3Amaster+event%3Aschedule)
   
   See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] bullet03 commented on pull request #23369: [Website] fix navbar footer overlap

Posted by GitBox <gi...@apache.org>.
bullet03 commented on PR #23369:
URL: https://github.com/apache/beam/pull/23369#issuecomment-1265031075

   @aromanenko-dev, could you, please help with merge? PR was approved.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] bullet03 commented on pull request #23369: [Website] fix navbar footer overlap

Posted by GitBox <gi...@apache.org>.
bullet03 commented on PR #23369:
URL: https://github.com/apache/beam/pull/23369#issuecomment-1271152680

   @aromanenko-dev, sorry for bothering.
   The PR was merged 3 days ago, but changes are still not present on prod https://beam.apache.org/documentation/sdks/python-dependencies/. Could you kindly help me with the issue?
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] AlyaBoiko commented on pull request #23369: [Website] fix navbar footer overlap

Posted by GitBox <gi...@apache.org>.
AlyaBoiko commented on PR #23369:
URL: https://github.com/apache/beam/pull/23369#issuecomment-1260444828

   Verified, works as expected. Reviewed and tested by QA


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] bullet03 commented on pull request #23369: [Website] fix navbar footer overlap

Posted by GitBox <gi...@apache.org>.
bullet03 commented on PR #23369:
URL: https://github.com/apache/beam/pull/23369#issuecomment-1273462524

   > @bullet03 Jenkins job issue is resolved. So, do you see your website changes published now?
   
   yes, it's perfect, Thank you so much!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] bullet03 commented on pull request #23369: [Website] fix navbar footer overlap

Posted by GitBox <gi...@apache.org>.
bullet03 commented on PR #23369:
URL: https://github.com/apache/beam/pull/23369#issuecomment-1263929110

   @pcoet, could you, please help with review of PR?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] aromanenko-dev commented on pull request #23369: [Website] fix navbar footer overlap

Posted by GitBox <gi...@apache.org>.
aromanenko-dev commented on PR #23369:
URL: https://github.com/apache/beam/pull/23369#issuecomment-1273333300

   @bullet03 Jenkins job issue is resolved. So, do you see your website changes published now?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] bullet03 commented on pull request #23369: [Website] fix navbar footer overlap

Posted by GitBox <gi...@apache.org>.
bullet03 commented on PR #23369:
URL: https://github.com/apache/beam/pull/23369#issuecomment-1264333132

   > The changes look good, but I can't repro the original problem at https://beam.apache.org/documentation/sdks/python-dependencies/. No sure why... But thanks for working on this!
   
   Thank you. Not sure exactly, but the reason might be that the screen resolution was too narrow or too wide (then the bug can't be reporoduced) . Here is my resolution with bug being reproduced: 1200*1020px
   ![1](https://user-images.githubusercontent.com/61748758/193405938-1a4f6da7-4bb7-4f81-bba3-d4c16acdcf75.JPG)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] aromanenko-dev commented on pull request #23369: [Website] fix navbar footer overlap

Posted by GitBox <gi...@apache.org>.
aromanenko-dev commented on PR #23369:
URL: https://github.com/apache/beam/pull/23369#issuecomment-1271336211

   @bullet03 It looks that there is an issue with running [beam_PostCommit_Website_Publish](https://ci-beam.apache.org/job/beam_PostCommit_Website_Publish/) job that publishes Beam website into asf-site branch for hosting. Let me find out the reason and fix it.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org