You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by GitBox <gi...@apache.org> on 2021/06/04 20:30:20 UTC

[GitHub] [maven-checkstyle-plugin] bmarwell commented on a change in pull request #47: [MCHECKSTYLE-401] - NullPointerException in Violation class

bmarwell commented on a change in pull request #47:
URL: https://github.com/apache/maven-checkstyle-plugin/pull/47#discussion_r645832837



##########
File path: src/main/java/org/apache/maven/plugins/checkstyle/Violation.java
##########
@@ -196,10 +196,10 @@ public boolean equals( Object other )
       return false;
     }
     Violation violation = ( Violation ) other;
-    return line.equals( violation.line )
+    return Objects.equals( line, violation.line )

Review comment:
       Can confirm it is running through this line.
   ![2021-06-04T22:28:41_0001_screenshot](https://user-images.githubusercontent.com/1413391/120859363-63768a00-c584-11eb-9fda-e46974ccf5d7.png)
   




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org