You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by zh...@apache.org on 2021/12/27 01:42:16 UTC
[dolphinscheduler] branch dev updated: [Feature][UI Next] Update card component props. (#7635)
This is an automated email from the ASF dual-hosted git repository.
zhongjiajie pushed a commit to branch dev
in repository https://gitbox.apache.org/repos/asf/dolphinscheduler.git
The following commit(s) were added to refs/heads/dev by this push:
new 36dd437 [Feature][UI Next] Update card component props. (#7635)
36dd437 is described below
commit 36dd43737764a2e81875ca2f7b0831cc4b5709dc
Author: songjianet <17...@qq.com>
AuthorDate: Mon Dec 27 09:42:11 2021 +0800
[Feature][UI Next] Update card component props. (#7635)
---
.../src/components/card/index.tsx | 13 ++++++-------
.../src/components/card/types.ts | 22 ----------------------
.../src/components/chart/index.ts | 7 +------
3 files changed, 7 insertions(+), 35 deletions(-)
diff --git a/dolphinscheduler-ui-next/src/components/card/index.tsx b/dolphinscheduler-ui-next/src/components/card/index.tsx
index 357f973..daaea82 100644
--- a/dolphinscheduler-ui-next/src/components/card/index.tsx
+++ b/dolphinscheduler-ui-next/src/components/card/index.tsx
@@ -15,21 +15,20 @@
* limitations under the License.
*/
-import { defineComponent, defineProps } from 'vue'
+import { defineComponent, PropType } from 'vue'
import { NCard } from 'naive-ui'
-import Props from '@/components/card/types'
const headerStyle = {
borderBottom: '1px solid var(--border-color)',
}
+const props = {
+ title: String as PropType<string>,
+}
+
const Card = defineComponent({
name: 'Card',
- setup() {
- const props = defineProps<Props>()
-
- return { ...props }
- },
+ props,
render() {
const { title, $slots } = this
return (
diff --git a/dolphinscheduler-ui-next/src/components/card/types.ts b/dolphinscheduler-ui-next/src/components/card/types.ts
deleted file mode 100644
index f6f526f..0000000
--- a/dolphinscheduler-ui-next/src/components/card/types.ts
+++ /dev/null
@@ -1,22 +0,0 @@
-/*
- * Licensed to the Apache Software Foundation (ASF) under one or more
- * contributor license agreements. See the NOTICE file distributed with
- * this work for additional information regarding copyright ownership.
- * The ASF licenses this file to You under the Apache License, Version 2.0
- * (the "License"); you may not use this file except in compliance with
- * the License. You may obtain a copy of the License at
- *
- * http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing, software
- * distributed under the License is distributed on an "AS IS" BASIS,
- * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- * See the License for the specific language governing permissions and
- * limitations under the License.
- */
-
-interface Props {
- title: string
-}
-
-export default Props
diff --git a/dolphinscheduler-ui-next/src/components/chart/index.ts b/dolphinscheduler-ui-next/src/components/chart/index.ts
index 2dac9de..a2ff601 100644
--- a/dolphinscheduler-ui-next/src/components/chart/index.ts
+++ b/dolphinscheduler-ui-next/src/components/chart/index.ts
@@ -15,12 +15,7 @@
* limitations under the License.
*/
-import {
- getCurrentInstance,
- onMounted,
- onBeforeUnmount,
- watch,
-} from 'vue'
+import { getCurrentInstance, onMounted, onBeforeUnmount, watch } from 'vue'
import { useThemeStore } from '@/store/theme/theme'
import { throttle } from 'echarts'
import { useI18n } from 'vue-i18n'