svn commit: r1128436 - in /subversion/trunk/subversion: include/private/svn_sqlite.h libsvn_wc/wc_db_private.h

[ju...@apache.org]

Author: julianfoad
Date: Fri May 27 19:53:59 2011
New Revision: 1128436

URL: http://svn.apache.org/viewvc?rev=1128436&view=rev
Log:
* subversion/include/private/svn_sqlite.h
  (svn_sqlite__open): Clarify the lifetime requirement of the 'statements'
    parameter.

* subversion/libsvn_wc/wc_db_private.h
  (svn_wc__db_util_open_db): Same for the 'my_statements' parameter.

Modified:
    subversion/trunk/subversion/include/private/svn_sqlite.h
    subversion/trunk/subversion/libsvn_wc/wc_db_private.h

Modified: subversion/trunk/subversion/include/private/svn_sqlite.h
URL: http://svn.apache.org/viewvc/subversion/trunk/subversion/include/private/svn_sqlite.h?rev=1128436&r1=1128435&r2=1128436&view=diff
==============================================================================
--- subversion/trunk/subversion/include/private/svn_sqlite.h (original)
+++ subversion/trunk/subversion/include/private/svn_sqlite.h Fri May 27 19:53:59 2011
@@ -113,8 +113,9 @@ svn_sqlite__set_schema_version(svn_sqlit
    temporary allocations are made in SCRATCH_POOL.
 
    STATEMENTS is an array of strings which may eventually be executed, the
-   last element of which should be NULL.  These strings are not duplicated
-   internally, and should have a lifetime at least as long as RESULT_POOL.
+   last element of which should be NULL.  These strings and the array itself
+   are not duplicated internally, and should have a lifetime at least as long
+   as RESULT_POOL.
    STATEMENTS itself may be NULL, in which case it has no impact.
    See svn_sqlite__get_statement() for how these strings are used.
 

Modified: subversion/trunk/subversion/libsvn_wc/wc_db_private.h
URL: http://svn.apache.org/viewvc/subversion/trunk/subversion/libsvn_wc/wc_db_private.h?rev=1128436&r1=1128435&r2=1128436&view=diff
==============================================================================
--- subversion/trunk/subversion/libsvn_wc/wc_db_private.h (original)
+++ subversion/trunk/subversion/libsvn_wc/wc_db_private.h Fri May 27 19:53:59 2011
@@ -161,8 +161,10 @@ svn_wc__db_util_fetch_wc_id(apr_int64_t 
  * SMODE is passed to svn_sqlite__open().
  *
  * Register MY_STATEMENTS, or if that is null, the default set of WC DB
- * statements, as the set of statements to be prepared now and
- * executed later.  See svn_sqlite__open() for details. */
+ * statements, as the set of statements to be prepared now and executed
+ * later.  MY_STATEMENTS (the strings and the array itself) is not duplicated
+ * internally, and should have a lifetime at least as long as RESULT_POOL.
+ * See svn_sqlite__open() for details. */
 svn_error_t *
 svn_wc__db_util_open_db(svn_sqlite__db_t **sdb,
                         const char *dir_abspath,