[jira] [Commented] (HBASE-7479) Remove VersionedProtocol and ProtocolSignature from RPC

["stack (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HBASE-7479?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13546651#comment-13546651 ] 

stack commented on HBASE-7479:
------------------------------

Commit message:

M hbase-protocol/src/main/protobuf/RPC.proto b/hbase-protocol/src/main/protobuf/RPC.proto
  Remove the clientProtocolVersion field.  Unused.
A hbase-server/src/main/java/org/apache/hadoop/hbase/IpcProtocol.java
  Added a marker Interface to use as VersionedProtocol was used, as the
  Interface all protocols implemented.  Needed for now otherwise would
  have to refactor loads of code.  It is up here at top level rather
  than down in ipc because the server protocols are up here at this
  level and its odd have super packages implement Interfaces that
  are in subpackages.
M hbase-server/src/main/java/org/apache/hadoop/hbase/MasterAdminProtocol.java
  Remove the repetition of the content of BlockingInterface.  True, there is
  nice javadoc in the reptition here but doc belongs in the proto files.
  Remove VersionedProtocol and implement IpcProtocol instead.
M hbase-server/src/main/java/org/apache/hadoop/hbase/MasterProtocol.java
  Ditto
M hbase-server/src/main/java/org/apache/hadoop/hbase/RegionServerStatusProtocol.java
M hbase-server/src/main/java/org/apache/hadoop/hbase/client/AdminProtocol.java
M hbase-server/src/main/java/org/apache/hadoop/hbase/client/ClientProtocol.java
  Implement IpcProtocol and remove VersionedProtocol
M hbase-server/src/main/java/org/apache/hadoop/hbase/client/HConnectionManager.java
  Remove VersionedProtocol and implement IpcProtocol instead.
  Don't pass 'version' when getting clients and servers and protocols.
M hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/HBaseClient.java
  Remove unused call method  Refer to IpcProtocol rather than VP.
M hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/HBaseClientRPC.java
  Remove taking client version from methods.  Use IpcProtocol instead of VP
M hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/HBaseServer.java
  Ditto
M hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/HBaseServerRPC.java
  Ditoo and remove proxy; there is no proxying serverside.
  Remove an unused getServer method.
M hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/ProtobufRpcClientEngine.java
  Use IpcProtocol instead of VP  Removed the PROTOCOL_VERSION Map.
  Not needed any more.
M hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/ProtobufRpcServerEngine.java
  Remove clientVersion.  Not used.  Use IpcP instead of VP
D hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/ProtocolSignature.java
D hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/VersionedProtocol.java
  Remove.  Not used any more.
M  hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/RequestContext.java
  Use IpcP instead of VP
M  base-server/src/main/java/org/apache/hadoop/hbase/ipc/RpcClientEngine.java
  Use IpcP instead of VP
M  hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/RpcServer.java
  Comments.
M hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/RpcServerEngine.java
  Use IpcP instead of VP
M hbase-server/src/main/java/org/apache/hadoop/hbase/master/HMaster.java
M hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java
M hbase-server/src/test/java/org/apache/hadoop/hbase/master/MockRegionServer.java
M /hbase-server/src/test/java/org/apache/hadoop/hbase/security/token/TestTokenAuthentication.java
  Remove no longer needed methods from VersionedProtocol.
M hbase-server/src/test/java/org/apache/hadoop/hbase/HBaseTestingUtility.java
  Fix eclipse warning.
M hbase-server/src/test/java/org/apache/hadoop/hbase/ipc/RandomTimeoutRpcEngine.java
M hbase-server/src/test/java/org/apache/hadoop/hbase/ipc/TestDelayedRpc.java
M hbase-server/src/test/java/org/apache/hadoop/hbase/ipc/TestIPC.java
M hbase-server/src/test/java/org/apache/hadoop/hbase/ipc/TestProtoBufRpc.java
M hbase-server/src/test/java/org/apache/hadoop/hbase/master/TestHMasterRPCException.java
  Use IpcP instead of VP
M hbase-server/src/test/protobuf/test_delayed_rpc.proto
  Turn off flag that asks for generation of Service (Service not defined)
                
> Remove VersionedProtocol and ProtocolSignature from RPC
> -------------------------------------------------------
>
>                 Key: HBASE-7479
>                 URL: https://issues.apache.org/jira/browse/HBASE-7479
>             Project: HBase
>          Issue Type: Task
>          Components: IPC/RPC
>            Reporter: stack
>            Assignee: stack
>            Priority: Blocker
>             Fix For: 0.96.0
>
>         Attachments: 7479.txt
>
>
> Replace with an innocuous "Protocol" Interface for now.  Will minimize changes doing a replacement.  Implication is that we are no longer going to do special "handling" based off protocol version.  See "Handling protocol versions" - http://search-hadoop.com/m/6k7GUM028E/v=threaded thread and HBASE-6521 for background.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira