[GitHub] graceguo-supercat opened a new pull request #5031: Dashboard initial page load logging with tabs

[GitBox <gi...@apache.org>]

graceguo-supercat opened a new pull request #5031: Dashboard initial page load logging with tabs
URL: https://github.com/apache/incubator-superset/pull/5031
 
 
   This PR is trying to fix the logging issue for dashboard with tabs.
   
   In old dashboard, we fetch and show all charts, and after all charts are ready we will log a timestamp as dashboard fully-loaded time. In new dashboard v2, we supports tabs, which means some charts are not fetched until user click open another tab. The old logging function will not be triggered in the tabbed dashboard.
   
   So my current solution is, traverse through the new dashboard layout data (map), and get all charts belongs to first tab (if there no tab, just all charts in the dashboard). once all these charts are fetched and rendered, front-end send timestamp.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org