You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dubbo.apache.org by hy...@apache.org on 2019/08/31 13:32:06 UTC
[dubbo] branch master updated: Optimization: remove unnecessary
String operations (#4964)
This is an automated email from the ASF dual-hosted git repository.
hyunkun pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/dubbo.git
The following commit(s) were added to refs/heads/master by this push:
new e51c24e Optimization: remove unnecessary String operations (#4964)
e51c24e is described below
commit e51c24e93e7d08b01eb74f1e0ea286fe0e545419
Author: jimin <sl...@163.com>
AuthorDate: Sat Aug 31 21:31:43 2019 +0800
Optimization: remove unnecessary String operations (#4964)
---
.../java/org/apache/dubbo/common/io/UnsafeStringWriter.java | 2 +-
.../main/java/org/apache/dubbo/common/utils/StringUtils.java | 4 ++--
.../org/apache/dubbo/remoting/telnet/support/TelnetUtils.java | 2 +-
.../remoting/transport/netty4/logging/MessageFormatter.java | 10 +++++-----
.../main/java/org/apache/dubbo/rpc/support/AccessLogData.java | 4 ++--
.../java/org/apache/dubbo/rpc/protocol/thrift/ThriftUtils.java | 8 ++++----
6 files changed, 15 insertions(+), 15 deletions(-)
diff --git a/dubbo-common/src/main/java/org/apache/dubbo/common/io/UnsafeStringWriter.java b/dubbo-common/src/main/java/org/apache/dubbo/common/io/UnsafeStringWriter.java
index 47e9a3a..a27f77d 100644
--- a/dubbo-common/src/main/java/org/apache/dubbo/common/io/UnsafeStringWriter.java
+++ b/dubbo-common/src/main/java/org/apache/dubbo/common/io/UnsafeStringWriter.java
@@ -66,7 +66,7 @@ public class UnsafeStringWriter extends Writer {
@Override
public void write(String str, int off, int len) {
- mBuffer.append(str.substring(off, off + len));
+ mBuffer.append(str, off, off + len);
}
@Override
diff --git a/dubbo-common/src/main/java/org/apache/dubbo/common/utils/StringUtils.java b/dubbo-common/src/main/java/org/apache/dubbo/common/utils/StringUtils.java
index a8d22ad..28aca4a 100644
--- a/dubbo-common/src/main/java/org/apache/dubbo/common/utils/StringUtils.java
+++ b/dubbo-common/src/main/java/org/apache/dubbo/common/utils/StringUtils.java
@@ -336,7 +336,7 @@ public final class StringUtils {
increase *= max < 0 ? 16 : max > 64 ? 64 : max;
final StringBuilder buf = new StringBuilder(text.length() + increase);
while (end != INDEX_NOT_FOUND) {
- buf.append(text.substring(start, end)).append(replacement);
+ buf.append(text, start, end).append(replacement);
start = end + replLength;
if (--max == 0) {
break;
@@ -774,7 +774,7 @@ public final class StringUtils {
if (buf == null) {
buf = new StringBuilder();
if (i > 0) {
- buf.append(camelName.substring(0, i));
+ buf.append(camelName, 0, i);
}
}
if (i > 0) {
diff --git a/dubbo-remoting/dubbo-remoting-api/src/main/java/org/apache/dubbo/remoting/telnet/support/TelnetUtils.java b/dubbo-remoting/dubbo-remoting-api/src/main/java/org/apache/dubbo/remoting/telnet/support/TelnetUtils.java
index 1d7f52e..50a06c9 100644
--- a/dubbo-remoting/dubbo-remoting-api/src/main/java/org/apache/dubbo/remoting/telnet/support/TelnetUtils.java
+++ b/dubbo-remoting/dubbo-remoting-api/src/main/java/org/apache/dubbo/remoting/telnet/support/TelnetUtils.java
@@ -131,7 +131,7 @@ public class TelnetUtils {
// }
}
- rowbuf.append(cell.substring(cell.length() - remaing, cell.length() - remaing + 1));
+ rowbuf.append(cell, cell.length() - remaing, cell.length() - remaing + 1);
remaing--;
}
int pad = widths[j] - cell.length();
diff --git a/dubbo-remoting/dubbo-remoting-netty4/src/main/java/org/apache/dubbo/remoting/transport/netty4/logging/MessageFormatter.java b/dubbo-remoting/dubbo-remoting-netty4/src/main/java/org/apache/dubbo/remoting/transport/netty4/logging/MessageFormatter.java
index c7cde8b..808600e 100644
--- a/dubbo-remoting/dubbo-remoting-netty4/src/main/java/org/apache/dubbo/remoting/transport/netty4/logging/MessageFormatter.java
+++ b/dubbo-remoting/dubbo-remoting-netty4/src/main/java/org/apache/dubbo/remoting/transport/netty4/logging/MessageFormatter.java
@@ -192,7 +192,7 @@ final class MessageFormatter {
throwableCandidate);
} else { // add the tail string which contains no variables and return
// the result.
- sbuf.append(messagePattern.substring(i, messagePattern.length()));
+ sbuf.append(messagePattern.substring(i));
return new FormattingTuple(sbuf.toString(), argArray,
throwableCandidate);
}
@@ -200,27 +200,27 @@ final class MessageFormatter {
if (isEscapedDelimeter(messagePattern, j)) {
if (!isDoubleEscaped(messagePattern, j)) {
l--; // DELIM_START was escaped, thus should not be incremented
- sbuf.append(messagePattern.substring(i, j - 1));
+ sbuf.append(messagePattern, i, j - 1);
sbuf.append(DELIM_START);
i = j + 1;
} else {
// The escape character preceding the delimiter start is
// itself escaped: "abc x:\\{}"
// we have to consume one backward slash
- sbuf.append(messagePattern.substring(i, j - 1));
+ sbuf.append(messagePattern, i, j - 1);
deeplyAppendParameter(sbuf, argArray[l], new HashMap<Object[], Void>());
i = j + 2;
}
} else {
// normal case
- sbuf.append(messagePattern.substring(i, j));
+ sbuf.append(messagePattern, i, j);
deeplyAppendParameter(sbuf, argArray[l], new HashMap<Object[], Void>());
i = j + 2;
}
}
}
// append the characters following the last {} pair.
- sbuf.append(messagePattern.substring(i, messagePattern.length()));
+ sbuf.append(messagePattern.substring(i));
if (l < argArray.length - 1) {
return new FormattingTuple(sbuf.toString(), argArray, throwableCandidate);
} else {
diff --git a/dubbo-rpc/dubbo-rpc-api/src/main/java/org/apache/dubbo/rpc/support/AccessLogData.java b/dubbo-rpc/dubbo-rpc-api/src/main/java/org/apache/dubbo/rpc/support/AccessLogData.java
index b7d1096..e9ff358 100644
--- a/dubbo-rpc/dubbo-rpc-api/src/main/java/org/apache/dubbo/rpc/support/AccessLogData.java
+++ b/dubbo-rpc/dubbo-rpc-api/src/main/java/org/apache/dubbo/rpc/support/AccessLogData.java
@@ -204,14 +204,14 @@ public final class AccessLogData {
.append(" - ");
String group = get(GROUP) != null ? get(GROUP).toString() : "";
- if (StringUtils.isNotEmpty(group.toString())) {
+ if (StringUtils.isNotEmpty(group)) {
sn.append(group).append("/");
}
sn.append(get(SERVICE));
String version = get(VERSION) != null ? get(VERSION).toString() : "";
- if (StringUtils.isNotEmpty(version.toString())) {
+ if (StringUtils.isNotEmpty(version)) {
sn.append(":").append(version);
}
diff --git a/dubbo-rpc/dubbo-rpc-thrift/src/main/java/org/apache/dubbo/rpc/protocol/thrift/ThriftUtils.java b/dubbo-rpc/dubbo-rpc-thrift/src/main/java/org/apache/dubbo/rpc/protocol/thrift/ThriftUtils.java
index da4408b..cbba6a9 100644
--- a/dubbo-rpc/dubbo-rpc-thrift/src/main/java/org/apache/dubbo/rpc/protocol/thrift/ThriftUtils.java
+++ b/dubbo-rpc/dubbo-rpc-thrift/src/main/java/org/apache/dubbo/rpc/protocol/thrift/ThriftUtils.java
@@ -35,7 +35,7 @@ public class ThriftUtils {
if (index > 0) {
return new StringBuilder(32)
- .append(serviceName.substring(0, index + 1))
+ .append(serviceName, 0, index + 1)
.append("$__")
.append(serviceName.substring(index + 1))
.append("Stub$")
@@ -62,7 +62,7 @@ public class ThriftUtils {
if (index > 0) {
return new StringBuilder(32)
- .append(serviceName.substring(0, index + 1))
+ .append(serviceName, 0, index + 1)
.append("$__")
.append(serviceName.substring(index + 1))
.append("Stub$")
@@ -106,7 +106,7 @@ public class ThriftUtils {
if (index > 0) {
return new StringBuilder(32)
- .append(serviceName.substring(0, index + 1))
+ .append(serviceName, 0, index + 1)
.append(methodName)
.append("_args")
.toString();
@@ -122,7 +122,7 @@ public class ThriftUtils {
if (index > 0) {
return new StringBuilder(32)
- .append(serviceName.substring(0, index + 1))
+ .append(serviceName, 0, index + 1)
.append(methodName)
.append("_result")
.toString();