[GitHub] [phoenix] kadirozde commented on pull request #1506: PHOENIX-6761 : Phoenix Client Side Metadata Caching Improvement

[GitBox <gi...@apache.org>]

kadirozde commented on PR #1506:
URL: https://github.com/apache/phoenix/pull/1506#issuecomment-1270473150

   > @gjacoby126, This PR should not degrade the thread safety across connections but improves thread safety within a connection although it was not required. The previous implementation used ReadWriteLock to protect its cache operation (see PSynchronizedMetaData) as the underlying map used for the table cache was not thread safe and also it required multiple steps to update the table cache. Since we replaced the table cache with a tread safe cache (i.e., Guava), reduced the number of steps in a table cache operation to a single step, and also replaced the underlying maps for Schemas and Functions with ConcurrentHapMap, we removed PSynchronizedMetaData. @palashc, as far as I know there is no currency issue left to address. It will be good to check again to make sure we are good.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@phoenix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org