You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by "gnodet (via GitHub)" <gi...@apache.org> on 2024/05/07 04:36:36 UTC
[PR] Add @Serial annotation [camel]
gnodet opened a new pull request, #14065:
URL: https://github.com/apache/camel/pull/14065
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add @Serial annotation [camel]
Posted by "davsclaus (via GitHub)" <gi...@apache.org>.
davsclaus commented on PR #14065:
URL: https://github.com/apache/camel/pull/14065#issuecomment-2097737657
not as much anymore - we do not recommend serializing java objects and sending them over the wire - a few old components still have an option to do that like JMS with transferExchange=true|false
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add @Serial annotation [camel]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #14065:
URL: https://github.com/apache/camel/pull/14065#issuecomment-2097429651
:star2: Thank you for your contribution to the Apache Camel project! :star2:
:robot: CI automation will test this PR automatically.
:camel: Apache Camel Committers, please review the following items:
* First-time contributors **require MANUAL approval** for the GitHub Actions to run
* You can use the command `/component-test (camel-)component-name1 (camel-)component-name2..` to request a test from the test bot.
* You can label PRs using `build-all`, `build-dependents`, `skip-tests` and `test-dependents` to fine-tune the checks executed by this PR.
* Build and test logs are available in the Summary page. **Only** [Apache Camel committers](https://camel.apache.org/community/team/#committers) have access to the summary.
* :warning: Be careful when sharing logs. Review their contents before sharing them publicly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add @Serial annotation [camel]
Posted by "orpiske (via GitHub)" <gi...@apache.org>.
orpiske commented on PR #14065:
URL: https://github.com/apache/camel/pull/14065#issuecomment-2097723449
@gnodet @davsclaus @oscerd sorry for my ignorance here ... serialization has never been my thing, so: is this still something we need?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add @Serial annotation [camel]
Posted by "gnodet (via GitHub)" <gi...@apache.org>.
gnodet commented on PR #14065:
URL: https://github.com/apache/camel/pull/14065#issuecomment-2097739005
> @gnodet @davsclaus @oscerd sorry for my ignorance here ... serialization has never been my thing, so: is this still something we need?
No, this is a compile time annotation which helps detecting issues in serialization related code. This is very similar to `@Override` which is not required, but helps the compiler raising issues in case of problems.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add @Serial annotation [camel]
Posted by "orpiske (via GitHub)" <gi...@apache.org>.
orpiske commented on PR #14065:
URL: https://github.com/apache/camel/pull/14065#issuecomment-2097761726
> not as much anymore - we do not recommend serializing java objects and sending them over the wire - a few old components still have an option to do that like JMS with transferExchange=true|false
Oh, ok. Now I got it. I think we can't remove these without breaking backwards compatibility.
Thanks for the explanation @gnodet and @davsclaus
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add @Serial annotation [camel]
Posted by "gnodet (via GitHub)" <gi...@apache.org>.
gnodet merged PR #14065:
URL: https://github.com/apache/camel/pull/14065
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add @Serial annotation [camel]
Posted by "orpiske (via GitHub)" <gi...@apache.org>.
orpiske commented on PR #14065:
URL: https://github.com/apache/camel/pull/14065#issuecomment-2097741157
@gnodet @davsclaus I wonder if we should just go ahead and remove all this serialization stuff. If it's something old, unused (and very likely unsafe), I don't see the point of having this in the code base.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org