You are viewing a plain text version of this content. The canonical link for it is here.
Posted to mapreduce-issues@hadoop.apache.org by "Devaraj K (JIRA)" <ji...@apache.org> on 2011/05/31 07:57:49 UTC
[jira] [Created] (MAPREDUCE-2549) Potential resource leaks in
HadoopServer.java, RunOnHadoopWizard.java and Environment.java
Potential resource leaks in HadoopServer.java, RunOnHadoopWizard.java and Environment.java
------------------------------------------------------------------------------------------
Key: MAPREDUCE-2549
URL: https://issues.apache.org/jira/browse/MAPREDUCE-2549
Project: Hadoop Map/Reduce
Issue Type: Bug
Components: contrib/eclipse-plugin, contrib/streaming
Affects Versions: 0.23.0
Reporter: Devaraj K
Assignee: Devaraj K
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-2549) Potential resource leaks in
HadoopServer.java, RunOnHadoopWizard.java and Environment.java
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-2549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13099150#comment-13099150 ]
Hadoop QA commented on MAPREDUCE-2549:
--------------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12493346/MAPREDUCE-2549-1.patch
against trunk revision .
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified tests.
Please justify why no new tests are needed for this patch.
Also please list what manual steps were performed to verify this patch.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
-1 findbugs. The patch appears to introduce 14 new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
-1 core tests. The patch failed these unit tests:
org.apache.hadoop.yarn.server.nodemanager.TestNMAuditLogger
+1 contrib tests. The patch passed contrib unit tests.
Test results: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/632//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/632//artifact/trunk/patchprocess/newPatchFindbugsWarningshadoop-mapreduce-client-hs.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/632//artifact/trunk/patchprocess/newPatchFindbugsWarningshadoop-mapreduce-client-shuffle.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/632//artifact/trunk/patchprocess/newPatchFindbugsWarningshadoop-mapreduce-client-common.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/632//artifact/trunk/patchprocess/newPatchFindbugsWarningshadoop-mapreduce-client-app.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/632//artifact/trunk/patchprocess/newPatchFindbugsWarningshadoop-mapreduce-client-jobclient.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/632//artifact/trunk/patchprocess/newPatchFindbugsWarningshadoop-mapreduce-client-core.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/632//artifact/trunk/patchprocess/newPatchFindbugsWarningshadoop-yarn-server-common.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/632//artifact/trunk/patchprocess/newPatchFindbugsWarningshadoop-yarn-server-resourcemanager.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/632//artifact/trunk/patchprocess/newPatchFindbugsWarningshadoop-yarn-server-nodemanager.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/632//artifact/trunk/patchprocess/newPatchFindbugsWarningshadoop-yarn-common.html
Findbugs warnings: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/632//artifact/trunk/patchprocess/newPatchFindbugsWarningshadoop-yarn-api.html
Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/632//console
This message is automatically generated.
> Potential resource leaks in HadoopServer.java, RunOnHadoopWizard.java and Environment.java
> ------------------------------------------------------------------------------------------
>
> Key: MAPREDUCE-2549
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-2549
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: contrib/eclipse-plugin, contrib/streaming
> Affects Versions: 0.23.0
> Reporter: Devaraj K
> Assignee: Devaraj K
> Fix For: 0.20.205.0, 0.23.0, 0.24.0
>
> Attachments: MAPREDUCE-2549-0[1].20.205.patch, MAPREDUCE-2549-1.patch, MAPREDUCE-2549.patch
>
>
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (MAPREDUCE-2549) Potential resource leaks in
HadoopServer.java, RunOnHadoopWizard.java and Environment.java
Posted by "Devaraj K (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-2549?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Devaraj K updated MAPREDUCE-2549:
---------------------------------
Fix Version/s: 0.24.0
0.20.205.0
Status: Patch Available (was: Open)
> Potential resource leaks in HadoopServer.java, RunOnHadoopWizard.java and Environment.java
> ------------------------------------------------------------------------------------------
>
> Key: MAPREDUCE-2549
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-2549
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: contrib/eclipse-plugin, contrib/streaming
> Affects Versions: 0.23.0
> Reporter: Devaraj K
> Assignee: Devaraj K
> Fix For: 0.20.205.0, 0.23.0, 0.24.0
>
> Attachments: MAPREDUCE-2549-0[1].20.205.patch, MAPREDUCE-2549-1.patch, MAPREDUCE-2549.patch
>
>
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-2549) Potential resource leaks in
HadoopServer.java, RunOnHadoopWizard.java and Environment.java
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-2549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13103896#comment-13103896 ]
Hudson commented on MAPREDUCE-2549:
-----------------------------------
Integrated in Hadoop-Hdfs-trunk #796 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk/796/])
Merge -r 1170285:1170286 from branch-0.20-security to trunk to fix MAPREDUCE-2549.
acmurthy : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1170288
Files :
* /hadoop/common/trunk/hadoop-mapreduce-project/src/contrib/eclipse-plugin/src/java/org/apache/hadoop/eclipse/server/HadoopServer.java
* /hadoop/common/trunk/hadoop-mapreduce-project/src/contrib/eclipse-plugin/src/java/org/apache/hadoop/eclipse/servers/RunOnHadoopWizard.java
* /hadoop/common/trunk/hadoop-mapreduce-project/src/contrib/streaming/src/java/org/apache/hadoop/streaming/Environment.java
> Potential resource leaks in HadoopServer.java, RunOnHadoopWizard.java and Environment.java
> ------------------------------------------------------------------------------------------
>
> Key: MAPREDUCE-2549
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-2549
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: contrib/eclipse-plugin, contrib/streaming
> Affects Versions: 0.23.0
> Reporter: Devaraj K
> Assignee: Devaraj K
> Fix For: 0.20.205.0
>
> Attachments: MAPREDUCE-2549-0[1].20.205.patch, MAPREDUCE-2549-1.patch, MAPREDUCE-2549.patch
>
>
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-2549) Potential resource leaks in
HadoopServer.java, RunOnHadoopWizard.java and Environment.java
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-2549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13043885#comment-13043885 ]
Hadoop QA commented on MAPREDUCE-2549:
--------------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12481347/MAPREDUCE-2549.patch
against trunk revision 1130994.
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified tests.
Please justify why no new tests are needed for this patch.
Also please list what manual steps were performed to verify this patch.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
-1 findbugs. The patch appears to introduce 1 new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
-1 core tests. The patch failed these core unit tests:
org.apache.hadoop.cli.TestMRCLI
+1 contrib tests. The patch passed contrib unit tests.
+1 system test framework. The patch passed system test framework compile.
Test results: https://builds.apache.org/hudson/job/PreCommit-MAPREDUCE-Build/342//testReport/
Findbugs warnings: https://builds.apache.org/hudson/job/PreCommit-MAPREDUCE-Build/342//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/hudson/job/PreCommit-MAPREDUCE-Build/342//console
This message is automatically generated.
> Potential resource leaks in HadoopServer.java, RunOnHadoopWizard.java and Environment.java
> ------------------------------------------------------------------------------------------
>
> Key: MAPREDUCE-2549
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-2549
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: contrib/eclipse-plugin, contrib/streaming
> Affects Versions: 0.23.0
> Reporter: Devaraj K
> Assignee: Devaraj K
> Fix For: 0.23.0
>
> Attachments: MAPREDUCE-2549.patch
>
>
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (MAPREDUCE-2549) Potential resource leaks in
HadoopServer.java, RunOnHadoopWizard.java and Environment.java
Posted by "Arun C Murthy (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-2549?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Arun C Murthy updated MAPREDUCE-2549:
-------------------------------------
Resolution: Fixed
Fix Version/s: (was: 0.24.0)
(was: 0.23.0)
Status: Resolved (was: Patch Available)
I just committed this. Thanks Devaraj!
> Potential resource leaks in HadoopServer.java, RunOnHadoopWizard.java and Environment.java
> ------------------------------------------------------------------------------------------
>
> Key: MAPREDUCE-2549
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-2549
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: contrib/eclipse-plugin, contrib/streaming
> Affects Versions: 0.23.0
> Reporter: Devaraj K
> Assignee: Devaraj K
> Fix For: 0.20.205.0
>
> Attachments: MAPREDUCE-2549-0[1].20.205.patch, MAPREDUCE-2549-1.patch, MAPREDUCE-2549.patch
>
>
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-2549) Potential resource leaks in
HadoopServer.java, RunOnHadoopWizard.java and Environment.java
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-2549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13103905#comment-13103905 ]
Hudson commented on MAPREDUCE-2549:
-----------------------------------
Integrated in Hadoop-Hdfs-0.23-Build #2 (See [https://builds.apache.org/job/Hadoop-Hdfs-0.23-Build/2/])
Merge -r 1170287:1170288 from trunk to branch-0.23 to fix MAPREDUCE-2549.
acmurthy : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1170289
Files :
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/eclipse-plugin/src/java/org/apache/hadoop/eclipse/server/HadoopServer.java
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/eclipse-plugin/src/java/org/apache/hadoop/eclipse/servers/RunOnHadoopWizard.java
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/src/contrib/streaming/src/java/org/apache/hadoop/streaming/Environment.java
> Potential resource leaks in HadoopServer.java, RunOnHadoopWizard.java and Environment.java
> ------------------------------------------------------------------------------------------
>
> Key: MAPREDUCE-2549
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-2549
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: contrib/eclipse-plugin, contrib/streaming
> Affects Versions: 0.23.0
> Reporter: Devaraj K
> Assignee: Devaraj K
> Fix For: 0.20.205.0
>
> Attachments: MAPREDUCE-2549-0[1].20.205.patch, MAPREDUCE-2549-1.patch, MAPREDUCE-2549.patch
>
>
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-2549) Potential resource leaks in
HadoopServer.java, RunOnHadoopWizard.java and Environment.java
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-2549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13103904#comment-13103904 ]
Hudson commented on MAPREDUCE-2549:
-----------------------------------
Integrated in Hadoop-Mapreduce-trunk-Commit #895 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/895/])
Merge -r 1170285:1170286 from branch-0.20-security to trunk to fix MAPREDUCE-2549.
acmurthy : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1170288
Files :
* /hadoop/common/trunk/hadoop-mapreduce-project/src/contrib/eclipse-plugin/src/java/org/apache/hadoop/eclipse/server/HadoopServer.java
* /hadoop/common/trunk/hadoop-mapreduce-project/src/contrib/eclipse-plugin/src/java/org/apache/hadoop/eclipse/servers/RunOnHadoopWizard.java
* /hadoop/common/trunk/hadoop-mapreduce-project/src/contrib/streaming/src/java/org/apache/hadoop/streaming/Environment.java
> Potential resource leaks in HadoopServer.java, RunOnHadoopWizard.java and Environment.java
> ------------------------------------------------------------------------------------------
>
> Key: MAPREDUCE-2549
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-2549
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: contrib/eclipse-plugin, contrib/streaming
> Affects Versions: 0.23.0
> Reporter: Devaraj K
> Assignee: Devaraj K
> Fix For: 0.20.205.0
>
> Attachments: MAPREDUCE-2549-0[1].20.205.patch, MAPREDUCE-2549-1.patch, MAPREDUCE-2549.patch
>
>
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (MAPREDUCE-2549) Potential resource leaks in
HadoopServer.java, RunOnHadoopWizard.java and Environment.java
Posted by "Devaraj K (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-2549?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Devaraj K updated MAPREDUCE-2549:
---------------------------------
Status: Patch Available (was: Open)
> Potential resource leaks in HadoopServer.java, RunOnHadoopWizard.java and Environment.java
> ------------------------------------------------------------------------------------------
>
> Key: MAPREDUCE-2549
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-2549
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: contrib/eclipse-plugin, contrib/streaming
> Affects Versions: 0.23.0
> Reporter: Devaraj K
> Assignee: Devaraj K
> Fix For: 0.20.205.0, 0.23.0, 0.24.0
>
> Attachments: MAPREDUCE-2549-0[1].20.205.patch, MAPREDUCE-2549-1.patch, MAPREDUCE-2549.patch
>
>
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (MAPREDUCE-2549) Potential resource leaks in
HadoopServer.java, RunOnHadoopWizard.java and Environment.java
Posted by "Devaraj K (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-2549?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Devaraj K updated MAPREDUCE-2549:
---------------------------------
Attachment: MAPREDUCE-2549.patch
> Potential resource leaks in HadoopServer.java, RunOnHadoopWizard.java and Environment.java
> ------------------------------------------------------------------------------------------
>
> Key: MAPREDUCE-2549
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-2549
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: contrib/eclipse-plugin, contrib/streaming
> Affects Versions: 0.23.0
> Reporter: Devaraj K
> Assignee: Devaraj K
> Attachments: MAPREDUCE-2549.patch
>
>
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-2549) Potential resource leaks in
HadoopServer.java, RunOnHadoopWizard.java and Environment.java
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-2549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13103893#comment-13103893 ]
Hudson commented on MAPREDUCE-2549:
-----------------------------------
Integrated in Hadoop-Common-trunk-Commit #883 (See [https://builds.apache.org/job/Hadoop-Common-trunk-Commit/883/])
Merge -r 1170285:1170286 from branch-0.20-security to trunk to fix MAPREDUCE-2549.
acmurthy : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1170288
Files :
* /hadoop/common/trunk/hadoop-mapreduce-project/src/contrib/eclipse-plugin/src/java/org/apache/hadoop/eclipse/server/HadoopServer.java
* /hadoop/common/trunk/hadoop-mapreduce-project/src/contrib/eclipse-plugin/src/java/org/apache/hadoop/eclipse/servers/RunOnHadoopWizard.java
* /hadoop/common/trunk/hadoop-mapreduce-project/src/contrib/streaming/src/java/org/apache/hadoop/streaming/Environment.java
> Potential resource leaks in HadoopServer.java, RunOnHadoopWizard.java and Environment.java
> ------------------------------------------------------------------------------------------
>
> Key: MAPREDUCE-2549
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-2549
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: contrib/eclipse-plugin, contrib/streaming
> Affects Versions: 0.23.0
> Reporter: Devaraj K
> Assignee: Devaraj K
> Fix For: 0.20.205.0
>
> Attachments: MAPREDUCE-2549-0[1].20.205.patch, MAPREDUCE-2549-1.patch, MAPREDUCE-2549.patch
>
>
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-2549) Potential resource leaks in
HadoopServer.java, RunOnHadoopWizard.java and Environment.java
Posted by "Todd Lipcon (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-2549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13045098#comment-13045098 ]
Todd Lipcon commented on MAPREDUCE-2549:
----------------------------------------
Since this is part of the eclipse plugin which doesn't have unit tests, it's OK not to have them.
But: have you built and used the eclipse plugin with this patch applied? ie manually tested?
> Potential resource leaks in HadoopServer.java, RunOnHadoopWizard.java and Environment.java
> ------------------------------------------------------------------------------------------
>
> Key: MAPREDUCE-2549
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-2549
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: contrib/eclipse-plugin, contrib/streaming
> Affects Versions: 0.23.0
> Reporter: Devaraj K
> Assignee: Devaraj K
> Fix For: 0.23.0
>
> Attachments: MAPREDUCE-2549.patch
>
>
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-2549) Potential resource leaks in
HadoopServer.java, RunOnHadoopWizard.java and Environment.java
Posted by "Devaraj K (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-2549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13041445#comment-13041445 ]
Devaraj K commented on MAPREDUCE-2549:
--------------------------------------
1. If an exception throws while writing, fos will not be closed.
{code:title=HadoopServer.java|borderStyle=solid}
public void storeSettingsToFile(File file) throws IOException {
FileOutputStream fos = new FileOutputStream(file);
this.conf.writeXml(fos);
fos.close();
}
{code}
2. If an exception throws while writing, fos will not be closed.
{code:title=RunOnHadoopWizard.java|borderStyle=solid}
try {
// File confFile = File.createTempFile("core-site-", ".xml",
// confDir);
File confFile = new File(confDir, "core-site.xml");
FileOutputStream fos = new FileOutputStream(confFile);
conf.writeXml(fos);
fos.close();
} catch (IOException ioe) {
ioe.printStackTrace();
return false;
}
{code}
3. If an exception throws while reading, reader will not be closed.
{code:title=Environment.java|borderStyle=solid}
while (true) {
String line = in.readLine();
if (line == null) break;
int p = line.indexOf("=");
if (p != -1) {
String name = line.substring(0, p);
String value = line.substring(p + 1);
setProperty(name, value);
}
}
in.close();
{code}
> Potential resource leaks in HadoopServer.java, RunOnHadoopWizard.java and Environment.java
> ------------------------------------------------------------------------------------------
>
> Key: MAPREDUCE-2549
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-2549
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: contrib/eclipse-plugin, contrib/streaming
> Affects Versions: 0.23.0
> Reporter: Devaraj K
> Assignee: Devaraj K
>
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-2549) Potential resource leaks in
HadoopServer.java, RunOnHadoopWizard.java and Environment.java
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-2549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13105331#comment-13105331 ]
Hudson commented on MAPREDUCE-2549:
-----------------------------------
Integrated in Hadoop-Mapreduce-trunk #831 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk/831/])
Merge -r 1170285:1170286 from branch-0.20-security to trunk to fix MAPREDUCE-2549.
acmurthy : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1170288
Files :
* /hadoop/common/trunk/hadoop-mapreduce-project/src/contrib/eclipse-plugin/src/java/org/apache/hadoop/eclipse/server/HadoopServer.java
* /hadoop/common/trunk/hadoop-mapreduce-project/src/contrib/eclipse-plugin/src/java/org/apache/hadoop/eclipse/servers/RunOnHadoopWizard.java
* /hadoop/common/trunk/hadoop-mapreduce-project/src/contrib/streaming/src/java/org/apache/hadoop/streaming/Environment.java
> Potential resource leaks in HadoopServer.java, RunOnHadoopWizard.java and Environment.java
> ------------------------------------------------------------------------------------------
>
> Key: MAPREDUCE-2549
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-2549
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: contrib/eclipse-plugin, contrib/streaming
> Affects Versions: 0.23.0
> Reporter: Devaraj K
> Assignee: Devaraj K
> Fix For: 0.20.205.0
>
> Attachments: MAPREDUCE-2549-0[1].20.205.patch, MAPREDUCE-2549-1.patch, MAPREDUCE-2549.patch
>
>
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (MAPREDUCE-2549) Potential resource leaks in
HadoopServer.java, RunOnHadoopWizard.java and Environment.java
Posted by "Devaraj K (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-2549?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Devaraj K updated MAPREDUCE-2549:
---------------------------------
Fix Version/s: 0.23.0
Status: Patch Available (was: Open)
> Potential resource leaks in HadoopServer.java, RunOnHadoopWizard.java and Environment.java
> ------------------------------------------------------------------------------------------
>
> Key: MAPREDUCE-2549
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-2549
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: contrib/eclipse-plugin, contrib/streaming
> Affects Versions: 0.23.0
> Reporter: Devaraj K
> Assignee: Devaraj K
> Fix For: 0.23.0
>
> Attachments: MAPREDUCE-2549.patch
>
>
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (MAPREDUCE-2549) Potential resource leaks in
HadoopServer.java, RunOnHadoopWizard.java and Environment.java
Posted by "Arun C Murthy (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-2549?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Arun C Murthy updated MAPREDUCE-2549:
-------------------------------------
Status: Open (was: Patch Available)
Devaraj - did this pass 'ant test-patch' on 0.20.205?
> Potential resource leaks in HadoopServer.java, RunOnHadoopWizard.java and Environment.java
> ------------------------------------------------------------------------------------------
>
> Key: MAPREDUCE-2549
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-2549
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: contrib/eclipse-plugin, contrib/streaming
> Affects Versions: 0.23.0
> Reporter: Devaraj K
> Assignee: Devaraj K
> Fix For: 0.20.205.0, 0.23.0, 0.24.0
>
> Attachments: MAPREDUCE-2549-0[1].20.205.patch, MAPREDUCE-2549-1.patch, MAPREDUCE-2549.patch
>
>
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (MAPREDUCE-2549) Potential resource leaks in
HadoopServer.java, RunOnHadoopWizard.java and Environment.java
Posted by "Devaraj K (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-2549?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Devaraj K updated MAPREDUCE-2549:
---------------------------------
Attachment: MAPREDUCE-2549-1.patch
> Potential resource leaks in HadoopServer.java, RunOnHadoopWizard.java and Environment.java
> ------------------------------------------------------------------------------------------
>
> Key: MAPREDUCE-2549
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-2549
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: contrib/eclipse-plugin, contrib/streaming
> Affects Versions: 0.23.0
> Reporter: Devaraj K
> Assignee: Devaraj K
> Fix For: 0.23.0
>
> Attachments: MAPREDUCE-2549-0[1].20.205.patch, MAPREDUCE-2549-1.patch, MAPREDUCE-2549.patch
>
>
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-2549) Potential resource leaks in
HadoopServer.java, RunOnHadoopWizard.java and Environment.java
Posted by "Devaraj K (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-2549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13103710#comment-13103710 ]
Devaraj K commented on MAPREDUCE-2549:
--------------------------------------
I ran "ant test-patch" on 0.20.205. Please find the local result.
{code:xml}
[exec] -1 overall.
[exec]
[exec] +1 @author. The patch does not contain any @author tags.
[exec]
[exec] -1 tests included. The patch doesn't appear to include any new or modified tests.
[exec] Please justify why no tests are needed for this patch.
[exec]
[exec] +1 javadoc. The javadoc tool did not generate any warning messages.
[exec]
[exec] +1 javac. The applied patch does not increase the total number of javac compiler warnings.
[exec]
[exec] +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.
[exec]
{code}
Tests are not required because this is for the eclipse plugin which doesn't have unit tests. Verified it manually.
> Potential resource leaks in HadoopServer.java, RunOnHadoopWizard.java and Environment.java
> ------------------------------------------------------------------------------------------
>
> Key: MAPREDUCE-2549
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-2549
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: contrib/eclipse-plugin, contrib/streaming
> Affects Versions: 0.23.0
> Reporter: Devaraj K
> Assignee: Devaraj K
> Fix For: 0.20.205.0, 0.23.0, 0.24.0
>
> Attachments: MAPREDUCE-2549-0[1].20.205.patch, MAPREDUCE-2549-1.patch, MAPREDUCE-2549.patch
>
>
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-2549) Potential resource leaks in
HadoopServer.java, RunOnHadoopWizard.java and Environment.java
Posted by "Devaraj K (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-2549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13045265#comment-13045265 ]
Devaraj K commented on MAPREDUCE-2549:
--------------------------------------
Hi Todd, I prepared eclipse plug-in by applying this patch and tested it manually.
> Potential resource leaks in HadoopServer.java, RunOnHadoopWizard.java and Environment.java
> ------------------------------------------------------------------------------------------
>
> Key: MAPREDUCE-2549
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-2549
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: contrib/eclipse-plugin, contrib/streaming
> Affects Versions: 0.23.0
> Reporter: Devaraj K
> Assignee: Devaraj K
> Fix For: 0.23.0
>
> Attachments: MAPREDUCE-2549.patch
>
>
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (MAPREDUCE-2549) Potential resource leaks in
HadoopServer.java, RunOnHadoopWizard.java and Environment.java
Posted by "Devaraj K (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-2549?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Devaraj K updated MAPREDUCE-2549:
---------------------------------
Attachment: MAPREDUCE-2549-0[1].20.205.patch
> Potential resource leaks in HadoopServer.java, RunOnHadoopWizard.java and Environment.java
> ------------------------------------------------------------------------------------------
>
> Key: MAPREDUCE-2549
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-2549
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: contrib/eclipse-plugin, contrib/streaming
> Affects Versions: 0.23.0
> Reporter: Devaraj K
> Assignee: Devaraj K
> Fix For: 0.23.0
>
> Attachments: MAPREDUCE-2549-0[1].20.205.patch, MAPREDUCE-2549-1.patch, MAPREDUCE-2549.patch
>
>
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-2549) Potential resource leaks in
HadoopServer.java, RunOnHadoopWizard.java and Environment.java
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-2549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13103897#comment-13103897 ]
Hudson commented on MAPREDUCE-2549:
-----------------------------------
Integrated in Hadoop-Hdfs-trunk-Commit #960 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/960/])
Merge -r 1170285:1170286 from branch-0.20-security to trunk to fix MAPREDUCE-2549.
acmurthy : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1170288
Files :
* /hadoop/common/trunk/hadoop-mapreduce-project/src/contrib/eclipse-plugin/src/java/org/apache/hadoop/eclipse/server/HadoopServer.java
* /hadoop/common/trunk/hadoop-mapreduce-project/src/contrib/eclipse-plugin/src/java/org/apache/hadoop/eclipse/servers/RunOnHadoopWizard.java
* /hadoop/common/trunk/hadoop-mapreduce-project/src/contrib/streaming/src/java/org/apache/hadoop/streaming/Environment.java
> Potential resource leaks in HadoopServer.java, RunOnHadoopWizard.java and Environment.java
> ------------------------------------------------------------------------------------------
>
> Key: MAPREDUCE-2549
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-2549
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: contrib/eclipse-plugin, contrib/streaming
> Affects Versions: 0.23.0
> Reporter: Devaraj K
> Assignee: Devaraj K
> Fix For: 0.20.205.0
>
> Attachments: MAPREDUCE-2549-0[1].20.205.patch, MAPREDUCE-2549-1.patch, MAPREDUCE-2549.patch
>
>
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-2549) Potential resource leaks in
HadoopServer.java, RunOnHadoopWizard.java and Environment.java
Posted by "Austin wei (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-2549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13164288#comment-13164288 ]
Austin wei commented on MAPREDUCE-2549:
---------------------------------------
Hi,I need help, I've got a "error:failure to login " when using my eclipse 3.7.1 to connect to hadoop 0.20.205.0,after install the plugin from 0.20.205.0
I'found some log information like this file
eclipseworkspace\.metadata\.log
!ENTRY org.eclipse.core.jobs 4 2 2011-12-07 17:43:12.831
!MESSAGE An internal error occurred during: "Connecting to DFS hadoop".
!STACK 0
java.lang.NoClassDefFoundError: org/apache/commons/configuration/Configuration
at org.apache.hadoop.metrics2.lib.DefaultMetricsSystem.<init>(DefaultMetricsSystem.java:37)
at org.apache.hadoop.metrics2.lib.DefaultMetricsSystem.<clinit>(DefaultMetricsSystem.java:34)
at org.apache.hadoop.security.UgiInstrumentation.create(UgiInstrumentation.java:51)
at org.apache.hadoop.security.UserGroupInformation.initialize(UserGroupInformation.java:196)
at org.apache.hadoop.security.UserGroupInformation.ensureInitialized(UserGroupInformation.java:159)
at org.apache.hadoop.security.UserGroupInformation.isSecurityEnabled(UserGroupInformation.java:216)
at org.apache.hadoop.security.KerberosName.<clinit>(KerberosName.java:83)
at org.apache.hadoop.security.UserGroupInformation.initialize(UserGroupInformation.java:189)
at org.apache.hadoop.security.UserGroupInformation.ensureInitialized(UserGroupInformation.java:159)
at org.apache.hadoop.security.UserGroupInformation.isSecurityEnabled(UserGroupInformation.java:216)
at org.apache.hadoop.security.UserGroupInformation.getLoginUser(UserGroupInformation.java:409)
at org.apache.hadoop.security.UserGroupInformation.getCurrentUser(UserGroupInformation.java:395)
at org.apache.hadoop.fs.FileSystem$Cache$Key.<init>(FileSystem.java:1436)
at org.apache.hadoop.fs.FileSystem$Cache.get(FileSystem.java:1337)
at org.apache.hadoop.fs.FileSystem.get(FileSystem.java:244)
at org.apache.hadoop.fs.FileSystem.get(FileSystem.java:122)
at org.apache.hadoop.eclipse.server.HadoopServer.getDFS(HadoopServer.java:469)
at org.apache.hadoop.eclipse.dfs.DFSPath.getDFS(DFSPath.java:146)
at org.apache.hadoop.eclipse.dfs.DFSFolder.loadDFSFolderChildren(DFSFolder.java:61)
at org.apache.hadoop.eclipse.dfs.DFSFolder$1.run(DFSFolder.java:178)
at org.eclipse.core.internal.jobs.Worker.run(Worker.java:54)
Caused by: java.lang.ClassNotFoundException: org.apache.commons.configuration.Configuration
at org.eclipse.osgi.internal.loader.BundleLoader.findClassInternal(BundleLoader.java:513)
at org.eclipse.osgi.internal.loader.BundleLoader.findClass(BundleLoader.java:429)
at org.eclipse.osgi.internal.loader.BundleLoader.findClass(BundleLoader.java:417)
at org.eclipse.osgi.internal.baseadaptor.DefaultClassLoader.loadClass(DefaultClassLoader.java:107)
at java.lang.ClassLoader.loadClass(Unknown Source)
... 21 more
> Potential resource leaks in HadoopServer.java, RunOnHadoopWizard.java and Environment.java
> ------------------------------------------------------------------------------------------
>
> Key: MAPREDUCE-2549
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-2549
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: contrib/eclipse-plugin, contrib/streaming
> Affects Versions: 0.23.0
> Reporter: Devaraj K
> Assignee: Devaraj K
> Fix For: 0.20.205.0
>
> Attachments: MAPREDUCE-2549-0[1].20.205.patch, MAPREDUCE-2549-1.patch, MAPREDUCE-2549.patch
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (MAPREDUCE-2549) Potential resource leaks in
HadoopServer.java, RunOnHadoopWizard.java and Environment.java
Posted by "Devaraj K (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-2549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13099121#comment-13099121 ]
Devaraj K commented on MAPREDUCE-2549:
--------------------------------------
Patch is updated for trunk and also provided for 0.20.205 version.
> Potential resource leaks in HadoopServer.java, RunOnHadoopWizard.java and Environment.java
> ------------------------------------------------------------------------------------------
>
> Key: MAPREDUCE-2549
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-2549
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: contrib/eclipse-plugin, contrib/streaming
> Affects Versions: 0.23.0
> Reporter: Devaraj K
> Assignee: Devaraj K
> Fix For: 0.20.205.0, 0.23.0, 0.24.0
>
> Attachments: MAPREDUCE-2549-0[1].20.205.patch, MAPREDUCE-2549-1.patch, MAPREDUCE-2549.patch
>
>
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (MAPREDUCE-2549) Potential resource leaks in
HadoopServer.java, RunOnHadoopWizard.java and Environment.java
Posted by "Devaraj K (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/MAPREDUCE-2549?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Devaraj K updated MAPREDUCE-2549:
---------------------------------
Status: Open (was: Patch Available)
> Potential resource leaks in HadoopServer.java, RunOnHadoopWizard.java and Environment.java
> ------------------------------------------------------------------------------------------
>
> Key: MAPREDUCE-2549
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-2549
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: contrib/eclipse-plugin, contrib/streaming
> Affects Versions: 0.23.0
> Reporter: Devaraj K
> Assignee: Devaraj K
> Fix For: 0.23.0
>
> Attachments: MAPREDUCE-2549-0[1].20.205.patch, MAPREDUCE-2549-1.patch, MAPREDUCE-2549.patch
>
>
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira