[GitHub] [beam] scwhittle commented on a diff in pull request #21740: convert windmill min timestamp to beam min timestamp

[GitBox <gi...@apache.org>]

scwhittle commented on code in PR #21740:
URL: https://github.com/apache/beam/pull/21740#discussion_r892216449


##########
runners/google-cloud-dataflow-java/worker/src/test/java/org/apache/beam/runners/dataflow/worker/WindmillTimeUtilsTest.java:
##########
@@ -56,6 +56,7 @@ public void testWindmillToHarnessTimestamp() {
     assertEquals(new Instant(-17), windmillToHarnessTimestamp(-16987));
     assertEquals(new Instant(-17), windmillToHarnessTimestamp(-17000));
     assertEquals(new Instant(-18), windmillToHarnessTimestamp(-17001));
+    assertEquals(BoundedWindow.TIMESTAMP_MIN_VALUE, windmillToHarnessTimestamp(Long.MIN_VALUE + 1));

Review Comment:
   Did you verify this test fails without the change to WindmillTimeUtils?
   Looking again I'm wondering if the divideAndRoundDown would have already ended up with this value.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org