[GitHub] [kafka] hachikuji opened a new pull request #11734: MINOR: Do not use optional args in `ProducerStateManager`

[GitBox <gi...@apache.org>]

hachikuji opened a new pull request #11734:
URL: https://github.com/apache/kafka/pull/11734


   We allowed `maxProducerIdExpirationMs` and `time` to be optional in the `ProducerStateManager` constructor. We generally frown on optional arguments since it is too easy to overlook them. In this case, I thought it was especially dangerous because `maxTransactionTimeoutMs` used the same type as `maxProducerIdExpirationMs`.
   
   ### Committer Checklist (excluded from commit message)
   - [ ] Verify design and implementation 
   - [ ] Verify test coverage and CI build status
   - [ ] Verify documentation (including upgrade notes)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] hachikuji merged pull request #11734: MINOR: Do not use optional args in `ProducerStateManager`

[GitBox <gi...@apache.org>]

hachikuji merged pull request #11734:
URL: https://github.com/apache/kafka/pull/11734


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org