(datafusion-comet) branch main updated: minor: Improve exception message for unimplemented CometVector methods (#2291)

[mb...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

mbutrovich pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/datafusion-comet.git


The following commit(s) were added to refs/heads/main by this push:
     new b6b273c1d minor: Improve exception message for unimplemented CometVector methods (#2291)
b6b273c1d is described below

commit b6b273c1de2ab628ae00e77cfe3a57201a515259
Author: Andy Grove <ag...@apache.org>
AuthorDate: Wed Sep 3 14:25:51 2025 -0600

    minor: Improve exception message for unimplemented CometVector methods (#2291)
    
    * improve exception message
    
    * improve exception message
---
 .../java/org/apache/comet/vector/CometVector.java  | 31 +++++++++++++---------
 1 file changed, 18 insertions(+), 13 deletions(-)

diff --git a/common/src/main/java/org/apache/comet/vector/CometVector.java b/common/src/main/java/org/apache/comet/vector/CometVector.java
index 6be8b2866..0c6fa8f12 100644
--- a/common/src/main/java/org/apache/comet/vector/CometVector.java
+++ b/common/src/main/java/org/apache/comet/vector/CometVector.java
@@ -143,66 +143,66 @@ public abstract class CometVector extends ColumnVector {
 
   @Override
   public boolean getBoolean(int rowId) {
-    throw new UnsupportedOperationException("Not yet supported");
+    throw notImplementedException();
   }
 
   @Override
   public byte getByte(int rowId) {
-    throw new UnsupportedOperationException("Not yet supported");
+    throw notImplementedException();
   }
 
   @Override
   public short getShort(int rowId) {
-    throw new UnsupportedOperationException("Not yet supported");
+    throw notImplementedException();
   }
 
   @Override
   public int getInt(int rowId) {
-    throw new UnsupportedOperationException("Not yet supported");
+    throw notImplementedException();
   }
 
   @Override
   public long getLong(int rowId) {
-    throw new UnsupportedOperationException("Not yet supported");
+    throw notImplementedException();
   }
 
   public long getLongDecimal(int rowId) {
-    throw new UnsupportedOperationException("Not yet supported");
+    throw notImplementedException();
   }
 
   @Override
   public float getFloat(int rowId) {
-    throw new UnsupportedOperationException("Not yet supported");
+    throw notImplementedException();
   }
 
   @Override
   public double getDouble(int rowId) {
-    throw new UnsupportedOperationException("Not yet supported");
+    throw notImplementedException();
   }
 
   @Override
   public UTF8String getUTF8String(int rowId) {
-    throw new UnsupportedOperationException("Not yet supported");
+    throw notImplementedException();
   }
 
   @Override
   public byte[] getBinary(int rowId) {
-    throw new UnsupportedOperationException("Not yet supported");
+    throw notImplementedException();
   }
 
   @Override
   public ColumnarArray getArray(int i) {
-    throw new UnsupportedOperationException("Not yet supported");
+    throw notImplementedException();
   }
 
   @Override
   public ColumnarMap getMap(int i) {
-    throw new UnsupportedOperationException("Not yet supported");
+    throw notImplementedException();
   }
 
   @Override
   public ColumnVector getChild(int i) {
-    throw new UnsupportedOperationException("Not yet supported");
+    throw notImplementedException();
   }
 
   @Override
@@ -261,4 +261,9 @@ public abstract class CometVector extends ColumnVector {
   protected static CometVector getVector(ValueVector vector, boolean useDecimal128) {
     return getVector(vector, useDecimal128, null);
   }
+
+  private UnsupportedOperationException notImplementedException() {
+    return new UnsupportedOperationException(
+        "CometVector subclass " + this.getClass().getName() + " does not implement this method");
+  }
 }


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@datafusion.apache.org
For additional commands, e-mail: commits-help@datafusion.apache.org