You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/02/07 10:12:05 UTC
[GitHub] [flink] zentol opened a new pull request #11037:
[FLINK-15949][build] Harden jackson dependency constraints
zentol opened a new pull request #11037: [FLINK-15949][build] Harden jackson dependency constraints
URL: https://github.com/apache/flink/pull/11037
Replaces the individual jackson dependency management entries with the jackson bom, and introduce an enforcer check to ban older jackson dependencies.
The bom import is done in the root pom.xml since around 50 modules have a transitive dependency on jackson, and that's a bit too many to place an individual import into each module.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot commented on issue #11037: [FLINK-15949][build]
Harden jackson dependency constraints
Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #11037: [FLINK-15949][build] Harden jackson dependency constraints
URL: https://github.com/apache/flink/pull/11037#issuecomment-583324479
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit c2d04a63064a3129e52601ff03fecd2f2919d154 (Fri Feb 07 10:15:17 UTC 2020)
**Warnings:**
* **1 pom.xml files were touched**: Check for build and licensing issues.
* No documentation files were touched! Remember to keep the Flink docs up to date!
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] zentol merged pull request #11037: [FLINK-15949][build]
Harden jackson dependency constraints
Posted by GitBox <gi...@apache.org>.
zentol merged pull request #11037: [FLINK-15949][build] Harden jackson dependency constraints
URL: https://github.com/apache/flink/pull/11037
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot commented on issue #11037: [FLINK-15949][build]
Harden jackson dependency constraints
Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #11037: [FLINK-15949][build] Harden jackson dependency constraints
URL: https://github.com/apache/flink/pull/11037#issuecomment-583331666
<!--
Meta data
Hash:c2d04a63064a3129e52601ff03fecd2f2919d154 Status:UNKNOWN URL:TBD TriggerType:PUSH TriggerID:c2d04a63064a3129e52601ff03fecd2f2919d154
-->
## CI report:
* c2d04a63064a3129e52601ff03fecd2f2919d154 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] zentol commented on issue #11037: [FLINK-15949][build]
Harden jackson dependency constraints
Posted by GitBox <gi...@apache.org>.
zentol commented on issue #11037: [FLINK-15949][build] Harden jackson dependency constraints
URL: https://github.com/apache/flink/pull/11037#issuecomment-583821015
azure-fs needs a license update
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11037:
[FLINK-15949][build] Harden jackson dependency constraints
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11037: [FLINK-15949][build] Harden jackson dependency constraints
URL: https://github.com/apache/flink/pull/11037#issuecomment-583331666
<!--
Meta data
Hash:c2d04a63064a3129e52601ff03fecd2f2919d154 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4942 TriggerType:PUSH TriggerID:c2d04a63064a3129e52601ff03fecd2f2919d154
Hash:c2d04a63064a3129e52601ff03fecd2f2919d154 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/147898434 TriggerType:PUSH TriggerID:c2d04a63064a3129e52601ff03fecd2f2919d154
Hash:4fda5ee7015cf3f9a12f3d27e85ebdc0a4d62026 Status:PENDING URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5103 TriggerType:PUSH TriggerID:4fda5ee7015cf3f9a12f3d27e85ebdc0a4d62026
Hash:4fda5ee7015cf3f9a12f3d27e85ebdc0a4d62026 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/148567307 TriggerType:PUSH TriggerID:4fda5ee7015cf3f9a12f3d27e85ebdc0a4d62026
-->
## CI report:
* c2d04a63064a3129e52601ff03fecd2f2919d154 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/147898434) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4942)
* 4fda5ee7015cf3f9a12f3d27e85ebdc0a4d62026 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/148567307) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5103)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] tillrohrmann commented on issue #11037:
[FLINK-15949][build] Harden jackson dependency constraints
Posted by GitBox <gi...@apache.org>.
tillrohrmann commented on issue #11037: [FLINK-15949][build] Harden jackson dependency constraints
URL: https://github.com/apache/flink/pull/11037#issuecomment-583822782
> azure-fs needs a license update
Why?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11037:
[FLINK-15949][build] Harden jackson dependency constraints
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11037: [FLINK-15949][build] Harden jackson dependency constraints
URL: https://github.com/apache/flink/pull/11037#issuecomment-583331666
<!--
Meta data
Hash:c2d04a63064a3129e52601ff03fecd2f2919d154 Status:PENDING URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4942 TriggerType:PUSH TriggerID:c2d04a63064a3129e52601ff03fecd2f2919d154
Hash:c2d04a63064a3129e52601ff03fecd2f2919d154 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/147898434 TriggerType:PUSH TriggerID:c2d04a63064a3129e52601ff03fecd2f2919d154
-->
## CI report:
* c2d04a63064a3129e52601ff03fecd2f2919d154 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/147898434) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4942)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11037:
[FLINK-15949][build] Harden jackson dependency constraints
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11037: [FLINK-15949][build] Harden jackson dependency constraints
URL: https://github.com/apache/flink/pull/11037#issuecomment-583331666
<!--
Meta data
Hash:c2d04a63064a3129e52601ff03fecd2f2919d154 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4942 TriggerType:PUSH TriggerID:c2d04a63064a3129e52601ff03fecd2f2919d154
Hash:c2d04a63064a3129e52601ff03fecd2f2919d154 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/147898434 TriggerType:PUSH TriggerID:c2d04a63064a3129e52601ff03fecd2f2919d154
Hash:4fda5ee7015cf3f9a12f3d27e85ebdc0a4d62026 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5103 TriggerType:PUSH TriggerID:4fda5ee7015cf3f9a12f3d27e85ebdc0a4d62026
Hash:4fda5ee7015cf3f9a12f3d27e85ebdc0a4d62026 Status:SUCCESS URL:https://travis-ci.com/flink-ci/flink/builds/148567307 TriggerType:PUSH TriggerID:4fda5ee7015cf3f9a12f3d27e85ebdc0a4d62026
-->
## CI report:
* c2d04a63064a3129e52601ff03fecd2f2919d154 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/147898434) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4942)
* 4fda5ee7015cf3f9a12f3d27e85ebdc0a4d62026 Travis: [SUCCESS](https://travis-ci.com/flink-ci/flink/builds/148567307) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5103)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11037:
[FLINK-15949][build] Harden jackson dependency constraints
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11037: [FLINK-15949][build] Harden jackson dependency constraints
URL: https://github.com/apache/flink/pull/11037#issuecomment-583331666
<!--
Meta data
Hash:c2d04a63064a3129e52601ff03fecd2f2919d154 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4942 TriggerType:PUSH TriggerID:c2d04a63064a3129e52601ff03fecd2f2919d154
Hash:c2d04a63064a3129e52601ff03fecd2f2919d154 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/147898434 TriggerType:PUSH TriggerID:c2d04a63064a3129e52601ff03fecd2f2919d154
Hash:4fda5ee7015cf3f9a12f3d27e85ebdc0a4d62026 Status:UNKNOWN URL:TBD TriggerType:PUSH TriggerID:4fda5ee7015cf3f9a12f3d27e85ebdc0a4d62026
-->
## CI report:
* c2d04a63064a3129e52601ff03fecd2f2919d154 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/147898434) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4942)
* 4fda5ee7015cf3f9a12f3d27e85ebdc0a4d62026 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11037:
[FLINK-15949][build] Harden jackson dependency constraints
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11037: [FLINK-15949][build] Harden jackson dependency constraints
URL: https://github.com/apache/flink/pull/11037#issuecomment-583331666
<!--
Meta data
Hash:c2d04a63064a3129e52601ff03fecd2f2919d154 Status:PENDING URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4942 TriggerType:PUSH TriggerID:c2d04a63064a3129e52601ff03fecd2f2919d154
Hash:c2d04a63064a3129e52601ff03fecd2f2919d154 Status:PENDING URL:https://travis-ci.com/flink-ci/flink/builds/147898434 TriggerType:PUSH TriggerID:c2d04a63064a3129e52601ff03fecd2f2919d154
-->
## CI report:
* c2d04a63064a3129e52601ff03fecd2f2919d154 Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/147898434) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4942)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11037:
[FLINK-15949][build] Harden jackson dependency constraints
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11037: [FLINK-15949][build] Harden jackson dependency constraints
URL: https://github.com/apache/flink/pull/11037#issuecomment-583331666
<!--
Meta data
Hash:c2d04a63064a3129e52601ff03fecd2f2919d154 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4942 TriggerType:PUSH TriggerID:c2d04a63064a3129e52601ff03fecd2f2919d154
Hash:c2d04a63064a3129e52601ff03fecd2f2919d154 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/147898434 TriggerType:PUSH TriggerID:c2d04a63064a3129e52601ff03fecd2f2919d154
Hash:4fda5ee7015cf3f9a12f3d27e85ebdc0a4d62026 Status:PENDING URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5103 TriggerType:PUSH TriggerID:4fda5ee7015cf3f9a12f3d27e85ebdc0a4d62026
Hash:4fda5ee7015cf3f9a12f3d27e85ebdc0a4d62026 Status:PENDING URL:https://travis-ci.com/flink-ci/flink/builds/148567307 TriggerType:PUSH TriggerID:4fda5ee7015cf3f9a12f3d27e85ebdc0a4d62026
-->
## CI report:
* c2d04a63064a3129e52601ff03fecd2f2919d154 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/147898434) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4942)
* 4fda5ee7015cf3f9a12f3d27e85ebdc0a4d62026 Travis: [PENDING](https://travis-ci.com/flink-ci/flink/builds/148567307) Azure: [PENDING](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=5103)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11037:
[FLINK-15949][build] Harden jackson dependency constraints
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11037: [FLINK-15949][build] Harden jackson dependency constraints
URL: https://github.com/apache/flink/pull/11037#issuecomment-583331666
<!--
Meta data
Hash:c2d04a63064a3129e52601ff03fecd2f2919d154 Status:SUCCESS URL:https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4942 TriggerType:PUSH TriggerID:c2d04a63064a3129e52601ff03fecd2f2919d154
Hash:c2d04a63064a3129e52601ff03fecd2f2919d154 Status:FAILURE URL:https://travis-ci.com/flink-ci/flink/builds/147898434 TriggerType:PUSH TriggerID:c2d04a63064a3129e52601ff03fecd2f2919d154
-->
## CI report:
* c2d04a63064a3129e52601ff03fecd2f2919d154 Travis: [FAILURE](https://travis-ci.com/flink-ci/flink/builds/147898434) Azure: [SUCCESS](https://dev.azure.com/rmetzger/5bd3ef0a-4359-41af-abca-811b04098d2e/_build/results?buildId=4942)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services