You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2022/12/05 09:09:17 UTC

[GitHub] [doris] nextdreamblue opened a new pull request, #14822: [fix][aggregate] agg table and unique table get different result when…

nextdreamblue opened a new pull request, #14822:
URL: https://github.com/apache/doris/pull/14822

   … non-vectorized
   
   when enable_vectorized_engine=false, agg table and unique table get different result, agg table will get replace column value with lower segment id from a rowset, but unique table get the one which has lower segment id.
   
   Signed-off-by: nextdreamblue <zx...@163.com>
   
   # Proposed changes
   
   Issue Number: close #14811
   
   ## Problem summary
   
   Describe your changes.
   
   ## Checklist(Required)
   
   1. Does it affect the original behavior: 
       - [x] Yes
       - [ ] No
       - [ ] I don't know
   2. Has unit tests been added:
       - [ ] Yes
       - [ ] No
       - [x] No Need
   3. Has document been added or modified:
       - [ ] Yes
       - [ ] No
       - [x] No Need
   4. Does it need to update dependencies:
       - [ ] Yes
       - [x] No
   5. Are there any changes that cannot be rolled back:
       - [ ] Yes (If Yes, please explain WHY)
       - [x] No
   
   ## Further comments
   
   If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


[GitHub] [doris] liaoxin01 commented on a diff in pull request #14822: [fix](aggregate) agg table and unique table get different result when…

Posted by GitBox <gi...@apache.org>.
liaoxin01 commented on code in PR #14822:
URL: https://github.com/apache/doris/pull/14822#discussion_r1042083010


##########
be/src/olap/generic_iterators.cpp:
##########
@@ -266,9 +266,17 @@ class MergeIterator : public RowwiseIterator {
             // here we sort segment id in reverse order, because of the row order in AGG_KEYS
             // dose no matter, but in UNIQUE_KEYS table we only read the latest is one, so we
             // return the row in reverse order of segment id
-            bool result = res == 0 ? lhs->data_id() < rhs->data_id() : res < 0;
-            if (_is_unique) {
-                result ? lhs->set_skip(true) : rhs->set_skip(true);
+            bool result = false;

Review Comment:
   Please add some comments.
   The following method may be clearer.
   ```
    if (_is_unique) {
        bool result = res == 0 ? lhs->data_id() < rhs->data_id() : res < 0;
        result ? lhs->set_skip(true) : rhs->set_skip(true);
        return result;
    }     
    return lhs->data_id() > rhs->data_id();
   ```
   
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


[GitHub] [doris] github-actions[bot] commented on pull request #14822: [fix](aggregate) agg table and unique table get different result when…

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #14822:
URL: https://github.com/apache/doris/pull/14822#issuecomment-1341887823

   clang-tidy review says "All clean, LGTM! :+1:"


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


[GitHub] [doris] dataroaring merged pull request #14822: [fix](aggregate) agg table and unique table get different result when…

Posted by GitBox <gi...@apache.org>.
dataroaring merged PR #14822:
URL: https://github.com/apache/doris/pull/14822


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


[GitHub] [doris] nextdreamblue commented on a diff in pull request #14822: [fix](aggregate) agg table and unique table get different result when…

Posted by GitBox <gi...@apache.org>.
nextdreamblue commented on code in PR #14822:
URL: https://github.com/apache/doris/pull/14822#discussion_r1042842623


##########
be/src/olap/generic_iterators.cpp:
##########
@@ -266,9 +266,17 @@ class MergeIterator : public RowwiseIterator {
             // here we sort segment id in reverse order, because of the row order in AGG_KEYS
             // dose no matter, but in UNIQUE_KEYS table we only read the latest is one, so we
             // return the row in reverse order of segment id
-            bool result = res == 0 ? lhs->data_id() < rhs->data_id() : res < 0;
-            if (_is_unique) {
-                result ? lhs->set_skip(true) : rhs->set_skip(true);
+            bool result = false;

Review Comment:
   thanks, it is better



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


[GitHub] [doris] github-actions[bot] commented on pull request #14822: [fix](aggregate) agg table and unique table get different result when…

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #14822:
URL: https://github.com/apache/doris/pull/14822#issuecomment-1341883344

   clang-tidy review says "All clean, LGTM! :+1:"


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


[GitHub] [doris] github-actions[bot] commented on pull request #14822: [fix](aggregate) agg table and unique table get different result when…

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #14822:
URL: https://github.com/apache/doris/pull/14822#issuecomment-1341911690

   PR approved by anyone and no changes requested.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


[GitHub] [doris] github-actions[bot] commented on pull request #14822: [fix](aggregate) agg table and unique table get different result when…

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #14822:
URL: https://github.com/apache/doris/pull/14822#issuecomment-1341882489

   clang-tidy review says "All clean, LGTM! :+1:"


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


[GitHub] [doris] hello-stephen commented on pull request #14822: [fix](aggregate) agg table and unique table get different result when…

Posted by GitBox <gi...@apache.org>.
hello-stephen commented on PR #14822:
URL: https://github.com/apache/doris/pull/14822#issuecomment-1337050612

   TeamCity pipeline, clickbench performance test result:
    the sum of best hot time: 35.08 seconds
    load time: 437 seconds
    storage size: 17123356212 Bytes
    https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20221205095330_clickbench_pr_57874.html


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


[GitHub] [doris] github-actions[bot] commented on pull request #14822: [fix](aggregate) agg table and unique table get different result when…

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #14822:
URL: https://github.com/apache/doris/pull/14822#issuecomment-1337001319

   clang-tidy review says "All clean, LGTM! :+1:"


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org