[GitHub] [iceberg] nastra commented on a diff in pull request #7893: Nessie: Minor Refactoring of NessieTableOperations

["nastra (via GitHub)" <gi...@apache.org>]

nastra commented on code in PR #7893:
URL: https://github.com/apache/iceberg/pull/7893#discussion_r1241938680


##########
nessie/src/main/java/org/apache/iceberg/nessie/NessieIcebergClient.java:
##########
@@ -523,4 +528,49 @@ public void close() {
       api.close();
     }
   }
+
+  public TableMetadata loadTableMetadataWithNessieSpecificProperties(
+      String metadataLocation, IcebergTable table, FileIO fileIO, String identifier) {
+    // Update the TableMetadata with the Content of NessieTableState.
+    TableMetadata deserialized = TableMetadataParser.read(fileIO, metadataLocation);

Review Comment:
   I agree with @dimas-b here. I don't think calling `TableMetadataParser.read(fileIO, metadataLocation)` should actually be in a utility method. There should rather be a method that takes `TableMetadata` and just adds whatever properties Nessie has to set



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org