[jira] Commented: (HBASE-1483) HLog split loses track of edits

["Clint Morgan (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HBASE-1483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12716446#action_12716446 ] 

Clint Morgan commented on HBASE-1483:
-------------------------------------

Just tried to update 0.19 branch and don't see this change.

But I don't think that above patch fixes it. We need to to a new for each iteration of the while(in.next(key,val)) loop...

> HLog split loses track of edits
> -------------------------------
>
>                 Key: HBASE-1483
>                 URL: https://issues.apache.org/jira/browse/HBASE-1483
>             Project: Hadoop HBase
>          Issue Type: Bug
>            Reporter: Clint Morgan
>             Fix For: 0.20.0
>
>         Attachments: 1483.patch
>
>
> HLog:803
>                   queue.push(new HLogEntry(val, key));
> The same val and key references are used in the iterator, so they keep changing their contents as we .next() through the loop.
> Thus, when we are done, all the HLogEntries in logEntries will have the same HLogEdits and HLogKeys! I don't think this would have ever worked unless there is only one region in the log being split.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.