You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@activemq.apache.org by GitBox <gi...@apache.org> on 2021/11/18 18:12:30 UTC

[GitHub] [activemq-artemis] tlbueno opened a new pull request #3861: ARTEMIS-3586 - ActiveMQActivationSpec equals method has switched singleConnection and useJNDI null pointer verification

tlbueno opened a new pull request #3861:
URL: https://github.com/apache/activemq-artemis/pull/3861


   The equals method on ActiveMQActivationSpec has a switched null pointer verification for singleConnection and useJNDI fields. 
   
   Since both fields are initialized with a value by default it should not be a problem but if one of these fields are set as null at some point and then equals is called it throws a NPE.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [activemq-artemis] tlbueno edited a comment on pull request #3861: ARTEMIS-3586 - ActiveMQActivationSpec equals method has switched singleConnection and useJNDI null pointer verification

Posted by GitBox <gi...@apache.org>.
tlbueno edited a comment on pull request #3861:
URL: https://github.com/apache/activemq-artemis/pull/3861#issuecomment-973130155


   @brusdev could you please review it


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [activemq-artemis] tlbueno commented on pull request #3861: ARTEMIS-3586 - ActiveMQActivationSpec equals method has switched singleConnection and useJNDI null pointer verification

Posted by GitBox <gi...@apache.org>.
tlbueno commented on pull request #3861:
URL: https://github.com/apache/activemq-artemis/pull/3861#issuecomment-973130155


   @brusdev 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [activemq-artemis] clebertsuconic merged pull request #3861: ARTEMIS-3586 - ActiveMQActivationSpec equals method has switched singleConnection and useJNDI null pointer verification

Posted by GitBox <gi...@apache.org>.
clebertsuconic merged pull request #3861:
URL: https://github.com/apache/activemq-artemis/pull/3861


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org