[GitHub] [doris] yiguolei commented on a diff in pull request #20349: [fix](olap) deletion statement with space conditions did not take effect

["yiguolei (via GitHub)" <gi...@apache.org>]

yiguolei commented on code in PR #20349:
URL: https://github.com/apache/doris/pull/20349#discussion_r1213813762


##########
be/src/olap/delete_handler.cpp:
##########
@@ -110,7 +110,7 @@ std::string DeleteHandler::construct_sub_predicates(const TCondition& condition)
         } else if (op == "!*=") {
             op = "!=";
         }
-        condition_str = condition.column_name + op + condition.condition_values[0];
+        condition_str = condition.column_name + op + "'" + condition.condition_values[0] + "'";

Review Comment:
   If we upgrade from doris 1.2 and there is a delete condition. It does not contains '', is there error?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org