You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@rocketmq.apache.org by "francisoliverlee (via GitHub)" <gi...@apache.org> on 2023/02/14 12:55:57 UTC

[GitHub] [rocketmq] francisoliverlee commented on a diff in pull request #6061: [ISSUE #6059] the if statement is appended with braces

francisoliverlee commented on code in PR #6061:
URL: https://github.com/apache/rocketmq/pull/6061#discussion_r1105787806


##########
acl/src/main/java/org/apache/rocketmq/acl/common/SessionCredentials.java:
##########
@@ -127,29 +127,38 @@ public int hashCode() {
 
     @Override
     public boolean equals(Object obj) {
-        if (this == obj)
+        if (this == obj) {
             return true;
-        if (obj == null)

Review Comment:
   obj == null 判断应该在最前面



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org