[jira] [Commented] (FLINK-12881) Add more functionalities for ML Params and ParamInfo class

["Shaoxuan Wang (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FLINK-12881?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16875719#comment-16875719 ] 

Shaoxuan Wang commented on FLINK-12881:
---------------------------------------

Fixed in master:1660c6b777747af789fa5c9bf6a3ff77e868ca90

> Add more functionalities for ML Params and ParamInfo class
> ----------------------------------------------------------
>
>                 Key: FLINK-12881
>                 URL: https://issues.apache.org/jira/browse/FLINK-12881
>             Project: Flink
>          Issue Type: Sub-task
>          Components: Library / Machine Learning
>            Reporter: Xu Yang
>            Assignee: Xu Yang
>            Priority: Major
>              Labels: pull-request-available
>          Time Spent: 20m
>  Remaining Estimate: 0h
>
> 1. change Params$get to support aliases
>  * support aliases
>  * if the Params contains the specific parameter and alias, but has more than one value or
>  * if the Params doesn't contains the specific parameter, while the ParamInfo is optional but has no default value, it will throw exception
>  * when isOptional is true, contain(ParamInfo) is true, it will return the value found in Params, whether the value is null or not. when isOptional is true, contain(ParamInfo) is false: hasDefaultValue is true, it will return defaultValue. hasDefaultValue is false, it will throw exception. developer should use contain to check that Params has ParamInfo or not.
> 2. add size, clear, isEmpty, contains, fromJson in Params
> 3. fix ParamInfo, PipelineStage to adapt new Params
>  * assert null in alias
>  * use Params$loadJson in PipelineStage
> 4. add test cases about aliases



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)