You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@openwhisk.apache.org by GitBox <gi...@apache.org> on 2020/03/04 12:21:06 UTC
[GitHub] [openwhisk] markusthoemmes opened a new pull request #4849: Fix
deprecated override warning in ResourceLeakDetector.
markusthoemmes opened a new pull request #4849: Fix deprecated override warning in ResourceLeakDetector.
URL: https://github.com/apache/openwhisk/pull/4849
<!--- Provide a concise summary of your changes in the Title -->
## Description
This class yields an annoying compiler warning like:
```
Note: /Users/mthoemme/dev/openwhisk/tests/src/test/scala/org/apache/openwhisk/core/database/cosmosdb/RecordingLeakDetectorFactory.java uses or overrides a deprecated API.
Note: Recompile with -Xlint:deprecation for details.
```
Sadly, we need to override the method as it is abstract. Suppressing the warning should be fine in that case.
## Checklist:
<!--- Please review the points below which help you make sure you've covered all aspects of the change you're making. -->
- [X] I signed an [Apache CLA](https://github.com/apache/openwhisk/blob/master/CONTRIBUTING.md).
- [X] I reviewed the [style guides](https://github.com/apache/openwhisk/wiki/Contributing:-Git-guidelines#code-readiness) and followed the recommendations (Travis CI will check :).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [openwhisk] rabbah merged pull request #4849: Fix deprecated
override warning in ResourceLeakDetector.
Posted by GitBox <gi...@apache.org>.
rabbah merged pull request #4849: Fix deprecated override warning in ResourceLeakDetector.
URL: https://github.com/apache/openwhisk/pull/4849
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [openwhisk] markusthoemmes commented on issue #4849: Fix deprecated
override warning in ResourceLeakDetector.
Posted by GitBox <gi...@apache.org>.
markusthoemmes commented on issue #4849: Fix deprecated override warning in ResourceLeakDetector.
URL: https://github.com/apache/openwhisk/pull/4849#issuecomment-594588275
@rabbah The suggested replacement is only for people using the base class. For overriding (at least if my Java ain't too rusty) we need to override the abstract member with an explicit implementation (which sadly is also the deprecated thingy here).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [openwhisk] rabbah commented on issue #4849: Fix deprecated
override warning in ResourceLeakDetector.
Posted by GitBox <gi...@apache.org>.
rabbah commented on issue #4849: Fix deprecated override warning in ResourceLeakDetector.
URL: https://github.com/apache/openwhisk/pull/4849#issuecomment-594558904
> uses or overrides a deprecated API.
what's the replacement? can we migrate?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services