[GitHub] [incubator-pekko] pjfanning commented on pull request #587: fix managerName to use `pekko`

["pjfanning (via GitHub)" <gi...@apache.org>]

pjfanning commented on PR #587:
URL: https://github.com/apache/incubator-pekko/pull/587#issuecomment-1690692979

   I suspect that we are better off not changing this in Pekko 1.0.x.
   
   This line in the deprecated classic remoting code is the one that worries me (a little).
   ```
     private def registerManager(): Future[ActorRef] =
       (system.actorSelection("/system/transports") ? RegisterTransportActor(managerProps, managerName)).mapTo[ActorRef]
   ```
   
   It may even be best to just to leave this as is. The name ultimately doesn't matter that much and it may not be worth taking the risk that changing it could break something.
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org