You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@inlong.apache.org by GitBox <gi...@apache.org> on 2022/06/06 12:15:17 UTC

[GitHub] [incubator-inlong] thexiay opened a new pull request, #4293: [INLONG-4292][Agent][TubeMQ][Sort] Upgrade the property file from log4j to log4j2

thexiay opened a new pull request, #4293:
URL: https://github.com/apache/incubator-inlong/pull/4293

   ### Title Name: [INLONG-4292][Agent][TubeMQ][Sort] Upgrade the property file from log4j to log4j2
   
   Fixes #4292
   
   ### Motivation
   
   Update all module log4j properties upgrade to log4j2 properties
   
   ### Modifications
   
   upgrade log4j properties to log4j2 properties


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-inlong] yunqingmoswu commented on a diff in pull request #4293: [INLONG-4292][Agent][TubeMQ][Sort] Upgrade the property file from log4j to log4j2

Posted by GitBox <gi...@apache.org>.
yunqingmoswu commented on code in PR #4293:
URL: https://github.com/apache/incubator-inlong/pull/4293#discussion_r879007700


##########
inlong-sort/sort-core/src/test/resources/log4j2-test.properties:
##########
@@ -16,13 +16,18 @@
 # specific language governing permissions and limitations
 # under the License.
 #
-log4j.rootLogger=INFO, testlogger
-# testlogger is set to be a ConsoleAppender.
-log4j.appender.testlogger=org.apache.log4j.ConsoleAppender
-log4j.appender.testlogger.target=System.err
-log4j.appender.testlogger.layout=org.apache.log4j.PatternLayout
-log4j.appender.testlogger.layout.ConversionPattern=%-4r [%t] %-5p %c %x - %m%n
+rootLogger=INFO, testlogger

Review Comment:
   May be add this to sort-core/src/resources?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-inlong] healchow merged pull request #4293: [INLONG-4292][Agent][TubeMQ][Sort] Upgrade the property file from log4j to log4j2

Posted by GitBox <gi...@apache.org>.
healchow merged PR #4293:
URL: https://github.com/apache/incubator-inlong/pull/4293


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [incubator-inlong] gong commented on pull request #4293: [INLONG-4292][Agent][TubeMQ][Sort] Upgrade the property file from log4j to log4j2

Posted by GitBox <gi...@apache.org>.
gong commented on PR #4293:
URL: https://github.com/apache/incubator-inlong/pull/4293#issuecomment-1134159442

   pom of `sort-dist` need change about `log4j`


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org