You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Dominic Hamon <dh...@twopensource.com> on 2014/10/08 23:55:29 UTC
Review Request 26459: Differentiate between slave and offer ids
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26459/
-----------------------------------------------------------
Review request for mesos and Vinod Kone.
Repository: mesos-git
Description
-------
slave and offer ids can be identical which is confusing in logs
Diffs
-----
src/master/master.cpp f05275b00635cee82007ed851bba1cd30a7aa74f
Diff: https://reviews.apache.org/r/26459/diff/
Testing
-------
make check
Thanks,
Dominic Hamon
Re: Review Request 26459: Differentiate between slave and offer ids
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26459/#review57890
-----------------------------------------------------------
Ship it!
Ship It!
- Vinod Kone
On Oct. 22, 2014, 8:30 p.m., Dominic Hamon wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26459/
> -----------------------------------------------------------
>
> (Updated Oct. 22, 2014, 8:30 p.m.)
>
>
> Review request for mesos and Vinod Kone.
>
>
> Bugs: MESOS-1970
> https://issues.apache.org/jira/browse/MESOS-1970
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> slave and offer ids can be identical which is confusing in logs
>
>
> Diffs
> -----
>
> src/master/master.cpp f05275b00635cee82007ed851bba1cd30a7aa74f
>
> Diff: https://reviews.apache.org/r/26459/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Dominic Hamon
>
>
Re: Review Request 26459: Differentiate between slave and offer ids
Posted by Dominic Hamon <dh...@twopensource.com>.
> On Oct. 22, 2014, 1:42 p.m., Ben Mahler wrote:
> > Why stick the S and O in the middle of the ID, why not as a prefix?
to retain the format: masterid + - + slave/offerid. The S/O becomes part of the slave/offer id.
- Dominic
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26459/#review57892
-----------------------------------------------------------
On Oct. 22, 2014, 1:30 p.m., Dominic Hamon wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26459/
> -----------------------------------------------------------
>
> (Updated Oct. 22, 2014, 1:30 p.m.)
>
>
> Review request for mesos and Vinod Kone.
>
>
> Bugs: MESOS-1970
> https://issues.apache.org/jira/browse/MESOS-1970
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> slave and offer ids can be identical which is confusing in logs
>
>
> Diffs
> -----
>
> src/master/master.cpp f05275b00635cee82007ed851bba1cd30a7aa74f
>
> Diff: https://reviews.apache.org/r/26459/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Dominic Hamon
>
>
Re: Review Request 26459: Differentiate between slave and offer ids
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26459/#review57892
-----------------------------------------------------------
Why stick the S and O in the middle of the ID, why not as a prefix?
- Ben Mahler
On Oct. 22, 2014, 8:30 p.m., Dominic Hamon wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26459/
> -----------------------------------------------------------
>
> (Updated Oct. 22, 2014, 8:30 p.m.)
>
>
> Review request for mesos and Vinod Kone.
>
>
> Bugs: MESOS-1970
> https://issues.apache.org/jira/browse/MESOS-1970
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> slave and offer ids can be identical which is confusing in logs
>
>
> Diffs
> -----
>
> src/master/master.cpp f05275b00635cee82007ed851bba1cd30a7aa74f
>
> Diff: https://reviews.apache.org/r/26459/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Dominic Hamon
>
>
Re: Review Request 26459: Differentiate between slave and offer ids
Posted by Dominic Hamon <dh...@twopensource.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26459/
-----------------------------------------------------------
(Updated Oct. 22, 2014, 1:30 p.m.)
Review request for mesos and Vinod Kone.
Changes
-------
added bug reference
Bugs: MESOS-1970
https://issues.apache.org/jira/browse/MESOS-1970
Repository: mesos-git
Description
-------
slave and offer ids can be identical which is confusing in logs
Diffs
-----
src/master/master.cpp f05275b00635cee82007ed851bba1cd30a7aa74f
Diff: https://reviews.apache.org/r/26459/diff/
Testing
-------
make check
Thanks,
Dominic Hamon
Re: Review Request 26459: Differentiate between slave and offer ids
Posted by Mesos ReviewBot <de...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26459/#review55888
-----------------------------------------------------------
Patch looks great!
Reviews applied: [26459]
All tests passed.
- Mesos ReviewBot
On Oct. 8, 2014, 9:55 p.m., Dominic Hamon wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26459/
> -----------------------------------------------------------
>
> (Updated Oct. 8, 2014, 9:55 p.m.)
>
>
> Review request for mesos and Vinod Kone.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> slave and offer ids can be identical which is confusing in logs
>
>
> Diffs
> -----
>
> src/master/master.cpp f05275b00635cee82007ed851bba1cd30a7aa74f
>
> Diff: https://reviews.apache.org/r/26459/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Dominic Hamon
>
>