You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@kyuubi.apache.org by GitBox <gi...@apache.org> on 2022/03/28 02:14:17 UTC

[GitHub] [incubator-kyuubi] wForget commented on a change in pull request #2230: [KYUUBI #1962] Add timeout check for createSpark

wForget commented on a change in pull request #2230:
URL: https://github.com/apache/incubator-kyuubi/pull/2230#discussion_r836009732



##########
File path: externals/kyuubi-spark-sql-engine/src/main/scala/org/apache/kyuubi/engine/spark/SparkSQLEngine.scala
##########
@@ -195,8 +196,11 @@ object SparkSQLEngine extends Logging {
         s" and submitted at $submitTime.")
     } else {
       var spark: SparkSession = null
+      val checkFlag = new AtomicBoolean(false)

Review comment:
       > we can define it as global, and the name should be refine, maybe like `sparkSessionCreated`
   
   thanks, i will do that




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org