[GitHub] [submarine] pingsutw commented on a change in pull request #323: SUBMARINE-542. [SDK] get_log error when experiment is not started

[GitBox <gi...@apache.org>]

pingsutw commented on a change in pull request #323:
URL: https://github.com/apache/submarine/pull/323#discussion_r444110040



##########
File path: submarine-sdk/pysubmarine/submarine/experiment/api/experiment_client.py
##########
@@ -110,19 +113,19 @@ def delete_experiment(self, id):
         response = self.experiment_api.delete_experiment(id)
         return response.result
 
-    def get_log(self, id, master=True):
+    def get_log(self, id, master=False):
         """
         Get training logs of the experiment.
         By default only get the logs of Pod that has labels 'job-role: master'.
-        :param master: By default get pod with label 'job-role: master' pod if True.
+        :param master: Get pod with label 'job-role: master' pod if True.

Review comment:
       I just follow the convention in `tf-operator` 
   https://github.com/kubeflow/tf-operator/blob/cf6ebd6d2d9f679646dad3530e9314f63505f98a/sdk/python/kubeflow/tfjob/api/tf_job_client.py#L356-L371
   Maybe we could change the description, so it will be more clear for the users.
   Any suggestion for the comments and param in `get_log`




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org