You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "sarutak (via GitHub)" <gi...@apache.org> on 2026/03/10 04:11:27 UTC
[PR] [SPARK-55913][INFRA] Add `.kiro` to `.gitignore` [spark]
sarutak opened a new pull request, #54712:
URL: https://github.com/apache/spark/pull/54712
### What changes were proposed in this pull request?
This PR proposes to add `.kiro` to `.gitignore`.
### Why are the changes needed?
Kiro loads/stores its configuration in `.kiro` so this should be ignored.
### Does this PR introduce _any_ user-facing change?
No.
### How was this patch tested?
Manually confirmed `.kiro` is not listed by `git status`.
### Was this patch authored or co-authored using generative AI tooling?
No.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-55913][INFRA] Add `.kiro` to `.gitignore` [spark]
Posted by "sarutak (via GitHub)" <gi...@apache.org>.
sarutak commented on PR #54712:
URL: https://github.com/apache/spark/pull/54712#issuecomment-4035105565
Thank you for the feedback, @dongjoon-hyun .
So, for now, I'll hold off on backporting it. If I later feel that backporting would be more convenient, I'll open a PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-55913][INFRA] Add `.kiro` to `.gitignore` [spark]
Posted by "sarutak (via GitHub)" <gi...@apache.org>.
sarutak commented on PR #54712:
URL: https://github.com/apache/spark/pull/54712#issuecomment-4029055101
@pan3793 It's not a bug but I personally think it's worth porting to active branches (`branch-3.5`, `branch-4.0`, branch-4.1`).
What do you think, @dongjoon-hyun ?
Also cc: @yaooqinn who uses Copilot.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-55913][INFRA] Add `.kiro` to `.gitignore` [spark]
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun closed pull request #54712: [SPARK-55913][INFRA] Add `.kiro` to `.gitignore`
URL: https://github.com/apache/spark/pull/54712
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-55913][INFRA] Add `.kiro` to `.gitignore` [spark]
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on PR #54712:
URL: https://github.com/apache/spark/pull/54712#issuecomment-4035108798
Thank you!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-55913][INFRA] Add `.kiro` to `.gitignore` [spark]
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on PR #54712:
URL: https://github.com/apache/spark/pull/54712#issuecomment-4032917849
Merged to master.
For me, I'm a little conservative. Especially, if we are talking about branch-3.5, I'm more negative, @pan3793 and @sarutak . :)
There is no mess-up regression here because the old branches are simply in the same situation without this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org