[GitHub] [hadoop] virajjasani commented on a diff in pull request #5407: HDFS-16925. Namenode audit log to only include IP address of client

["virajjasani (via GitHub)" <gi...@apache.org>]

virajjasani commented on code in PR #5407:
URL: https://github.com/apache/hadoop/pull/5407#discussion_r1109234913


##########
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java:
##########
@@ -8787,7 +8787,10 @@ public void logAuditEvent(boolean succeeded, String userName,
         sb.setLength(0);
         sb.append("allowed=").append(succeeded).append("\t")
             .append("ugi=").append(userName).append("\t")
-            .append("ip=").append(addr).append("\t")
+            // InetAddress#tostring can also return hostname in addition to IP address.
+            // To not include hostname regardless of the hostname resolution, we should
+            // only include IP address here. See HADOOP-18628.

Review Comment:
   Done



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org