You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@geode.apache.org by "rhoughton-pivot (GitHub)" <gi...@apache.org> on 2019/01/23 19:53:24 UTC

[GitHub] [geode] rhoughton-pivot opened pull request #3113: GEODE-6314 Only rolling build-version semver at build time

* Upload new verison immediately
* Use consistent 'pre' for the version id
* Fix the 'get' for Windows, Publish, Benchmark jobs

Co-authored-by: Patrick Rhomberg <pr...@pivotal.io>
Co-authored-by: Robert Houghton <rh...@pivotal.io>

Thank you for submitting a contribution to Apache Geode.

In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:

### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?

- [ ] Has your PR been rebased against the latest commit within the target branch (typically `develop`)?

- [ ] Is your initial contribution a single, squashed commit?

- [ ] Does `gradlew build` run cleanly?

- [ ] Have you written or updated unit tests to verify your changes?

- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?

### Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and
submit an update to your PR as soon as possible. If you need help, please send an
email to dev@geode.apache.org.


[ Full content available at: https://github.com/apache/geode/pull/3113 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] rhoughton-pivot closed pull request #3113: GEODE-6314 Only rolling build-version semver at build time

Posted by "rhoughton-pivot (GitHub)" <gi...@apache.org>.
[ pull request closed by rhoughton-pivot ]

[ Full content available at: https://github.com/apache/geode/pull/3113 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] PurelyApplied commented on issue #3113: GEODE-6314 Only rolling build-version semver at build time

Posted by "PurelyApplied (GitHub)" <gi...@apache.org>.
As these are `ci` changes, they have been tested in a personal pipeline.  Seems to do the trick, though

[ Full content available at: https://github.com/apache/geode/pull/3113 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] PurelyApplied commented on issue #3113: GEODE-6314 Only rolling build-version semver at build time

Posted by "PurelyApplied (GitHub)" <gi...@apache.org>.
Also cleaned up resource passing so there aren't all these `Build` outputs getting passed under the initial testing phase, but instead are properly passed *through* that phase.

[ Full content available at: https://github.com/apache/geode/pull/3113 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org