You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Jie Yu <yu...@gmail.com> on 2015/04/28 19:55:30 UTC
Review Request 33631: Fixed a bug in port mapping isolator which will
cause SIGABRT during slave recovery.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33631/
-----------------------------------------------------------
Review request for mesos, Ben Mahler, Chi Zhang, and Ian Downes.
Bugs: MESOS-2671
https://issues.apache.org/jira/browse/MESOS-2671
Repository: mesos
Description
-------
Fixed a bug in port mapping isolator which will cause SIGABRT during slave recovery.
Diffs
-----
src/slave/containerizer/isolators/network/port_mapping.cpp 24cb4ba69c463fb7d2bba0786474fc8a14c92ea0
Diff: https://reviews.apache.org/r/33631/diff/
Testing
-------
make check
Thanks,
Jie Yu
Re: Review Request 33631: Fixed a bug in port mapping isolator which
will cause SIGABRT during slave recovery.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33631/#review81857
-----------------------------------------------------------
Patch looks great!
Reviews applied: [33631]
All tests passed.
- Mesos ReviewBot
On April 28, 2015, 5:55 p.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33631/
> -----------------------------------------------------------
>
> (Updated April 28, 2015, 5:55 p.m.)
>
>
> Review request for mesos, Ben Mahler, Chi Zhang, and Ian Downes.
>
>
> Bugs: MESOS-2671
> https://issues.apache.org/jira/browse/MESOS-2671
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Fixed a bug in port mapping isolator which will cause SIGABRT during slave recovery.
>
>
> Diffs
> -----
>
> src/slave/containerizer/isolators/network/port_mapping.cpp 24cb4ba69c463fb7d2bba0786474fc8a14c92ea0
>
> Diff: https://reviews.apache.org/r/33631/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Jie Yu
>
>
Re: Review Request 33631: Fixed a bug in port mapping isolator which
will cause SIGABRT during slave recovery.
Posted by Chi Zhang <ch...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33631/#review81846
-----------------------------------------------------------
Ship it!
Ship It!
- Chi Zhang
On April 28, 2015, 5:55 p.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33631/
> -----------------------------------------------------------
>
> (Updated April 28, 2015, 5:55 p.m.)
>
>
> Review request for mesos, Ben Mahler, Chi Zhang, and Ian Downes.
>
>
> Bugs: MESOS-2671
> https://issues.apache.org/jira/browse/MESOS-2671
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Fixed a bug in port mapping isolator which will cause SIGABRT during slave recovery.
>
>
> Diffs
> -----
>
> src/slave/containerizer/isolators/network/port_mapping.cpp 24cb4ba69c463fb7d2bba0786474fc8a14c92ea0
>
> Diff: https://reviews.apache.org/r/33631/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Jie Yu
>
>
Re: Review Request 33631: Fixed a bug in port mapping isolator which
will cause SIGABRT during slave recovery.
Posted by Ian Downes <ia...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33631/#review81848
-----------------------------------------------------------
Ship it!
Ship It!
- Ian Downes
On April 28, 2015, 10:55 a.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33631/
> -----------------------------------------------------------
>
> (Updated April 28, 2015, 10:55 a.m.)
>
>
> Review request for mesos, Ben Mahler, Chi Zhang, and Ian Downes.
>
>
> Bugs: MESOS-2671
> https://issues.apache.org/jira/browse/MESOS-2671
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Fixed a bug in port mapping isolator which will cause SIGABRT during slave recovery.
>
>
> Diffs
> -----
>
> src/slave/containerizer/isolators/network/port_mapping.cpp 24cb4ba69c463fb7d2bba0786474fc8a14c92ea0
>
> Diff: https://reviews.apache.org/r/33631/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Jie Yu
>
>