[GitHub] [incubator-pekko-grpc] jrudolph commented on pull request #23: uptake pekko jars, use pekko names in packages and configs

["jrudolph (via GitHub)" <gi...@apache.org>]

jrudolph commented on PR #23:
URL: https://github.com/apache/incubator-pekko-grpc/pull/23#issuecomment-1446417775

   Great stuff!
   
   > * temporarily added akka-http-cors in this repo because that lib does not yet support pekko - but soon will
   
   Isn't that a blocker for merging this PR for now? Feels wrong to add third-party code in such a big commit just to get everything working right now.
   
   How about we just disable cors support for now to make this PR mergable (it's only used in four lines in the code) and then decide afterwards if we want to temporarily enable by importing the third-party project in its own PR or wait until the project itself has released something?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org