[GitHub] larroy commented on a change in pull request #11245: [MXNET-244][MXNET-523][ARM] improvements to ARMv7 based builds.

[GitBox <gi...@apache.org>]

larroy commented on a change in pull request #11245: [MXNET-244][MXNET-523][ARM] improvements to ARMv7 based builds.
URL: https://github.com/apache/incubator-mxnet/pull/11245#discussion_r194947843
 
 

 ##########
 File path: tests/python/unittest/test_ndarray.py
 ##########
 @@ -711,9 +711,8 @@ def get_values(ensure_unique):
                  k=dat_size*dat_size*dat_size*dat_size, is_ascend=False)
     assert_almost_equal(nd_ret_argsort, gt)
 
-    # test topk with a big shape
-    a = mx.nd.arange(0, 54686454, step=1, repeat=1)
-    assert_almost_equal(a.topk(k=54686454).asnumpy(), a.asnumpy()[::-1])
+    a = mx.nd.arange(0, 1024, step=1, repeat=1)
+    assert_almost_equal(a.topk(k=1024).asnumpy(), a.asnumpy()[::-1])
 
 Review comment:
   I have discussed at length that is not ok to reserve a 4gb ndarray. The author that introduced this test should have done a cpp unit test for the specific regression that he targetted. This is blocking raspberry pi validation. We have customers that need to run the core unit tests on device, as well as we do. Please don't block our work of bringing mxnet to resource constraint devices.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services