[jira] [Created] (SOLR-18532) RestoreCore rollback deletes index.properties instead of restoring the previous pointer

["Nick Shanin (Jira)" <ji...@apache.org>]

Nick Shanin created SOLR-18532:
----------------------------------

             Summary: RestoreCore rollback deletes index.properties instead of restoring the previous pointer
                 Key: SOLR-18532
                 URL: https://issues.apache.org/jira/browse/SOLR-18532
             Project: Solr
          Issue Type: Bug
          Components: Backup/Restore
            Reporter: Nick Shanin


AI text below

h2. What happens

When a restore or install-shard operation rolls back, \{{RestoreCore}} deletes \{{index.properties}} instead of restoring the pointer that was in place before the operation (\{{RestoreCore.java}} line 227). For a core on the default index directory the two are equivalent. For a core that had a non-default index, the rollback loses the previous pointer.

h2. How it was found

Code reading during a root-cause analysis of flaky backup test failures; the flake itself had a different cause. The current backup tests install into fresh collections, so no test covers the non-default case.

h2. Proposed fix

On rollback, restore the previous \{{index.properties}} content when one existed, and delete the file only when the operation created it.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org