You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2019/11/12 00:48:20 UTC

[GitHub] [airflow] mik-laj commented on a change in pull request #6549: [AIRFLOW-5880] Enforce unique task ids

mik-laj commented on a change in pull request #6549: [AIRFLOW-5880] Enforce unique task ids
URL: https://github.com/apache/airflow/pull/6549#discussion_r344973262
 
 

 ##########
 File path: airflow/models/dag.py
 ##########
 @@ -1190,13 +1189,8 @@ def add_task(self, task):
             task.end_date = min(task.end_date, self.end_date)
 
         if task.task_id in self.task_dict:
 
 Review comment:
   ```
   dag =  DAG("test_dag", start_date=DEFAULT_DATE):
   dag.add_task(t1)
   dag.add_task(t1)
   ```
   Will this code still work?  In my opinion, re-adding the same task should not cause an exception.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services