You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2021/01/05 03:44:02 UTC
[GitHub] [tvm] jwfromm opened a new pull request #7208: [Relay][Frontend][Onnx] Fix mismatch between Onnx Prelu definition and importer.
jwfromm opened a new pull request #7208:
URL: https://github.com/apache/tvm/pull/7208
Our current prelu converter assumes that incoming data is in NCHW format and that the slope will have C total elements. Neither of these are actual requirements for ONNX PreLu. As pointed out in https://github.com/apache/tvm/issues/7202, our converter fails in other cases. This PR makes our importer prelu compliant with the onnx spec.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] jwfromm commented on pull request #7208: [Relay][Frontend][Onnx] Fix mismatch between Onnx Prelu definition and importer.
Posted by GitBox <gi...@apache.org>.
jwfromm commented on pull request #7208:
URL: https://github.com/apache/tvm/pull/7208#issuecomment-754406762
These two errors that you generated were excellent real bugs with the importer and were very easy to understand and replicate with your post. If they're being auto-generated they look excellent!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] masahi edited a comment on pull request #7208: [Relay][Frontend][Onnx] Fix mismatch between Onnx Prelu definition and importer.
Posted by GitBox <gi...@apache.org>.
masahi edited a comment on pull request #7208:
URL: https://github.com/apache/tvm/pull/7208#issuecomment-754410295
Hi @luyaor you are welcome to poke at pytorch frontend too, I hope it is more robust than onnx frontend :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] luyaor commented on pull request #7208: [Relay][Frontend][Onnx] Fix mismatch between Onnx Prelu definition and importer.
Posted by GitBox <gi...@apache.org>.
luyaor commented on pull request #7208:
URL: https://github.com/apache/tvm/pull/7208#issuecomment-754398110
Hi @jwfromm @mbrookhart , thanks for the response and effort on this case. The PR looks good to me.
I am currently working on the research project related to TVM, would like to make more contributions to TVM and also looking forward to the feedback from community.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] masahi commented on pull request #7208: [Relay][Frontend][Onnx] Fix mismatch between Onnx Prelu definition and importer.
Posted by GitBox <gi...@apache.org>.
masahi commented on pull request #7208:
URL: https://github.com/apache/tvm/pull/7208#issuecomment-754410295
Hi @luyaor you are welcome to poke at pytorch frontend too, I hope it is more robust then onnx frontend :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] masahi merged pull request #7208: [Relay][Frontend][Onnx] Fix mismatch between Onnx Prelu definition and importer.
Posted by GitBox <gi...@apache.org>.
masahi merged pull request #7208:
URL: https://github.com/apache/tvm/pull/7208
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] luyaor edited a comment on pull request #7208: [Relay][Frontend][Onnx] Fix mismatch between Onnx Prelu definition and importer.
Posted by GitBox <gi...@apache.org>.
luyaor edited a comment on pull request #7208:
URL: https://github.com/apache/tvm/pull/7208#issuecomment-754398110
Hi @jwfromm @mbrookhart , thanks for the response and effort on this case. The PR looks good to me.
I am currently working on a research project related to TVM, would like to make more contributions to TVM and also looking forward to the feedback from community.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] jwfromm commented on pull request #7208: [Relay][Frontend][Onnx] Fix mismatch between Onnx Prelu definition and importer.
Posted by GitBox <gi...@apache.org>.
jwfromm commented on pull request #7208:
URL: https://github.com/apache/tvm/pull/7208#issuecomment-754372193
@luyaor @mbrookhart @masahi can you guys take a look at this tiny PR?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org